Fix the issues reported by phpcs

Above warnings has been fixed.

Patch applied successfully and solved the issues specified...Marking as RTBC

+  - drupal:block
+  - drupal:entity_reference_revisions
+  - drupal:field
+  - drupal:file
+  - drupal:image
+  - drupal:link
+  - drupal:menu_ui
+  - drupal:node
+  - drupal:paragraphs
+  - drupal:path
+  - drupal:text
+  - drupal:user
+  - drupal:views
 

phpcs does not say the dependencies must start with drupal:, but that the dependencies must be namespaced. The change is not using the correct namespaces for some of those modules.

Hi @apaderno,

Patch updated.

interdiff with #2 📌 Fix the issues reported by phpcs Needs review

The last patch applies all the suggested changes.

@apaderno: Thanks for providing guidance on this issue and +1 for changing the priority to Minor.

Reviewing the comments, I do not see any mention of testing (the "T" in RTBC). I am setting the status back to NR.

Looking at the patch, I wondered why there were so many dependencies. I think the answer is that I used the Features module to generate the first draft of this module. (I split it up into several commits because I believe in having atomic commits.)

That made me wonder whether the list is complete, so I tested with an installation using the Minimal profile. I got an error message when visiting the config page, /admin/structure/paragraphs_type/ptoc. I fixed it by enabling the field_ui module. I considered adding that as a dependency, but some sites do not enable field_ui nor views_ui on production, so that is not a good idea.

Following up on Comment #4: drupal: is used for core modules. For most contrib modules, the namespace is the package name on d.o. For example, if this module required the Paragraphs Type Permissions submodule from the Paragraphs module, the dependency would be paragraphs:paragraphs_type_permissions.

Reference: Let Drupal know about your module with an .info.yml file → .

I added 🐛 WSOD on config page if field_ui is not enabled Active to deal with the WSOD I mentioned in #7.