- Issue created by @urvashi_vora
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 11:42am 1 March 2023 - Status changed to Needs work
almost 2 years ago 6:42am 9 March 2023 - Status changed to Needs review
almost 2 years ago 6:48am 9 March 2023 - ๐ฎ๐ณIndia urvashi_vora Madhya Pradesh, India
Since, @kkalashnikov provided a patch, moving it to 'Needs Review'
- ๐ฎ๐ณIndia Akram Khan Cuttack, Odisha
checked patch #5 it's apply cleanly and remove all PHPCS issue
- Status changed to RTBC
almost 2 years ago 8:08am 9 March 2023 - Status changed to Needs work
almost 2 years ago 8:44am 9 March 2023 - ๐ณ๐ฟNew Zealand xurizaemon ลtepoti, Aotearoa ๐
As requested in #4, please remove (or explain) the proposed changes to the README.
Splitting commands into multiple lines is not an improvement. Those are instructions meant to be copied; by reformatting them to follow a fixed line length, you are making documentation WORSE in order to satisfy a lint check.
- Status changed to Closed: won't fix
almost 2 years ago 10:02pm 13 March 2023 - heddn Nicaragua
This has too much out of scope change included. The
unserialize
changes make sense. The rest is just noise and will make it hard to re-roll other patches. If we want to open up a new ticket w/ only the unserialize changes, please do that. Thanks for your contributions.