Fix the issues reported by phpcs

PHPCS issues are resolved in MR of #2.

MR reviewed and it is. working fine...Marking as RTBC.

+        '' => t('None(ie.same window)'),
+        '_blank' => t('New window (_blank)'),
+        '_top' => t('Top window (_top)'),
+        '_self' => t('Same window (_self)'),

Since those lines are changed, a space is missing before the opening parenthesis. ie.same is not the correct spelling, and i.e. would not even be necessary.

+  /**
+   * Drupal\Core\Database\Database definition.
+   *
+   * @var Drupal\Core\Database\Database
+   */
   public $db;

That is not the comment used for properties. The namespace includes the \ at the beginning.

+        '' => t('None(ie.same window)'),
+        '_blank' => t('New window(_blank)'),

See my previous comment.

+  /**
+   * Database definition.
+   *
+   * @var Drupal\Core\Database\Database
+   */

The description is missing an article. Also, the usual description for that property does not say it is a definition.

Hello @apaderno thanks for reviewing.

Done all the changes you have mentioned in the comment.
Please review and let me know if anything is missing.

+        '' => t('None(i.e.same window)'),
+        '_blank' => t('New window(_blank)'),
+        '_top' => t('Top window(_top)'),
+        '_self' => t('Same window(_self)'),
+        '_parent' => t('Parent window(_parent)'),

A space is missing before the opening parenthesis in the translated strings, in all those lines. Remove i.e. which is not necessary.

Updated the MR 8!

+  /**
+   * Database Service Object.
+   *
+   * @var \Drupal\Core\Database\Database
+   */
   public $db;

The comment on the previous commit was better, although an article was missing. This comment still misses an article, it uses Object when it is not necessary, and wrongly capitalizes the words that are not at the beginning of the phrase.

+        '' => t('None (i.e.same window)'),
+        '_blank' => t('New window (_blank)'),
+        '_top' => t('Top window (_top)'),
+        '_self' => t('Same window (_self)'),
+        '_parent' => t('Parent window (_parent)'),

I have already commented on these change on comment #5; on comment #8 also said the changes reported on comment #5 were not done. There is still a line that has not been correctly changed.

+  /**
+   * The Database service.
+   *
+   * @var \Drupal\Core\Database\Database
+   */
   public $db;

Words that are not at the beginning of a sentence are not written capitalized, if they are not acronyms nor proper nouns. Database is neither a proper noun nor an acronym.

@kkalashnikov are you planning to work on this again?

themodularlab → closed merge request !8

themodularlab → closed merge request !7

This has been merged into the dev branch. It will be included in the next release. Thanks for everyone's help.

Automatically closed - issue fixed for 2 weeks with no activity.