- Issue created by @SirClickALot
- 🇺🇸United States andrewjaykirkpatrick Oregon
I dealt with null being passed in json_decode by instead passing an empty string of single quotes if nothing else exists.
/modules/h5peditor/src/H5PEditor/H5PEditorDrupalStorage.php- $library->metadataSettings = json_decode($library->metadataSettings);
+ $library->metadataSettings = json_decode($library->metadataSettings ?? ''); - Status changed to Needs review
over 1 year ago 7:36am 24 March 2023 - 🇨🇦Canada ryanrobinson_wlu
+1, just found this same one as I've started doing PHP 8.1 testing.
- 🇨🇦Canada ryanrobinson_wlu
This looks like the fix has been included in the Drupal 10 dev release.
- Status changed to Fixed
about 1 year ago 7:20pm 1 November 2023 - 🇨🇦Canada shaundychko
Closing since fixed in 2.0.x
See https://git.drupalcode.org/project/h5p/-/blob/2.0.x/modules/h5peditor/sr...
and https://git.drupalcode.org/project/h5p/-/blob/2.0.x/modules/h5peditor/sr... Automatically closed - issue fixed for 2 weeks with no activity.