I can confirm I see this problem where Admin Toolbar 3.4.2 does not display proper CSS for itself while Performance -> Aggregate CSS & Javascript is checked, using the Bootstrap 8.x-3.29 theme. The Admin Toolbar works properly with Aggregate checked in the AT_Core 1.4.6 theme on the same multi-site server.
@NishaVaghela Is it possible that the CSS issue is caused by the Admin theme being used in Drupal 10 versus Drupal 9.5?
I dealt with null being passed in json_decode by instead passing an empty string of single quotes if nothing else exists.
/modules/h5peditor/src/H5PEditor/H5PEditorDrupalStorage.php
- $library->metadataSettings = json_decode($library->metadataSettings);
+ $library->metadataSettings = json_decode($library->metadataSettings ?? '');
Thanks for the .once code change.
I can confirm this works for me in Drupal 10.0.3 with PHP8.
I cannot edit new H5P interactive items due to a reliance on CKEditor3 as defined in /vendor/h5p/h5p-editor/h5peditor.class.php
'ckeditor/ckeditor.js'.
I also noted a small issue with json decoded values being null rather than empty (single quotes) in /src/Entity/H5PContent.php
- 'authors' => json_decode($this->get('authors')->value),
+ 'authors' => json_decode($this->get('authors')->value ?: ''),
- 'changes' => json_decode($this->get('changes')->value),
+ 'changes' => json_decode($this->get('changes')->value ?: ''),