Fix the issues reported by phpcs

Patch created

I am reviewing it

@Adil_Siddiqui patch applied successfully without errors, So moving to RTBC.

Keep in mind that the correct issue tag for this issues is Coding standards.

-    $entity_display_repository = \Drupal::service('entity_display.repository');
-

Since the test is using the following code, it is probably better to change the other lines, instead of removing that line.

    $entity_display_repository = \Drupal::service('entity_display.repository');

    $media_type = $this->createMediaType('soundcloud', ['id' => 'soundcloud']);

    $source_field = $media_type->getSource()->getSourceFieldDefinition($media_type);
    $this->assertSame('field_media_soundcloud', $source_field->getName());
    $this->assertSame('string', $source_field->getType());

    // Set form and view displays.
    \Drupal::service('entity_display.repository')->getFormDisplay('media', $media_type->id(), 'default')
      ->setComponent('field_media_soundcloud', [
        'type' => 'string_textfield',
      ])
      ->save();

    \Drupal::service('entity_display.repository')->getViewDisplay('media', $media_type->id(), 'full')
      ->setComponent('field_media_soundcloud', [
        'type' => 'soundcloud_embed',
      ])
      ->save();

The below variable is not required as it is just declared and not used anywhere hence it is removed in the patch.

-    $entity_display_repository = \Drupal::service('entity_display.repository');
-

Updated patch accordingly

Can we get the MR for quick review and merge.

Hi @kkalashnikov,

I applied your patch, it was applied smoothly. However I still encountered some issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.

➜  media_entity_soundcloud git:(3346907-fix-the-issues) curl https://www.drupal.org/files/issues/2023-03-14/3346907-8.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2950  100  2950    0     0   7039      0 --:--:-- --:--:-- --:--:--  7040
patching file src/Form/SoundcloudForm.php
patching file src/Plugin/Field/FieldFormatter/SoundcloudEmbedFormatter.php
patching file tests/src/Functional/SoundcloudEmbedFormatterTest.php
➜  media_entity_soundcloud git:(3346907-fix-the-issues) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml media_entity_soundcloud

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/media_entity_soundcloud/media_entity_soundcloud.module
---------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------------------
  8 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
 14 | ERROR | [x] Expected 1 blank line before function; 2 found
 48 | ERROR | [x] Case breaking statements must be followed by a single blank line
 51 | ERROR | [x] Expected 1 blank line after function; 0 found
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------

.

Thank you.

Hi,

Please review MR!15. Thank you.

MR !5 fixed all the PHP_CodeSniffer errors/warnings reported by GitLab CI.

Fixed!

Automatically closed - issue fixed for 2 weeks with no activity.