- Issue created by @promes
- Status changed to Needs review
over 1 year ago 9:56am 28 March 2023 - 🇳🇱Netherlands promes
Thanks, The patch seems to do the trick. The notice didn't appear yesterday.
I found an equal instruction at line 891. I don't know if this one should be corrected as well. - 🇮🇳India Adil_Siddiqui
Yes it needs to be corrected as well....Providing updated patch with changes at both the lines
- 🇳🇱Netherlands promes
I could't reply earlier: I have been in a Hospital. Patch 4 gives severe problems to the editor.
- 🇳🇱Netherlands promes
I got a message from the editor. Patch 2 is not correct as wel (after upgrade from 7.x-1.5). When selecting an entity the title appears in the selectfield, but not the id. The link doesn't work then. When manually entering the id after the title the link works. See attachment: last link.
- 🇨🇦Canada joseph.olstad
@PROMES, hope your hospital visit goes well!
meanwhile, if someone has a chance, please review the screenshot provided in comment #6
ideally this should work as it did before in 1.5
1.8 has significant performance enhancements, several important bug fixes and also compatibility for PHP 8.2.
Test coverage for this would be super, but if I can get full steps to reproduce and test this out myself I'd consider pushing this in without additional test coverage.
-
joseph.olstad →
committed 17acfa5e on 7.x-1.x authored by
Adil_Siddiqui →
Issue #3350557 by Adil_Siddiqui, joseph.olstad, PROMES: Undefined index...
-
joseph.olstad →
committed 17acfa5e on 7.x-1.x authored by
Adil_Siddiqui →
- Status changed to Fixed
over 1 year ago 4:11pm 14 April 2023 - Status changed to Fixed
over 1 year ago 4:44pm 28 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.