- Issue created by @gayatri chahar
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 7:08am 3 March 2023 - Status changed to Needs work
almost 2 years ago 8:13am 3 March 2023 - 🇮🇳India Adil_Siddiqui
Below t() call is still left in
FILE: /Users/adil.shiddiqui/drupal9/web/modules/contrib/augmentor/src/Plugin/Field/FieldWidget/AugmentorBaseWidget.php
306 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
Also other phpcs errors is also present:
FILE: /Users/adil.shiddiqui/drupal9/web/modules/contrib/augmentor/src/Plugin/Field/FieldWidget/AugmentorBaseWidget.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------------------
74 | WARNING | Unused variable $yolo.
87 | WARNING | File::load calls should be avoided in classes, use dependency injection instead
306 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
367 | WARNING | Unused variable $field_name.
------------------------------------------------------------------------------------------------------------------------------------------FILE: /Users/adil.shiddiqui/drupal9/web/modules/contrib/augmentor/src/Plugin/Field/FieldWidget/AugmentorWidget.php
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------
82 | WARNING | Unused variable $yolo.
94 | WARNING | File::load calls should be avoided in classes, use dependency injection instead
324 | WARNING | Unused variable $field_name.
------------------------------------------------------------------------------------------------------------------FILE: /Users/adil.shiddiqui/drupal9/web/modules/contrib/augmentor/src/Plugin/Field/FieldFormatter/AugmentorFormatter.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
64 | WARNING | Unused variable $debug.
65 | WARNING | Unused variable $entity.
------------------------------------------------------------------------------------------------------------------------ - Status changed to Needs review
almost 2 years ago 10:04am 3 March 2023 - Status changed to RTBC
almost 2 years ago 6:49am 9 March 2023 The attached patch also accommodated 📌 Fix typo mistake in AugmentorInterface.php Closed: duplicate
-
naveenvalecha →
committed 97b8d564 on 1.0.x
Issue #3345662 by naveenvalecha, gayatri chahar, Adil_Siddiqui,...
-
naveenvalecha →
committed 97b8d564 on 1.0.x
- Status changed to Fixed
almost 2 years ago 6:52am 9 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.