Coding Standard issues

Hi @urvashi_vora,

Applied the patch you provided, it was applied successfully, however, there are 2 errors remaining. Please see below:

➜  edit_and_save git:(8.x-1.x) curl https://www.drupal.org/files/issues/2022-07-16/coding-standards-fixed-2886679-7.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1157  100  1157    0     0   4630      0 --:--:-- --:--:-- --:--:--  4861
patching file README.txt
patching file edit_and_save.info.yml
patching file src/Repository/EditAndSaveRepository.php
➜  edit_and_save git:(8.x-1.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig edit_and_save

FILE: ...v9/web/modules/contrib/edit_and_save/src/Form/EditAndSaveConfigureForm.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
   8 | ERROR | [x] Use statements should be sorted alphabetically. The first
     |       |     wrong one is Drupal\Core\Form\ConfigFormBase.
 153 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 187ms; Memory: 10MB

And as expected the MR!1 also have errors remaining, so moving this to Needs Work.

Kindly check

Thanks,
Jake

I will remove the remaining issues.

hi @a.aaronjake,

Removed the remaining coding standard errors and now you can review.

Thanks and regards
Akshay Dalvi

Hi @akshaydalvi212,

Applied the latest commits on MR!1, it was applied successfully and confirmed no remaining issue reported.

➜  edit_and_save git:(8.x-1.x) curl https://git.drupalcode.org/project/edit_and_save/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2624    0  2624    0     0   7964      0 --:--:-- --:--:-- --:--:--  8251
patching file README.txt
patching file edit_and_save.info.yml
patching file src/Form/EditAndSaveConfigureForm.php
patching file src/Repository/EditAndSaveRepository.php
➜  edit_and_save git:(8.x-1.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig edit_and_save
➜  contrib git:(master) ✗

Will now move this to RTBC

Thanks,
Jake

Thanks, merged