Contrib.social

Fix the warnings/errors reported by PHP_CodeSniffer

Open on Drupal.org ā†’
Created on 12 July 2023, over 1 year ago
Updated 23 August 2024, 7 months ago

Problem/Motivation

FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/onelogin_integration.module
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 20 ERRORS AND 2 WARNINGS AFFECTING 20 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] Missing file doc comment
  22 | ERROR   | [ ] The $_COOKIE super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->cookies instead
  23 | ERROR   | [ ] The $_COOKIE super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->cookies->get('Drupal_visitor_onelogin_integration_login') instead
  64 | ERROR   | [ ] All functions defined in a module file must be prefixed with the module's name, found "user_login_form_alter" but expected
     |         |     "onelogin_integration_user_login_form_alter"
  75 | WARNING | [x] A comma should follow the last multiline array item. Found: TRUE
 104 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 108 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 125 | ERROR   | [x] Expected "int" but found "integer" for parameter type
 127 | ERROR   | [x] Expected 1 space after asterisk; 2 found
 127 | ERROR   | [x] Expected "bool" but found "boolean" for function return type
 127 | ERROR   | [ ] Description for the @return value is missing
 129 | ERROR   | [ ] All functions defined in a module file must be prefixed with the module's name, found "user_use_onelogin" but expected
     |         |     "onelogin_integration_user_use_onelogin"
 138 | ERROR   | [x] Expected 1 space(s) after cast statement; 0 found
 146 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 149 | ERROR   | [ ] All functions defined in a module file must be prefixed with the module's name, found "user_remove_onelogin" but expected
     |         |     "onelogin_integration_user_remove_onelogin"
 166 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 170 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 173 | ERROR   | [ ] All functions defined in a module file must be prefixed with the module's name, found "user_drupal_form_alter" but expected
     |         |     "onelogin_integration_user_drupal_form_alter"
 174 | ERROR   | [ ] The $_COOKIE super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->cookies instead
 175 | ERROR   | [ ] The $_COOKIE super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->cookies->get('Drupal_visitor_onelogin_integration_login') instead
 185 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 186 | WARNING | [x] A comma should follow the last multiline array item. Found: 7
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/src/Form/OneLoginIntegrationAdminForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 76 WARNINGS AFFECTING 76 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  52 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  56 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  63 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  67 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  72 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  74 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  80 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  91 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  93 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  99 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 101 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 107 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 109 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 115 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 121 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 123 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 138 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 142 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 147 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 149 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 155 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 157 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 163 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 166 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 172 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 176 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 181 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 183 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 189 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 196 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 203 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 205 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 212 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 216 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 242 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 246 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 251 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 253 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 259 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 261 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 267 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 269 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 275 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 277 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 283 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 285 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 292 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 297 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 299 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 305 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 307 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 313 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 315 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 321 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 323 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 330 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 334 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 339 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 341 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 347 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 349 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 355 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 357 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 363 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 365 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 371 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 373 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 379 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 381 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 387 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 389 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 395 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 397 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 403 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 405 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/src/Controller/OneLoginIntegrationController.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AND 1 WARNING AFFECTING 14 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
 133 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->query->get('destination') instead
 134 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->query->get('destination') instead
 136 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->query->get('returnTo') instead
 137 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->query->get('returnTo') instead
 140 | WARNING | [x] 'TODO: efficienter maken.' should match the format '@todo Fix problem X here.'
 175 | ERROR   | [ ] The $_POST super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->request->get('RelayState') instead
 176 | ERROR   | [ ] The $_POST super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->request->get('RelayState') instead
 178 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->query->get('returnTo') instead
 179 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->query->get('returnTo') instead
 181 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->query->get('destination') instead
 182 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->query->get('destination') instead
 195 | ERROR   | [ ] The $_POST super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->request->get('SAMLResponse') instead
 195 | ERROR   | [ ] The $_POST super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->request->get('SAMLResponse') instead
 260 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->query->get('destination') instead
 260 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->query->get('destination') instead
 261 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use
     |         |     $stack->getCurrentRequest()->query->get('destination') instead
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/src/AuthenticationService.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------
  32 | WARNING | Line exceeds 80 characters; contains 82 characters
 177 | WARNING | User::load calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------


FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/onelogin_integration.routing.yml
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------
 16 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 23 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 30 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 37 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 44 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 51 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
------------------------------------------------------------------------------------------------------------------


FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/onelogin_integration.info.yml
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 8 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------


FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/README.md
---------------------------------------------------------------------------
FOUND 1 ERROR AND 26 WARNINGS AFFECTING 27 LINES
---------------------------------------------------------------------------
  31 | WARNING | [ ] Line exceeds 80 characters; contains 185 characters
  35 | WARNING | [ ] Line exceeds 80 characters; contains 140 characters
  39 | WARNING | [ ] Line exceeds 80 characters; contains 140 characters
  44 | WARNING | [ ] Line exceeds 80 characters; contains 153 characters
  45 | WARNING | [ ] Line exceeds 80 characters; contains 150 characters
  51 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters
  53 | WARNING | [ ] Line exceeds 80 characters; contains 133 characters
  54 | WARNING | [ ] Line exceeds 80 characters; contains 468 characters
  60 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
  61 | WARNING | [ ] Line exceeds 80 characters; contains 130 characters
  62 | WARNING | [ ] Line exceeds 80 characters; contains 505 characters
  63 | WARNING | [ ] Line exceeds 80 characters; contains 241 characters
  67 | WARNING | [ ] Line exceeds 80 characters; contains 148 characters
  68 | WARNING | [ ] Line exceeds 80 characters; contains 235 characters
  69 | WARNING | [ ] Line exceeds 80 characters; contains 169 characters
  70 | WARNING | [ ] Line exceeds 80 characters; contains 221 characters
  71 | WARNING | [ ] Line exceeds 80 characters; contains 342 characters
  72 | WARNING | [ ] Line exceeds 80 characters; contains 227 characters
 109 | WARNING | [ ] Line exceeds 80 characters; contains 193 characters
 113 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 117 | WARNING | [ ] Line exceeds 80 characters; contains 184 characters
 121 | WARNING | [ ] Line exceeds 80 characters; contains 195 characters
 133 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
 140 | WARNING | [ ] Line exceeds 80 characters; contains 167 characters
 146 | WARNING | [ ] Line exceeds 80 characters; contains 109 characters
 152 | WARNING | [ ] Line exceeds 80 characters; contains 144 characters
 161 | ERROR   | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------


FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/onelogin_integration.install
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
 10 | ERROR | [ ] Unnecessarily gendered language in a comment
 64 | ERROR | [ ] The array declaration extends to column 336 (the limit is 80). The array content should be split up over multiple lines
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------

Time: 209ms; Memory: 12MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig onelogin_integration

FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/onelogin_integration.module
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
-----------------------------------------------------------------------------------------------------------------------------------
74 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "user_login_form_alter" but
| | expected "onelogin_integration_user_login_form_alter"
114 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
138 | ERROR | Description for the @return value is missing
140 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "user_use_onelogin" but
| | expected "onelogin_integration_user_use_onelogin"
160 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "user_remove_onelogin" but
| | expected "onelogin_integration_user_remove_onelogin"
177 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
184 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "user_drupal_form_alter" but
| | expected "onelogin_integration_user_drupal_form_alter"
-----------------------------------------------------------------------------------------------------------------------------------

FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/src/AuthenticationService.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
32 | WARNING | Line exceeds 80 characters; contains 82 characters
-----------------------------------------------------------------------------------------------

FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/onelogin_integration.routing.yml
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------
16 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
23 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
30 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
37 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
44 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
51 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
------------------------------------------------------------------------------------------------------------------

FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/README.md
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 26 WARNINGS AFFECTING 26 LINES
---------------------------------------------------------------------------
31 | WARNING | Line exceeds 80 characters; contains 185 characters
35 | WARNING | Line exceeds 80 characters; contains 140 characters
39 | WARNING | Line exceeds 80 characters; contains 140 characters
44 | WARNING | Line exceeds 80 characters; contains 153 characters
45 | WARNING | Line exceeds 80 characters; contains 150 characters
51 | WARNING | Line exceeds 80 characters; contains 108 characters
53 | WARNING | Line exceeds 80 characters; contains 133 characters
54 | WARNING | Line exceeds 80 characters; contains 468 characters
60 | WARNING | Line exceeds 80 characters; contains 93 characters
61 | WARNING | Line exceeds 80 characters; contains 130 characters
62 | WARNING | Line exceeds 80 characters; contains 505 characters
63 | WARNING | Line exceeds 80 characters; contains 241 characters
67 | WARNING | Line exceeds 80 characters; contains 148 characters
68 | WARNING | Line exceeds 80 characters; contains 235 characters
69 | WARNING | Line exceeds 80 characters; contains 169 characters
70 | WARNING | Line exceeds 80 characters; contains 221 characters
71 | WARNING | Line exceeds 80 characters; contains 342 characters
72 | WARNING | Line exceeds 80 characters; contains 227 characters
109 | WARNING | Line exceeds 80 characters; contains 193 characters
113 | WARNING | Line exceeds 80 characters; contains 83 characters
117 | WARNING | Line exceeds 80 characters; contains 184 characters
121 | WARNING | Line exceeds 80 characters; contains 195 characters
133 | WARNING | Line exceeds 80 characters; contains 100 characters
140 | WARNING | Line exceeds 80 characters; contains 167 characters
146 | WARNING | Line exceeds 80 characters; contains 109 characters
152 | WARNING | Line exceeds 80 characters; contains 144 characters
---------------------------------------------------------------------------

FILE: /home/lenovo/d7to9/web/modules/contrib/onelogin_integration/onelogin_integration.install
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
15 | ERROR | Unnecessarily gendered language in a comment
----------------------------------------------------------------------------------------------

Time: 207ms; Memory: 12MB

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

šŸ“Œ Task
Status

Needs work

Version

2.0

Component

Code

Created by

šŸ‡®šŸ‡³India roshni27

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @roshni27
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India roshni27

    Some issues which are better know to maintainer are pending, for reading purpose character limits issues remain and all remaining issues solve by me. Please review the patch.

  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India roshni27

    please review the patch

  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India roshni27
  • Status changed to Needs work 7 months ago
  • Comment 7 months ago ā†’
    šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @roshni27,

    I applied patch #2, it was applied smoothly and fixed most of the phpcs issues.

    These are the remaining issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

    āžœ  onelogin_integration git:(8.x-2.x) curl https://www.drupal.org/files/issues/2023-07-12/fixes-error-phpcs-3374028-2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 44002  100 44002    0     0  63619      0 --:--:-- --:--:-- --:--:-- 63678
patching file README.md
patching file onelogin_integration.info.yml
patching file onelogin_integration.install
patching file onelogin_integration.module
patching file src/AuthenticationService.php
patching file src/Controller/OneLoginIntegrationController.php
patching file src/Form/OneLoginIntegrationAdminForm.php
āžœ  onelogin_integration git:(8.x-2.x) āœ— ..
āžœ  contrib phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js onelogin_integration

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/onelogin_integration/onelogin_integration.routing.yml
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------------------
 16 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 23 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 30 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 37 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 44 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
 51 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
--------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/onelogin_integration/onelogin_integration.install
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 15 | ERROR | Unnecessarily gendered language in a comment
----------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/onelogin_integration/README.md
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 26 WARNINGS AFFECTING 26 LINES
---------------------------------------------------------------------------------------------------
  31 | WARNING | Line exceeds 80 characters; contains 185 characters
  35 | WARNING | Line exceeds 80 characters; contains 140 characters
  39 | WARNING | Line exceeds 80 characters; contains 140 characters
  44 | WARNING | Line exceeds 80 characters; contains 153 characters
  45 | WARNING | Line exceeds 80 characters; contains 150 characters
  51 | WARNING | Line exceeds 80 characters; contains 108 characters
  53 | WARNING | Line exceeds 80 characters; contains 133 characters
  54 | WARNING | Line exceeds 80 characters; contains 468 characters
  60 | WARNING | Line exceeds 80 characters; contains 93 characters
  61 | WARNING | Line exceeds 80 characters; contains 130 characters
  62 | WARNING | Line exceeds 80 characters; contains 505 characters
  63 | WARNING | Line exceeds 80 characters; contains 241 characters
  67 | WARNING | Line exceeds 80 characters; contains 148 characters
  68 | WARNING | Line exceeds 80 characters; contains 235 characters
  69 | WARNING | Line exceeds 80 characters; contains 169 characters
  70 | WARNING | Line exceeds 80 characters; contains 221 characters
  71 | WARNING | Line exceeds 80 characters; contains 342 characters
  72 | WARNING | Line exceeds 80 characters; contains 227 characters
 109 | WARNING | Line exceeds 80 characters; contains 193 characters
 113 | WARNING | Line exceeds 80 characters; contains 83 characters
 117 | WARNING | Line exceeds 80 characters; contains 184 characters
 121 | WARNING | Line exceeds 80 characters; contains 195 characters
 133 | WARNING | Line exceeds 80 characters; contains 100 characters
 140 | WARNING | Line exceeds 80 characters; contains 167 characters
 146 | WARNING | Line exceeds 80 characters; contains 109 characters
 152 | WARNING | Line exceeds 80 characters; contains 144 characters
---------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/onelogin_integration/onelogin_integration.module
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  74 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "user_login_form_alter" but expected "onelogin_integration_user_login_form_alter"
 114 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 138 | ERROR | Description for the @return value is missing
 140 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "user_use_onelogin" but expected "onelogin_integration_user_use_onelogin"
 160 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "user_remove_onelogin" but expected "onelogin_integration_user_remove_onelogin"
 177 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 184 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "user_drupal_form_alter" but expected "onelogin_integration_user_drupal_form_alter"
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/onelogin_integration/src/AuthenticationService.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------
 32 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 88 | ERROR   | [x] Multi-line function declarations must have a trailing comma after the last parameter
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/onelogin_integration/src/Controller/OneLoginIntegrationController.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 100 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/onelogin_integration/src/UserService.php
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 55 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------

Time: 447ms; Memory: 12MB

āžœ  contrib

    Thank you.

  • First commit to issue fork.
  • Assigned to akshaydalvi212
  • Comment 7 months ago ā†’
    šŸ‡®šŸ‡³India akshaydalvi212

    I will work on this issue and resolve all the errors.

  • Merge request !13#3374028 - Removed the standards errors. ā†’ (Open) created by akshaydalvi212
  • Issue was unassigned.
  • Comment 7 months ago ā†’
    šŸ‡®šŸ‡³India akshaydalvi212
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024