Deprecation error messages about creation of dynamic properties in EdgeModules

Open on Drupal.org →

Created on 13 August 2024, 4 months ago

Problem/Motivation

Seeing multiple error messages like Deprecated function: Creation of dynamic property Drupal\fastly\EdgeModules::$configFactory is deprecated in Drupal\fastly\EdgeModules->__construct() when visiting the Fastly Edge Modules config page.

Dynamic properties are deprecated as of php 8.2: https://php.watch/versions/8.2/dynamic-properties-deprecated

Steps to reproduce

Make sure you're on php version 8.2 (or later).
Install / update Drupal core to version 10.3.
Install / update Fastly module version 4.0.3.
Go to Fastly Edge Modules config page at /admin/config/services/fastly/edge-modules.

Proposed resolution

Declare all properties before using them.

Remaining tasks

Update Drupal\fastly\EdgeModules with missing property declarations.

User interface changes

-

API changes

-

Data model changes

-

🐛 Bug report

Status

Needs review

Version

4.0

Component

Code

Created by

🇫🇮Finland tohesi

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!23Deprecation error messages about creation of dynamic properties in EdgeModules
Open
🇮🇳India akshaydalvi212
updated 4 months ago
!22Deprecation error messages about creation of dynamic properties in EdgeModules
Open
🇫🇮Finland tohesi
updated 4 months ago

Comments & Activities

Issue created by @tohesi
Assigned to akshaydalvi212
Comment 4 months ago →
🇮🇳India akshaydalvi212
I will work on this issue.
Merge request !22#3467777: Declaring missing properties to avoid error messages about creation... → (Open) created by tohesi
Comment 4 months ago →
🇫🇮Finland tohesi
Sorry @akshaydalvi212 , didn't notice you picked this up so fast (and forgot to assign this to myself). I already created a quick PR to fix the deprecation error messages.
Merge request !23Issue #3360742 by gilles_webstanz: Version 4 of the module is compatible with... → (Open) created by akshaydalvi212
Comment 4 months ago →
🇮🇳India akshaydalvi212
Hey @tohesi,

Sorry, I also tried removing the deprecation errors I encountered on my local with the new branch PR.

Adding the image as an attachment when I encountered the error on the configuration setting page of Fastly.
Issue was unassigned.
Status changed to Needs review 4 months ago1:01pm 13 August 2024
Comment 4 months ago →
🇮🇳India akshaydalvi212

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024