Fix the issues reported by phpcs

I have Created a patch to fix this issue.

Hi Shanu Chouhan

I cloned the module and applied your patch #2 and confirmed that the phpcs --standard=Drupal issues were fixed.

Please look at the screenshots attached for your reference.

Thank you.

Hello @Shanu Chouhan and @clarkssquared.

Would you care to open an issue fork and merge request for your PR. It'll be easier to add comments there. Since there are a few issues with the patch. For example:

+  /**
+   * Service description.
+   */

Well it is not service description but a string with a log file path.

Then next docblock is also wrong, since it exists already, just the commented line has to be removed.

I will updated the code so as to resolve the reported errors and raise the MR.

Resolved all the Errors and raised the MR.
kindly review the MR.

Not good. See my MR review: https://git.drupalcode.org/project/hook_profiler/-/merge_requests/1#note...

I will work on the comments added to the MR and update the MR accordingly.

Made the suggested changes in the MR.
kindly review the MR.

+  /**
+   * The log path string.
+   */
   protected string $logPath;

The @var line must still be present, as per Drupal coding standards.

Also, the report shows warnings/errors for a single file, while the MR changes two files. Either the report is not complete (and must be edited to show all the warnings/errors to fix) or the MR is changed to fix only what reported in the issue summary.

Patch updated.
Please review.

@imustakim
1. Why did you not add a commit to the MR that's open already?
2. Why are changing README.txt? I don't see any code style issue there?
3. @var parameter needs a type not a var name

 /**
- * Service description.
+ * The module handler service class.
  */
 class HookProfilerModuleHandler extends ModuleHandler {

Since that class is extending ModuleHandler, it cannot simply be described as The module handler. because that will not make clear the difference between that class and its parent class.

+  /**
+   * The log file path.
+   *
+   * @var logPath
+   */
   protected string $logPath;

As the previous comment said, logPath is not a PHP type, nor a class name, and it cannot be used with @var.

MR updated.
Please review.

Let's end this torture. Merged and fixed.

Automatically closed - issue fixed for 2 weeks with no activity.