- Issue created by @alyaj2a
- Assigned to alyaj2a
- Status changed to Needs review
3 months ago 5:58pm 6 September 2024 - Issue was unassigned.
- Status changed to Needs work
3 months ago 7:26am 12 September 2024 - šµšPhilippines cleavinjosh
Hi @alyaj2a,
Thank you for providing an MR. I applied MR!15, it was applied smoothly and fixed most of the phpcs issues.
These is the remaining issue after I ran
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig
:ā date_filter git:(1.0.x) curl https://git.drupalcode.org/project/date_filter/-/merge_requests/15.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3070 0 3070 0 0 6454 0 --:--:-- --:--:-- --:--:-- 6449 patching file Readme.md patching file src/Plugin/views/filter/DateBase.php patching file tests/date_filter_test/date_filter_test.info.yml patching file tests/src/Functional/DateFilterTest.php patching file tests/src/Kernel/DateFilterTest.php ā date_filter git:(1.0.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml date_filter FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/date_filter/date_filter.module ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------ 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\date_filter\Plugin\views\filter\DateTime. ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ Time: 268ms; Memory: 10MB ā contrib git:(main) ā
Thank you.
- Assigned to akshaydalvi212
- Issue was unassigned.
- Status changed to Needs review
3 months ago 12:14pm 12 September 2024 - š®š³India akshaydalvi212
hi @cleavinjosh,
Resolved the last issue, you can review the MR now.
Thanks and regards. - Status changed to RTBC
3 months ago 12:35pm 12 September 2024 - šµšPhilippines cleavinjosh
Hi @akshaydalvi212,
Thank you for providing updating the MR. I applied MR!15, it was applied smoothly and fixed all the phpcs issues.
ā date_filter git:(1.0.x) curl https://git.drupalcode.org/project/date_filter/-/merge_requests/15.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3622 0 3622 0 0 7786 0 --:--:-- --:--:-- --:--:-- 7806 patching file Readme.md patching file date_filter.module patching file src/Plugin/views/filter/DateBase.php patching file tests/date_filter_test/date_filter_test.info.yml patching file tests/src/Functional/DateFilterTest.php patching file tests/src/Kernel/DateFilterTest.php ā date_filter git:(1.0.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml date_filter ā contrib git:(main) ā
Thank you.
- First commit to issue fork.
-
graber ā
committed 68da16ba on 1.0.x authored by
alyaj2a ā
Issue #3472618: Coding Standard issues
-
graber ā
committed 68da16ba on 1.0.x authored by
alyaj2a ā
- Status changed to Fixed
3 months ago 12:38pm 12 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.