Fix eslint/phpcs/phpstan issues

Fixed a few remaining issues but some issues remain
The remaining issues are:

FILE: /eck.module
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------
 27 | WARNING | Global constants should not be used, move it to a class or interface
 32 | WARNING | Global constants should not be used, move it to a class or interface
-------------------------------------------------------------------------------------

FILE: src/Form/EntityType/EckEntityTypeFormBase.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------
  93 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 157 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------

FILE: /src/Form/EntityBundle/EckEntityBundleForm.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------
 110 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 215 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 218 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 281 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------

FILE: /README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 84 characters
 4 | WARNING | Line exceeds 80 characters; contains 85 characters
 7 | WARNING | Line exceeds 80 characters; contains 85 characters
 8 | WARNING | Line exceeds 80 characters; contains 85 characters
----------------------------------------------------------------------

FILE: /tests/src/Kernel/EckEntityTest.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 42 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /tests/src/Unit/UnitTestBase.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------
 51 | WARNING | Unused variable $methods.
 81 | WARNING | Unused private method getEntityManagerMock()
----------------------------------------------------------------------------

I have used the following command for checking the Drupal-PHP-CBF/CS issues

vendor/binphpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml ./

Please review

Resolved all the issues only the below issues remain.
you can review the updated MR.

FILE: /home/admin1/task/drupal9-os/web/modules/contrib/eck-3422393/tests/src/Unit/UnitTestBase.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------
51 | WARNING | Unused variable $methods.
81 | WARNING | Unused private method getEntityManagerMock()
--------------------------------------------------------------------------------------------------

FILE: /home/admin1/task/drupal9-os/web/modules/contrib/eck-3422393/eck.module
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------
27 | WARNING | Global constants should not be used, move it to a class or interface
32 | WARNING | Global constants should not be used, move it to a class or interface
-------------------------------------------------------------------------------------

This issue is not just about phpcs issue. As long as eslint/phpcs/phpstan issues are present and the pipeline isn't green, this isn't ready.

Working on it

Fixed phpcs and phpstan error.

All eslint/phpcs/phpstan issues are fixed now. Pipeline is green for eslint/phpcs/phpstan.

Looks mostly okay. Adding final to classes/methods is not necessary though, nor is returning self instead of static in create methods. This makes it so these classes/methods can't be extended anymore.

@DieterHolvoet I have made the changes that are told by you. Have a look.

There are still classes and methods made final in the MR. Same with self/static. PHPStan also reports a syntax error.

@dieterholvoet I replaced all final methods and self/static keyword, pipeline for PHPStan, eslint and phpcs is green now.

dieterholvoet → changed the visibility of the branch 2.x to hidden.

dieterholvoet → credited dj1999 → .

Automatically closed - issue fixed for 2 weeks with no activity.