- Issue created by @dieterholvoet
- Assigned to thakurnishant_06
- Issue was unassigned.
- First commit to issue fork.
- 🇮🇳India adwivedi008
Fixed a few remaining issues but some issues remain
The remaining issues are:FILE: /eck.module ------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------- 27 | WARNING | Global constants should not be used, move it to a class or interface 32 | WARNING | Global constants should not be used, move it to a class or interface ------------------------------------------------------------------------------------- FILE: src/Form/EntityType/EckEntityTypeFormBase.php ---------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------- 93 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 157 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------- FILE: /src/Form/EntityBundle/EckEntityBundleForm.php ---------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------- 110 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 215 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 218 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 281 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------- FILE: /README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 84 characters 4 | WARNING | Line exceeds 80 characters; contains 85 characters 7 | WARNING | Line exceeds 80 characters; contains 85 characters 8 | WARNING | Line exceeds 80 characters; contains 85 characters ---------------------------------------------------------------------- FILE: /tests/src/Kernel/EckEntityTest.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 42 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------- FILE: /tests/src/Unit/UnitTestBase.php ---------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------------- 51 | WARNING | Unused variable $methods. 81 | WARNING | Unused private method getEntityManagerMock() ----------------------------------------------------------------------------
I have used the following command for checking the Drupal-PHP-CBF/CS issues
vendor/binphpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml ./
Please review
- First commit to issue fork.
- Status changed to Needs review
8 months ago 6:31pm 1 April 2024 - 🇮🇳India akshaydalvi212
Resolved all the issues only the below issues remain.
you can review the updated MR.FILE: /home/admin1/task/drupal9-os/web/modules/contrib/eck-3422393/tests/src/Unit/UnitTestBase.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------
51 | WARNING | Unused variable $methods.
81 | WARNING | Unused private method getEntityManagerMock()
--------------------------------------------------------------------------------------------------FILE: /home/admin1/task/drupal9-os/web/modules/contrib/eck-3422393/eck.module
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------
27 | WARNING | Global constants should not be used, move it to a class or interface
32 | WARNING | Global constants should not be used, move it to a class or interface
------------------------------------------------------------------------------------- - Status changed to Needs work
8 months ago 11:52am 3 April 2024 - 🇧🇪Belgium dieterholvoet Brussels
This issue is not just about phpcs issue. As long as eslint/phpcs/phpstan issues are present and the pipeline isn't green, this isn't ready.
- First commit to issue fork.