t() should not be used in test classes

keshav.k → made their first commit to this issue’s fork.

Here is the Patch for this issue.

The last submitted patch, 3: t()_calls_should_be_avoided-3359562-2.patch, failed testing. View results →

I will review the patch.

hey @yashmalviya,
Thank you for the patch but while applying the patch getting errors as shown in the image.

will make changes the also raise the MR which will remove the reporting errors.

Updated the code and raised the MR for removing the reported errors.
Kindly review the MR.

Hello @akshaydalvi212
I have updated the changes. Please review

The last submitted patch, 10: t()_calls_should_be_avoided-3359562-10.patch.patch, failed testing. View results →

bharath-kondeti → made their first commit to this issue’s fork.

Hi, I tried to replicate the issue but didn't get it while testing Drupal 10.09 with PHP 8.1. To address the issue mentioned, it would be helpful if you could provide more specific details about the problem you encountered. Please provide the steps to reproduce the issue, any error messages or warnings you received, and any relevant configurations or code snippets.

FILE: /var/www/html/modules/real/realname/tests/src/Functional/RealnameBasicTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------

 72 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 83 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 90 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/modules/real/realname/src/Controller/RealnameAutocompleteController.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 24 | ERROR | The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------

Time: 223ms; Memory: 10MB

Getting the following issues on running phpcs with standard Drupal and DrupalPractice. Attaching patch for fixes. Please review.

Since the purpose of this issue is avoiding t() calls in classes, the MR should focus on that. Differently, this issue would become a Fix the issues reported by phpcs issue.

Also, the issue summary, instead of quoting part of the PHP_CodeSniffer report, should say which files must be changed.
Let's focus on t() calls, instead of adding also the changes to be done on the .info.yml file.

See the ConfigEntityTest class, which contains the following code.

$this->assertSession()->pageTextContains('0 configuration has been created.');

It does not use t() nor $this->t().

Removed t() function. Sharing new patch. Please review.

Please review Patch.

Both t_calls_should_be_avoided-3359562-12.patch and 3359562-22.patch apply cleanly and remove the 3 occurrences of the t() function.

@apaderno I have reverted the other changes. Now we can go with the MR.
Thank you.