phpcs: 12 failed, 12 total tests

Hi @the_g_bomb,

I have verified the phpcs issues on my terminal, the commits you made on MR!4 can be applied successfully and after applying it, confirmed most issues were fixed, however, one error still persisted. Please see below:

 gnu_terry_pratchett git:(main) ✗ curl https://git.drupalcode.org/project/gnu_terry_pratchett/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2951    0  2951    0     0   8990      0 --:--:-- --:--:-- --:--:--  9338
patching file gnu_terry_pratchett.module
patching file gnu_terry_pratchett.services.yml
patching file src/EventSubscriber/XClacksSubscriber.php
patching file src/Tests/Headers/XClacksTest.php
➜  gnu_terry_pratchett git:(main) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig gnu_terry_pratchett

FILE: .../web/modules/contrib/gnu_terry_pratchett/src/Tests/Headers/XClacksTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 32 | ERROR | Public method name "XClacksTest::testXClacksHeaders" is not in
    |       | lowerCamel format
--------------------------------------------------------------------------------

Time: 135ms; Memory: 10MB

Kindly check

Thanks,
Jake

Working on it.

Added 1 commit to the MR, please check.

Hi sayan_k_dutta,

Confirmed the commit you added to the MR fixed the reported issue.

gnu_terry_pratchett git:(main) ✗ curl https://git.drupalcode.org/project/gnu_terry_pratchett/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3290    0  3290    0     0   9154      0 --:--:-- --:--:-- --:--:--  9426
patching file gnu_terry_pratchett.module
patching file gnu_terry_pratchett.services.yml
patching file src/EventSubscriber/XClacksSubscriber.php
patching file src/Tests/Headers/XClacksTest.php
➜  gnu_terry_pratchett git:(main) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig gnu_terry_pratchett
➜  contrib git:(main) ✗

Will now move this to RTBC

Thanks,
Jake

Hi @everyone,

I have also enabled and ran the phpcs job confirmed passed.

Thanks,
Jake