Created on 20 June 2017, over 7 years ago
Updated 22 August 2024, 4 months ago

Hi all. Module has some coding standards erros in the 7.x-2.x-dev branch. Let's fix all. Here is some fix.

šŸ› Bug report
Status

Needs work

Version

2.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Hi @henriquebauer,

    Applied the patch you provided, it was applied successfully, however, there are a lot, like a LOT of errors reported. Please see below:

    āžœ  rpx git:(7.x-2.x) curl https://www.drupal.org/files/issues/2018-06-05/coding_standards-2887732-4.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  115k  100  115k    0     0   345k      0 --:--:-- --:--:-- --:--:--  360k
    patching file rpx.api.php
    patching file rpx_core.info
    patching file rpx_core.install
    patching file rpx_core.module
    patching file rpx_core.pages.inc
    patching file rpx_core.webapi.inc
    patching file rpx_rules.info
    patching file rpx_rules.rules.inc
    patching file rpx_ui.admin.inc
    patching file rpx_ui.css
    patching file rpx_ui.info
    patching file rpx_ui.install
    patching file rpx_ui.module
    patching file rpx_ui.pages.inc
    patching file rpx_ui.paths.inc
    patching file rpx_ui.tokens.inc
    patching file rpx_widgets.css
    patching file rpx_widgets.info
    patching file rpx_widgets.module
    patching file views/rpx_ui.views.inc
    patching file views/rpx_ui_handler_field_delete_link.inc
    patching file views/rpx_ui_handler_field_provider_icon.inc
    patching file views/rpx_ui_handler_field_share.inc
    patching file views/rpx_ui_handler_filter_provider_name.inc
    patching file views/rpx_ui_handler_filter_provider_title.inc
    āžœ  rpx git:(7.x-2.x) āœ— ..
    āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig rpx
    
    FILE: ...Interns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.module
    --------------------------------------------------------------------------------
    FOUND 7 ERRORS AND 8 WARNINGS AFFECTING 15 LINES
    --------------------------------------------------------------------------------
      10 | WARNING | All constants defined by a module must be prefixed with the
         |         | module's name, expected "RPX_UI_RPX_ACCOUNTS_STRING" but found
         |         | "RPX_ACCOUNTS_STRING"
     155 | ERROR   | All functions defined in a module file must be prefixed with
         |         | the module's name, found "_rpx_own_identities_access" but
         |         | expected "rpx_ui__rpx_own_identities_access"
     192 | WARNING | All variables defined by your module must be prefixed with
         |         | your module's name to avoid name collisions with others.
         |         | Expected start with "rpx_ui" but found
         |         | "rpx_attach_share_link_to_teasers_"
     198 | WARNING | All variables defined by your module must be prefixed with
         |         | your module's name to avoid name collisions with others.
         |         | Expected start with "rpx_ui" but found
         |         | "rpx_attach_share_link_to_nodelink_"
     204 | WARNING | All variables defined by your module must be prefixed with
         |         | your module's name to avoid name collisions with others.
         |         | Expected start with "rpx_ui" but found
         |         | "rpx_attach_share_link_to_nodecont_"
     211 | WARNING | All variables defined by your module must be prefixed with
         |         | your module's name to avoid name collisions with others.
         |         | Expected start with "rpx_ui" but found
         |         | "rpx_attach_share_link_to_nodecont_weight_"
     229 | WARNING | All variables defined by your module must be prefixed with
         |         | your module's name to avoid name collisions with others.
         |         | Expected start with "rpx_ui" but found
         |         | "rpx_comment_popup_social_at_once_"
     235 | WARNING | All variables defined by your module must be prefixed with
         |         | your module's name to avoid name collisions with others.
         |         | Expected start with "rpx_ui" but found
         |         | "rpx_attach_share_link_to_comments_"
     249 | ERROR   | All functions defined in a module file must be prefixed with
         |         | the module's name, found "rpx_get_enabled_provider_array" but
         |         | expected "rpx_ui_rpx_get_enabled_provider_array"
     273 | ERROR   | All functions defined in a module file must be prefixed with
         |         | the module's name, found "_rpx_drupal_field_catalog" but
         |         | expected "rpx_ui__rpx_drupal_field_catalog"
     345 | ERROR   | All functions defined in a module file must be prefixed with
         |         | the module's name, found "_rpx_drupal_field_options" but
         |         | expected "rpx_ui__rpx_drupal_field_options"
     366 | ERROR   | All functions defined in a module file must be prefixed with
         |         | the module's name, found "_rpx_engage_field_options" but
         |         | expected "rpx_ui__rpx_engage_field_options"
     377 | WARNING | Format should be "* Implements hook_foo().", "* Implements
         |         | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
         |         | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements
         |         | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
         |         | hook_foo_BAR_ID_bar() for block templates."
     480 | ERROR   | All functions defined in a module file must be prefixed with
         |         | the module's name, found "_rpx_user_help_text" but expected
         |         | "rpx_ui__rpx_user_help_text"
     496 | ERROR   | All functions defined in a module file must be prefixed with
         |         | the module's name, found "_rpx_delete_user_data" but expected
         |         | "rpx_ui__rpx_delete_user_data"
    --------------------------------------------------------------------------------
    
    
    FILE: ...ns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_widgets.module
    --------------------------------------------------------------------------------
    FOUND 10 ERRORS AND 13 WARNINGS AFFECTING 23 LINES
    --------------------------------------------------------------------------------
       5 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
      10 | WARNING | [ ] All constants defined by a module must be prefixed with
         |         |     the module's name, expected
         |         |     "RPX_WIDGETS_RPX_SIGNIN_STRING" but found
         |         |     "RPX_SIGNIN_STRING"
      13 | WARNING | [ ] All constants defined by a module must be prefixed with
         |         |     the module's name, expected
         |         |     "RPX_WIDGETS_RPX_DEFAULT_LABEL_NODES_STRING" but found
         |         |     "RPX_DEFAULT_LABEL_NODES_STRING"
      14 | WARNING | [ ] All constants defined by a module must be prefixed with
         |         |     the module's name, expected
         |         |     "RPX_WIDGETS_RPX_DEFAULT_MESSAGE_NODES_STRING" but found
         |         |     "RPX_DEFAULT_MESSAGE_NODES_STRING"
      15 | WARNING | [ ] All constants defined by a module must be prefixed with
         |         |     the module's name, expected
         |         |     "RPX_WIDGETS_RPX_DEFAULT_LINKTEXT_NODES_STRING" but found
         |         |     "RPX_DEFAULT_LINKTEXT_NODES_STRING"
      16 | WARNING | [ ] All constants defined by a module must be prefixed with
         |         |     the module's name, expected
         |         |     "RPX_WIDGETS_RPX_DEFAULT_TITLE_NODES_STRING" but found
         |         |     "RPX_DEFAULT_TITLE_NODES_STRING"
      17 | WARNING | [ ] All constants defined by a module must be prefixed with
         |         |     the module's name, expected
         |         |     "RPX_WIDGETS_RPX_DEFAULT_SUMMARY_NODES_STRING" but found
         |         |     "RPX_DEFAULT_SUMMARY_NODES_STRING"
      19 | WARNING | [ ] All constants defined by a module must be prefixed with
         |         |     the module's name, expected
         |         |     "RPX_WIDGETS_RPX_DEFAULT_LABEL_COMMENTS_STRING" but found
         |         |     "RPX_DEFAULT_LABEL_COMMENTS_STRING"
      20 | WARNING | [ ] All constants defined by a module must be prefixed with
         |         |     the module's name, expected
         |         |     "RPX_WIDGETS_RPX_DEFAULT_MESSAGE_COMMENTS_STRING" but
         |         |     found "RPX_DEFAULT_MESSAGE_COMMENTS_STRING"
      21 | WARNING | [ ] All constants defined by a module must be prefixed with
         |         |     the module's name, expected
         |         |     "RPX_WIDGETS_RPX_DEFAULT_LINKTEXT_COMMENTS_STRING" but
         |         |     found "RPX_DEFAULT_LINKTEXT_COMMENTS_STRING"
      22 | WARNING | [ ] All constants defined by a module must be prefixed with
         |         |     the module's name, expected
         |         |     "RPX_WIDGETS_RPX_DEFAULT_TITLE_COMMENTS_STRING" but found
         |         |     "RPX_DEFAULT_TITLE_COMMENTS_STRING"
      23 | WARNING | [ ] All constants defined by a module must be prefixed with
         |         |     the module's name, expected
         |         |     "RPX_WIDGETS_RPX_DEFAULT_SUMMARY_COMMENTS_STRING" but
         |         |     found "RPX_DEFAULT_SUMMARY_COMMENTS_STRING"
      46 | ERROR   | [ ] All functions defined in a module file must be prefixed
         |         |     with the module's name, found "_rpx_user_login_form_alter"
         |         |     but expected "rpx_widgets__rpx_user_login_form_alter"
     179 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
     185 | ERROR   | [ ] All functions defined in a module file must be prefixed
         |         |     with the module's name, found "rpx_js" but expected
         |         |     "rpx_widgets_rpx_js"
     244 | ERROR   | [ ] All functions defined in a module file must be prefixed
         |         |     with the module's name, found "rpx_js_social" but expected
         |         |     "rpx_widgets_rpx_js_social"
     306 | ERROR   | [ ] All functions defined in a module file must be prefixed
         |         |     with the module's name, found "_rpx_locale" but expected
         |         |     "rpx_widgets__rpx_locale"
     322 | ERROR   | [ ] All functions defined in a module file must be prefixed
         |         |     with the module's name, found "_rpx_ssl" but expected
         |         |     "rpx_widgets__rpx_ssl"
     400 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
     405 | ERROR   | [ ] The array declaration extends to column 175 (the limit is
         |         |     120). The array content should be split up over multiple
         |         |     lines
     460 | ERROR   | [ ] All functions defined in a module file must be prefixed
         |         |     with the module's name, found "_rpx_share_button" but
         |         |     expected "rpx_widgets__rpx_share_button"
     470 | ERROR   | [ ] The array declaration extends to column 140 (the limit is
         |         |     120). The array content should be split up over multiple
         |         |     lines
     516 | ERROR   | [ ] All functions defined in a module file must be prefixed
         |         |     with the module's name, found "_rpx_event_enabled" but
         |         |     expected "rpx_widgets__rpx_event_enabled"
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    
    FILE: ...s/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_rules.rules.inc
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
    --------------------------------------------------------------------------------
      28 | WARNING | Avoid backslash escaping in translatable strings when
         |         | possible, use "" quotes instead
      40 | WARNING | Translatable strings must not begin or end with white spaces,
         |         | use placeholders with t() for variables
     132 | WARNING | Avoid backslash escaping in translatable strings when
         |         | possible, use "" quotes instead
     134 | WARNING | Avoid backslash escaping in translatable strings when
         |         | possible, use "" quotes instead
     137 | WARNING | Avoid backslash escaping in translatable strings when
         |         | possible, use "" quotes instead
     139 | WARNING | Avoid backslash escaping in translatable strings when
         |         | possible, use "" quotes instead
     145 | WARNING | Line exceeds 80 characters; contains 83 characters
    --------------------------------------------------------------------------------
    
    
    FILE: ...etInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx.api.php
    --------------------------------------------------------------------------------
    FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
    --------------------------------------------------------------------------------
      30 | ERROR   | unserialize() is insecure unless allowed classes are limited.
         |         | Use a safe format like JSON or use the allowed_classes option.
      66 | ERROR   | unserialize() is insecure unless allowed classes are limited.
         |         | Use a safe format like JSON or use the allowed_classes option.
      87 | ERROR   | unserialize() is insecure unless allowed classes are limited.
         |         | Use a safe format like JSON or use the allowed_classes option.
     114 | ERROR   | unserialize() is insecure unless allowed classes are limited.
         |         | Use a safe format like JSON or use the allowed_classes option.
     117 | WARNING | Unused variable $aid.
    --------------------------------------------------------------------------------
    
    
    FILE: ...rns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.tokens.inc
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------------
     18 | WARNING | Avoid backslash escaping in translatable strings when possible,
        |         | use "" quotes instead
     19 | WARNING | Avoid backslash escaping in translatable strings when possible,
        |         | use "" quotes instead
     24 | WARNING | Avoid backslash escaping in translatable strings when possible,
        |         | use "" quotes instead
    --------------------------------------------------------------------------------
    
    
    FILE: ...ns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_core.pages.inc
    --------------------------------------------------------------------------------
    FOUND 5 ERRORS AND 5 WARNINGS AFFECTING 10 LINES
    --------------------------------------------------------------------------------
      11 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
      13 | WARNING | [ ] Line exceeds 80 characters; contains 127 characters
      20 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
      32 | ERROR   | [ ] The array declaration extends to column 181 (the limit is
         |         |     120). The array content should be split up over multiple
         |         |     lines
     101 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
     187 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
     207 | ERROR   | [ ] The array declaration extends to column 419 (the limit is
         |         |     120). The array content should be split up over multiple
         |         |     lines
     210 | ERROR   | [ ] The array declaration extends to column 469 (the limit is
         |         |     120). The array content should be split up over multiple
         |         |     lines
     218 | ERROR   | [ ] The array declaration extends to column 331 (the limit is
         |         |     120). The array content should be split up over multiple
         |         |     lines
     222 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    
    FILE: ...nterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.install
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
    --------------------------------------------------------------------------------
      12 | WARNING | Line exceeds 80 characters; contains 85 characters
     238 | WARNING | Unused variable $k.
     259 | WARNING | Line exceeds 80 characters; contains 89 characters
     417 | WARNING | Line exceeds 80 characters; contains 85 characters
     526 | WARNING | '@todo' should match the format '@todo Fix problem X here.'
    --------------------------------------------------------------------------------
    
    
    FILE: ...terns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_core.module
    --------------------------------------------------------------------------------
    FOUND 21 ERRORS AND 19 WARNINGS AFFECTING 40 LINES
    --------------------------------------------------------------------------------
       12 | WARNING | [ ] All constants defined by a module must be prefixed with
          |         |     the module's name, expected "RPX_CORE_RPX_MODULE_VERSION"
          |         |     but found "RPX_MODULE_VERSION"
       22 | WARNING | [ ] All constants defined by a module must be prefixed with
          |         |     the module's name, expected "RPX_CORE_RPX_UPDATE_NONE"
          |         |     but found "RPX_UPDATE_NONE"
       24 | WARNING | [ ] All constants defined by a module must be prefixed with
          |         |     the module's name, expected "RPX_CORE_RPX_UPDATE_EMPTY"
          |         |     but found "RPX_UPDATE_EMPTY"
       26 | WARNING | [ ] All constants defined by a module must be prefixed with
          |         |     the module's name, expected "RPX_CORE_RPX_UPDATE_ALWAYS"
          |         |     but found "RPX_UPDATE_ALWAYS"
       28 | WARNING | [ ] All constants defined by a module must be prefixed with
          |         |     the module's name, expected "RPX_CORE_RPX_UPDATE_MAYBE"
          |         |     but found "RPX_UPDATE_MAYBE"
       30 | WARNING | [ ] All constants defined by a module must be prefixed with
          |         |     the module's name, expected "RPX_CORE_RPX_UPDATE_ADD" but
          |         |     found "RPX_UPDATE_ADD"
       35 | WARNING | [ ] All constants defined by a module must be prefixed with
          |         |     the module's name, expected
          |         |     "RPX_CORE_RPX_SESSION_LIFETIME" but found
          |         |     "RPX_SESSION_LIFETIME"
       47 | WARNING | [ ] Open page callback found, please add a comment before the
          |         |     line why there is no access restriction
       55 | WARNING | [ ] Open page callback found, please add a comment before the
          |         |     line why there is no access restriction
      149 | ERROR   | [ ] Unnecessarily gendered language in a comment
      179 | WARNING | [ ] Unused variable $mid.
      212 | WARNING | [ ] Unused variable $mid.
      235 | WARNING | [ ] Unused variable $mid.
      259 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found "rpx_user_register_submit"
          |         |     but expected "rpx_core_rpx_user_register_submit"
      291 | ERROR   | [ ] The array declaration extends to column 142 (the limit is
          |         |     120). The array content should be split up over multiple
          |         |     lines
      339 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found "_rpx_save_profile_picture"
          |         |     but expected "rpx_core__rpx_save_profile_picture"
      380 | ERROR   | [x] Each PHP statement must be on a line by itself
      383 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
      400 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found "_rpx_data_map" but
          |         |     expected "rpx_core__rpx_data_map"
      404 | ERROR   | [ ] unserialize() is insecure unless allowed classes are
          |         |     limited. Use a safe format like JSON or use the
          |         |     allowed_classes option.
      459 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found "_rpx_mail_text" but
          |         |     expected "rpx_core__rpx_mail_text"
      553 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found "_rpx_providers" but
          |         |     expected "rpx_core__rpx_providers"
      596 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
      604 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found
          |         |     "_rpx_get_provider_machine_name" but expected
          |         |     "rpx_core__rpx_get_provider_machine_name"
      609 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
      615 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found "_rpx_token_url" but
          |         |     expected "rpx_core__rpx_token_url"
      616 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
      619 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
      642 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found "_rpx_report_missing_field"
          |         |     but expected "rpx_core__rpx_report_missing_field"
      651 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
      656 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found "_rpx_import_user_data" but
          |         |     expected "rpx_core__rpx_import_user_data"
      751 | ERROR   | [ ] unserialize() is insecure unless allowed classes are
          |         |     limited. Use a safe format like JSON or use the
          |         |     allowed_classes option.
      762 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
      867 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found "_rpx_profile_get_fields"
          |         |     but expected "rpx_core__rpx_profile_get_fields"
      913 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found "_rpx_profile_format_value"
          |         |     but expected "rpx_core__rpx_profile_format_value"
      953 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found
          |         |     "_rpx_update_engage_mapping" but expected
          |         |     "rpx_core__rpx_update_engage_mapping"
      959 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
      991 | ERROR   | [ ] All functions defined in a module file must be prefixed
          |         |     with the module's name, found
          |         |     "_rpx_delete_engage_mapping" but expected
          |         |     "rpx_core__rpx_delete_engage_mapping"
     1012 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
     1061 | ERROR   | [ ] unserialize() is insecure unless allowed classes are
          |         |     limited. Use a safe format like JSON or use the
          |         |     allowed_classes option.
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    
    FILE: ...erns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_core.install
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
    --------------------------------------------------------------------------------
      40 | WARNING | Line exceeds 80 characters; contains 87 characters
     154 | ERROR   | unserialize() is insecure unless allowed classes are limited.
         |         | Use a safe format like JSON or use the allowed_classes option.
    --------------------------------------------------------------------------------
    
    
    FILE: ...erns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_rules.module
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     15 | WARNING | Open page callback found, please add a comment before the line
        |         | why there is no access restriction
    --------------------------------------------------------------------------------
    
    
    FILE: ...erns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.pages.inc
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
    --------------------------------------------------------------------------------
      17 | ERROR   | The array declaration extends to column 244 (the limit is
         |         | 120). The array content should be split up over multiple lines
     122 | ERROR   | The array declaration extends to column 168 (the limit is
         |         | 120). The array content should be split up over multiple lines
     126 | WARNING | Line exceeds 80 characters; contains 83 characters
     137 | WARNING | Line exceeds 80 characters; contains 81 characters
     178 | WARNING | Line exceeds 80 characters; contains 86 characters
    --------------------------------------------------------------------------------
    
    
    FILE: ...erns/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_ui.admin.inc
    --------------------------------------------------------------------------------
    FOUND 7 ERRORS AND 39 WARNINGS AFFECTING 46 LINES
    --------------------------------------------------------------------------------
       23 | WARNING | [ ] Translatable strings must not begin or end with white
          |         |     spaces, use placeholders with t() for variables
       40 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_apikey"
       59 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_signin_string"
       65 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_accounts_string"
      103 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_attach_login_form"
      104 | WARNING | [ ] Avoid backslash escaping in translatable strings when
          |         |     possible, use "" quotes instead
      117 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_login_icons_size"
      123 | WARNING | [ ] Avoid backslash escaping in translatable strings when
          |         |     possible, use "" quotes instead
      129 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_login_links_weight"
      130 | WARNING | [ ] Avoid backslash escaping in translatable strings when
          |         |     possible, use "" quotes instead
      136 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_force_registration_form"
      143 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_extended_authinfo"
      150 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_import_profile_photo"
      151 | WARNING | [ ] Avoid backslash escaping in translatable strings when
          |         |     possible, use "" quotes instead
      158 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_javascript_global"
      165 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_openid_override"
      181 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_social_enabled"
      197 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_default_message_nodes"
      203 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_default_linktext_nodes"
      209 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_default_title_nodes"
      215 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_default_summary_nodes"
      231 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_default_message_comments"
      237 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_default_linktext_comments"
      243 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_default_title_comments"
      249 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_default_summary_comments"
      273 | WARNING | [ ] Translatable strings must not begin or end with white
          |         |     spaces, use placeholders with t() for variables
      288 | WARNING | [ ] All variables defined by your module must be prefixed
          |         |     with your module's name to avoid name collisions with
          |         |     others. Expected start with "rpx_ui" but found
          |         |     "rpx_bypass_email_verification"
      442 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
      444 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
      445 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
      556 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
      578 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
      622 | WARNING | [ ] Empty return statement not required here
      756 | WARNING | [ ] Do not use DELETE queries with db_query(), use
          |         |     db_delete() instead
      804 | WARNING | [ ] Translatable strings must not begin or end with white
          |         |     spaces, use placeholders with t() for variables
      852 | WARNING | [ ] Avoid backslash escaping in translatable strings when
          |         |     possible, use "" quotes instead
      885 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
      958 | ERROR   | [ ] The array declaration extends to column 138 (the limit is
          |         |     120). The array content should be split up over multiple
          |         |     lines
      976 | WARNING | [ ] Empty return statement not required here
     1046 | ERROR   | [ ] The array declaration extends to column 121 (the limit is
          |         |     120). The array content should be split up over multiple
          |         |     lines
     1065 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
     1079 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
     1113 | ERROR   | [ ] Unnecessarily gendered language in a comment
     1125 | ERROR   | [ ] The array declaration extends to column 143 (the limit is
          |         |     120). The array content should be split up over multiple
          |         |     lines
     1130 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
     1136 | WARNING | [ ] Unused variable $map.
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    
    FILE: ...s/Demo-site/drupal-orgissue-v9/web/modules/contrib/rpx/rpx_core.webapi.inc
    --------------------------------------------------------------------------------
    FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------------
      12 | WARNING | The class short comment should describe what the class does
         |         | and not simply repeat the class name
      13 | WARNING | Class name must be prefixed with the project name "RpxUi"
     156 | WARNING | Line exceeds 80 characters; contains 82 characters
     274 | ERROR   | The array declaration extends to column 166 (the limit is
         |         | 120). The array content should be split up over multiple lines
    --------------------------------------------------------------------------------
    
    
    FILE: ...-v9/web/modules/contrib/rpx/views/rpx_ui_handler_filter_provider_title.inc
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     26 | WARNING | Unused variable $k.
    --------------------------------------------------------------------------------
    
    
    FILE: ...emo-site/drupal-orgissue-v9/web/modules/contrib/rpx/views/rpx_ui.views.inc
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     42 | WARNING | Avoid backslash escaping in translatable strings when possible,
        |         | use "" quotes instead
    --------------------------------------------------------------------------------
    
    
    FILE: ...l-orgissue-v9/web/modules/contrib/rpx/views/rpx_ui_handler_field_share.inc
    --------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------------
     7 | WARNING | @author tags are not usually used in Drupal, because over time
       |         | multiple contributors will touch the code anyway
    --------------------------------------------------------------------------------
    
    
    FILE: ...ssue-v9/web/modules/contrib/rpx/views/rpx_ui_handler_field_delete_link.inc
    --------------------------------------------------------------------------------
    FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
    --------------------------------------------------------------------------------
     42 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
     49 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
     84 | WARNING | [ ] Unused variable $arg.
    --------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------
    
    Time: 2.55 secs; Memory: 30MB

    Kindly check

    Thanks,
    Jake

Production build 0.71.5 2024