- Issue created by @the_g_bomb
a.aaronjake โ made their first commit to this issueโs fork.
a.aaronjake โ changed the visibility of the branch 9.0.x to hidden.
Hi @the_g_bomb,
I have enabled and re-ran the cspell job, and it still did not pass. 3290470
Kindly check
Thanks,
Jake- ๐ฎ๐ณIndia kulpratap2002
There are phpcs error in it, should i also solve phps error ?
Hi @kul.pratap,
I have reviewed the pipeline and confirmed the cspell job succeeded. For the phpcs errors, I think it is fine since there is another ticket for it, you can check it here ๐ phpcs: 12 failed, 12 total tests Active if you'd like.
Will move this to RTBC now.
Thanks,
Jake- ๐ฌ๐งUnited Kingdom the_g_bomb
I am concerned here.
a. The addition of the .cspell-project-words.txt should have fixed this issue. I would prefer to figure out why that didn't get picked up and solve that issue. Perhaps there is an issue with the gitlab config file. Perhaps it is because a second very different one was added and then removed. Not sure, in a ideal world this would be fixed and then the decision as to which style of library inclusion we use can be actioned.
b. The solution implemented at the moment has just duplicated the fix rather than replace it. We should do one or the other, not both.In the case of this module I can see a clear case for not needing a .cspell-project-words.txt file, which is it is unlikely that the modules scope will increase beyond what it is currently doing and so it is unlikely that there will be a need for more words to be added in the future.
- Merge request !6Issue #3484023: Fix CSpell, add cspell-project-words file. โ (Open) created by the_g_bomb
- ๐ฌ๐งUnited Kingdom the_g_bomb
We seem to be adding commits without changing anything, I have recreated the cspell file and updated the 9.2.x branch in this fork. Tests should run and will hopefully pass this time.