Resolve phpcs issues in 2.0.x / 2.1.x

I have solved all the phpcs error, will i also solve phpstan and phpunit error to pass pipeline fully green?

Hi @kul.pratap.,

I have re-ran the pipeline, confirmed the phpcs errors are now fixed and the pipeline passed:
Gitlab CI pipeline passed phpcs

Will now move this to RTBC since this issue is for the phpcs only.

Thanks,
Jake

Please don't mark something RTBC if you haven't checked the test pipeline, because unfortunately these changes broke a lot of tests. Also, it seems to have added a cspell issue.

ankitv18 → changed the visibility of the branch 3484975-resolve-phpcs-issues to hidden.

ankitv18 → changed the visibility of the branch 3484975-phpcs-fixes-2.1.x to hidden.

All PHPCS issues have been resolved in versions 2.0.x and 2.1.x. Please review.

MR157 needs the merge conflicts fixed.

Also added a note to the issue summary that this is an important issue because this fixes deprecation warnings in PHP 8.4.

@kul.pratap Please make sure the test icon is green before setting to "Needs review." On the 2.0.x branch (3484975-phpcs-fixes), phpunit is failing, but it is not failing in dev (you can check the 2.0.x GitLab CI pipeline from the module page, which is currently here: https://git.drupalcode.org/project/metatag/-/pipelines/332334)

Since phpunit passes in dev but fails in 3484975-phpcs-fixes, then the 3484975-phpcs-fixes is broken and needs to be fixed before it can be reviewed.

@ptmkenny As the issue summary only mentions PHPCS, I have resolved the PHPCS errors and changed the issue state to 'Needs Review.' However, since you mentioned that I need to resolve PHPUnit errors and pass the pipeline, I am now working on it.

kul.pratap → changed the visibility of the branch 3484975-phpcs-fixes to hidden.

kul.pratap → changed the visibility of the branch 3484975-phpcs-fixes-2.0.x to hidden.

kul.pratap → changed the visibility of the branch 3484975- to hidden.

kul.pratap → changed the visibility of the branch 3484975-phpcs-fixes-2.0.x to active.

@ptmkenny you can check MR!154 now it is passing.

As the issue summary only mentions PHPCS, I have resolved the PHPCS errors and changed the issue state to 'Needs Review.' However, since you mentioned that I need to resolve PHPUnit errors and pass the pipeline, I am now working on it.

Yes, this issue is to fix the PHPCS test. However, the phpunit tests are passing on dev, so if as a result of fixing the PHPCS test, the phpunit test breaks, it needs to be fixed here.

Thank you for fixing MR!154. However, as stated in the issue summary, we need to fix PHPCS issues in both the 2.0.x and the 2.1.x branches. It seems you hid the branch for 2.1.x--(3484975-phpcs-fixes-2.1.x)-- but this branch also needs to have an MR with the same fixes as 2.0.x. The reason is that both 2.0.x and 2.1.x are currently supported by the module. (Also, work generally must always be committed to the latest dev branch, which in this case is 2.1.x-dev, so there is no way we can commit 2.0.x without 2.1.x.)

Setting back to "Needs work" because we need an MR for 2.1.x-dev as well with green tests.

Ok i will work on it

kul.pratap → closed merge request !166