Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 5 July 2023, over 1 year ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/addthis_social_share/addthis_social_share.module
-------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
-------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
5 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
6 | ERROR | [x] Expected 2 space(s) before asterisk; 1 found
7 | ERROR | [x] Expected 2 space(s) before asterisk; 1 found
8 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
12 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
13 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
15 | ERROR | [x] Case breaking statement indented incorrectly; expected 6 spaces, found 4
17 | ERROR | [x] Closing brace indented incorrectly; expected 1 spaces, found 0
31 | ERROR | [x] Expected 1 newline at end of file; 3 found
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/addthis_social_share.links.menu.yml
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
12 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/addthis_social_share.permissions.yml
---------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/addthis_social_share.links.task.yml
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
8 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/templates/addthis-share-toolbox.html.twig
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
45 | ERROR | [x] Expected 1 newline at end of file; 3 found
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/addthis_social_share.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/addthis_social_share.routing.yml
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
14 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/css/addthis.css
--------------------------------------------------------------------------------------
FOUND 16 ERRORS AFFECTING 14 LINES
--------------------------------------------------------------------------------------
1 | ERROR | [x] Multiple selectors should each be on a single line
24 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
25 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
34 | ERROR | [x] Multiple selectors should each be on a single line
51 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
68 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
81 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
82 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
83 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
88 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
89 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
93 | ERROR | [x] Multiple selectors should each be on a single line
93 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
97 | ERROR | [x] Multiple selectors should each be on a single line
97 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
100 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/css/addthis.admin.css
------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
------------------------------------------------------------------------
2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
6 | ERROR | [x] Multiple selectors should each be on a single line
7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Element/AddThisBasicButton.php
---------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 2 WARNINGS AFFECTING 8 LINES
---------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
5 | ERROR | [x] Doc comment short description must end with a full stop
10 | WARNING | [x] Unused use statement
13 | ERROR | [x] Doc comment short description must end with a full stop
16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
34 | ERROR | [x] Missing function doc comment
47 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
55 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Element/AddThisBasicToolbox.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 31 ERRORS AND 3 WARNINGS AFFECTING 28 LINES
------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
5 | ERROR | [x] Doc comment short description must end with a full stop
13 | ERROR | [x] Doc comment short description must end with a full stop
16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
35 | ERROR | [x] Expected 1 blank line after function; 2 found
38 | ERROR | [x] Missing function doc comment
47 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
53 | ERROR | [x] Short array syntax must be used to define arrays
56 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
60 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8
61 | ERROR | [x] Case breaking statements must be followed by a single blank line
61 | ERROR | [x] Case breaking statement indented incorrectly; expected 10 spaces, found 8
63 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8
64 | ERROR | [x] Case breaking statements must be followed by a single blank line
64 | ERROR | [x] Case breaking statement indented incorrectly; expected 10 spaces, found 8
66 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8
67 | ERROR | [x] Case breaking statements must be followed by a single blank line
67 | ERROR | [x] Case breaking statement indented incorrectly; expected 10 spaces, found 8
69 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8
70 | ERROR | [x] Case breaking statements must be followed by a single blank line
70 | ERROR | [x] Case breaking statement indented incorrectly; expected 10 spaces, found 8
72 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8
73 | WARNING | [ ] Line exceeds 80 characters; contains 134 characters
74 | ERROR | [x] Case breaking statements must be followed by a single blank line
74 | ERROR | [x] Case breaking statement indented incorrectly; expected 10 spaces, found 8
76 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8
77 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8
78 | ERROR | [x] Case breaking statements must be followed by a single blank line
78 | ERROR | [x] Case breaking statement indented incorrectly; expected 10 spaces, found 8
80 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8
81 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8
82 | ERROR | [x] Case breaking statement indented incorrectly; expected 10 spaces, found 8
88 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
93 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 32 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Util/AddThisJson.php
-------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AND 1 WARNING AFFECTING 9 LINES
-------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
11 | ERROR | [x] Missing class doc comment
13 | ERROR | [x] Missing function doc comment
15 | WARNING | [ ] Line exceeds 80 characters; contains 103 characters
19 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6
19 | ERROR | [x] Object operator not indented correctly; expected 8 spaces but found 6
20 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6
35 | ERROR | [x] Expected 1 blank line after function; 0 found
36 | ERROR | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Form/AddThisSettingsForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 69 ERRORS AND 60 WARNINGS AFFECTING 121 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
9 | WARNING | [x] Unused use statement
10 | WARNING | [x] Unused use statement
23 | ERROR | [ ] Public method name "AddThisSettingsForm::getFormID" is not in lowerCamel format
39 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
41 | ERROR | [x] No space found before comment text; expected "// Add our library to the settings form to add in custom CSS." but found
| | "//Add our library to the settings form to add in custom CSS."
45 | ERROR | [x] Short array syntax must be used to define arrays
47 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
49 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
50 | WARNING | [x] A comma should follow the last multiline array item. Found: 'before'
52 | ERROR | [x] Short array syntax must be used to define arrays
54 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
57 | ERROR | [x] Short array syntax must be used to define arrays
59 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
60 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
65 | ERROR | [x] Short array syntax must be used to define arrays
67 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
69 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
69 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead
74 | ERROR | [x] Short array syntax must be used to define arrays
76 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
78 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
78 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead
83 | ERROR | [x] Short array syntax must be used to define arrays
85 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
86 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
90 | ERROR | [x] Short array syntax must be used to define arrays
92 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
93 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
97 | ERROR | [x] Short array syntax must be used to define arrays
99 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
100 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
108 | ERROR | [x] Short array syntax must be used to define arrays
110 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
111 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
116 | ERROR | [x] Short array syntax must be used to define arrays
118 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
126 | ERROR | [x] Short array syntax must be used to define arrays
128 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
131 | ERROR | [x] Short array syntax must be used to define arrays
133 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
134 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
138 | ERROR | [x] Short array syntax must be used to define arrays
140 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
141 | WARNING | [ ] #description values usually have to run through t() for translation
145 | ERROR | [x] Short array syntax must be used to define arrays
147 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
148 | WARNING | [ ] #description values usually have to run through t() for translation
154 | ERROR | [x] Short array syntax must be used to define arrays
156 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
157 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
161 | ERROR | [x] Short array syntax must be used to define arrays
163 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
170 | ERROR | [x] No space found before comment text; expected "// Analytics settings." but found "//Analytics settings."
173 | ERROR | [x] Short array syntax must be used to define arrays
175 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
180 | ERROR | [x] Short array syntax must be used to define arrays
183 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
184 | ERROR | [x] Short array syntax must be used to define arrays
184 | ERROR | [x] Short array syntax must be used to define arrays
188 | ERROR | [x] Short array syntax must be used to define arrays
190 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
194 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
196 | ERROR | [x] Short array syntax must be used to define arrays
198 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
199 | WARNING | [ ] #description values usually have to run through t() for translation
205 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
207 | ERROR | [x] Inline comments must start with a capital letter
208 | WARNING | [ ] Line exceeds 80 characters; contains 207 characters
208 | ERROR | [ ] Comment indentation error, expected only 1 spaces
209 | ERROR | [ ] Comment indentation error, expected only 3 spaces
213 | WARNING | [ ] Line exceeds 80 characters; contains 96 characters
213 | ERROR | [ ] Comment indentation error, expected only 1 spaces
214 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
215 | ERROR | [x] Short array syntax must be used to define arrays
218 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
220 | ERROR | [x] Short array syntax must be used to define arrays
227 | ERROR | [x] Short array syntax must be used to define arrays
229 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
230 | ERROR | [x] Short array syntax must be used to define arrays
237 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
238 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
238 | ERROR | [x] Object operator not indented correctly; expected 6 spaces but found 4
239 | WARNING | [x] '@TODO Get back to this.' should match the format '@todo Fix problem X here.'
239 | ERROR | [x] No space found before comment text; expected "// @TODO Get back to this." but found "//@TODO Get back to this."
243 | ERROR | [x] Short array syntax must be used to define arrays
247 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
250 | ERROR | [x] Short array syntax must be used to define arrays
254 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
258 | ERROR | [x] Short array syntax must be used to define arrays
262 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
265 | ERROR | [x] Short array syntax must be used to define arrays
267 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
268 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
273 | ERROR | [x] Short array syntax must be used to define arrays
275 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
276 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
283 | ERROR | [x] Short array syntax must be used to define arrays
285 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
288 | ERROR | [x] Short array syntax must be used to define arrays
290 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
294 | ERROR | [x] Short array syntax must be used to define arrays
296 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
297 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
301 | ERROR | [x] Short array syntax must be used to define arrays
303 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
304 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
316 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
316 | ERROR | [x] Object operator not indented correctly; expected 6 spaces but found 4
317 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
318 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
319 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
320 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
321 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
322 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
323 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
324 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
325 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
326 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
327 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
328 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
329 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
330 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
331 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
332 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
333 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
334 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
339 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 69 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Form/AddThisSettingsAdvancedForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 29 ERRORS AND 21 WARNINGS AFFECTING 47 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
11 | WARNING | [x] Unused use statement
12 | WARNING | [x] Unused use statement
22 | ERROR | [ ] Public method name "AddThisSettingsAdvancedForm::getFormID" is not in lowerCamel format
37 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
39 | ERROR | [x] No space found before comment text; expected "// Add our library to the settings form to add in custom CSS." but found
| | "//Add our library to the settings form to add in custom CSS."
43 | ERROR | [x] Short array syntax must be used to define arrays
45 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
48 | ERROR | [x] Short array syntax must be used to define arrays
50 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
54 | ERROR | [x] Short array syntax must be used to define arrays
56 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
60 | ERROR | [x] Short array syntax must be used to define arrays
62 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
66 | ERROR | [x] Short array syntax must be used to define arrays
68 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
74 | ERROR | [x] Short array syntax must be used to define arrays
76 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
77 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
78 | ERROR | [x] Array indentation error, expected 8 spaces but found 6
78 | ERROR | [x] Object operator not indented correctly; expected 8 spaces but found 6
81 | ERROR | [x] Short array syntax must be used to define arrays
83 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
86 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
88 | ERROR | [x] Short array syntax must be used to define arrays
90 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
93 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
95 | ERROR | [x] Short array syntax must be used to define arrays
97 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
98 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
101 | ERROR | [x] Short array syntax must be used to define arrays
103 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
104 | ERROR | [x] Short array syntax must be used to define arrays
105 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
105 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead
106 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
107 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
111 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
121 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
121 | ERROR | [x] Object operator not indented correctly; expected 6 spaces but found 4
122 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
123 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
124 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
125 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
126 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
127 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
128 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
129 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
134 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 30 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/AddThisBasicButtonFormTrait.php
---------------------------------------------------------------------------------------------------------------------
FOUND 18 ERRORS AND 1 WARNING AFFECTING 14 LINES
---------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
7 | ERROR | [x] Additional blank lines found at end of doc comment
12 | ERROR | [x] Doc comment short description must end with a full stop
13 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
14 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
20 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
20 | ERROR | [ ] Description for the @return value must be on the next line
22 | ERROR | [x] Expected 1 blank line before function; 2 found
22 | ERROR | [x] Expected 1 space before opening brace; found 0
32 | ERROR | [ ] Missing parameter type
32 | ERROR | [x] Parameter comment must be on the next line
33 | ERROR | [ ] Missing parameter type
33 | ERROR | [x] Parameter comment must be on the next line
35 | ERROR | [ ] Description for the @return value must be on the next line
37 | ERROR | [x] Expected 1 space before opening brace; found 0
58 | ERROR | [x] Expected 1 blank line after function; 3 found
61 | ERROR | [ ] More than 2 empty lines are not allowed
62 | ERROR | [x] Expected 1 newline at end of file; 0 found
62 | ERROR | [x] The closing brace for the trait must have an empty line before it
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/AddThisScriptManager.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 40 ERRORS AND 11 WARNINGS AFFECTING 40 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
5 | ERROR | [x] Doc comment short description must be on the first line
5 | ERROR | [x] Doc comment short description must end with a full stop
9 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
14 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
19 | ERROR | [x] There must be one blank line after the namespace declaration
24 | ERROR | [x] Inline comments must start with a capital letter
24 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
27 | WARNING | [x] Unused use statement
29 | ERROR | [x] Missing class doc comment
30 | ERROR | [ ] Missing short description in doc comment
33 | ERROR | [ ] Class property $language_manager should use lowerCamel naming without underscores
35 | ERROR | [ ] Missing short description in doc comment
38 | ERROR | [ ] Class property $config_factory should use lowerCamel naming without underscores
43 | ERROR | [ ] Missing parameter comment
44 | ERROR | [ ] Missing parameter comment
46 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
46 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
54 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
56 | WARNING | [x] '@TODO Allow alter of 'addthis_configuration'.' should match the format '@todo Fix problem X here.'
72 | ERROR | [x] No space found before comment text; expected "// 'services_expanded' => @todo - add this" but found
| | "//'services_expanded' => @todo - add this"
88 | ERROR | [x] No space found before comment text; expected "// Ensure that the Google Analytics module is enabled for tracking." but
| | found "//Ensure that the Google Analytics module is enabled for tracking."
89 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
92 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8
92 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 8
101 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
102 | ERROR | [x] Doc comment short description must end with a full stop
102 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
104 | WARNING | [x] '@TODO Allow alter of 'addthis_configuration_share'.' should match the format '@todo Fix problem X here.'
122 | ERROR | [ ] Missing parameter comment
122 | ERROR | [ ] Missing parameter type
123 | ERROR | [x] Separate the @param and @return sections by a blank line.
123 | ERROR | [ ] Description for the @return value is missing
143 | ERROR | [x] Short array syntax must be used to define arrays
147 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
147 | ERROR | [x] Short array syntax must be used to define arrays
149 | WARNING | [x] A comma should follow the last multiline array item. Found: )
157 | ERROR | [x] Short array syntax must be used to define arrays
161 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
161 | ERROR | [x] No space found before comment text; expected "// #options expects a string, not an array. Render the element so it
| | becomes a string." but found "//#options expects a string, not an array. Render the element so it becomes a string."
162 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
172 | ERROR | [ ] Description for the @return value is missing
192 | ERROR | [ ] Type hint "array" missing for $element
197 | ERROR | [x] No space found before comment text; expected "// Generate AddThisWidgetURL" but found "//Generate AddThisWidgetURL"
197 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
209 | ERROR | [x] No space found before comment text; expected "// Always load the script with domready flag." but found "//Always load
| | the script with domready flag."
230 | ERROR | [x] Expected 1 blank line after function; 2 found
233 | ERROR | [x] Expected 1 newline at end of file; 4 found
233 | ERROR | [x] The closing brace for the class must have an empty line before it
236 | ERROR | [ ] More than 2 empty lines are not allowed
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 30 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Tests/AddThisBaseTest.php
------------------------------------------------------------------------------------------------------------------------
FOUND 30 ERRORS AND 4 WARNINGS AFFECTING 25 LINES
------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
3 | ERROR | [x] Doc comment short description must be on the first line
4 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
7 | ERROR | [x] There must be one blank line after the namespace declaration
22 | ERROR | [x] Short array syntax must be used to define arrays
27 | WARNING | [ ] Possible useless method overriding detected
27 | ERROR | [x] Expected 1 space before opening brace; found 0
35 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
36 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
38 | ERROR | [x] Expected 1 space before opening brace; found 0
44 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
46 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
48 | ERROR | [ ] Missing parameter comment
48 | ERROR | [ ] Missing parameter type
49 | ERROR | [ ] Missing parameter comment
49 | ERROR | [ ] Missing parameter type
50 | ERROR | [ ] Missing parameter comment
50 | ERROR | [ ] Missing parameter type
51 | ERROR | [ ] Missing parameter comment
51 | ERROR | [ ] Missing parameter type
53 | ERROR | [x] Expected 1 space before opening brace; found 0
59 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
60 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
62 | ERROR | [ ] Missing parameter comment
62 | ERROR | [ ] Missing parameter type
63 | ERROR | [ ] Missing parameter comment
63 | ERROR | [ ] Missing parameter type
64 | ERROR | [ ] Missing parameter comment
64 | ERROR | [ ] Missing parameter type
65 | ERROR | [ ] Missing parameter comment
65 | ERROR | [ ] Missing parameter type
67 | ERROR | [x] Expected 1 space before opening brace; found 0
71 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Tests/AddThisFieldWebTestBase.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 26 ERRORS AND 8 WARNINGS AFFECTING 31 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
14 | WARNING | [x] Unused use statement
16 | ERROR | [x] Missing class doc comment
18 | ERROR | [ ] Missing short description in doc comment
23 | ERROR | [ ] Missing short description in doc comment
24 | ERROR | [x] Data types in @var tags need to be fully namespaced
28 | ERROR | [ ] Missing short description in doc comment
29 | ERROR | [x] Data types in @var tags need to be fully namespaced
33 | ERROR | [ ] Missing short description in doc comment
43 | ERROR | [x] Short array syntax must be used to define arrays
43 | ERROR | [x] Comma not allowed after last value in single-line array declaration
48 | ERROR | [x] Doc comment long description must end with a full stop
55 | ERROR | [x] Short array syntax must be used to define arrays
67 | ERROR | [x] Short array syntax must be used to define arrays
71 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
72 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
72 | ERROR | [x] Short array syntax must be used to define arrays
76 | ERROR | [x] Short array syntax must be used to define arrays
80 | ERROR | [x] Short array syntax must be used to define arrays
87 | ERROR | [x] Parameter comment must end with a full stop
89 | ERROR | [x] Parameter comment must end with a full stop
91 | ERROR | [x] Parameter comment must end with a full stop
106 | ERROR | [x] Short array syntax must be used to define arrays
111 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
115 | ERROR | [x] Short array syntax must be used to define arrays
120 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
122 | ERROR | [x] Short array syntax must be used to define arrays
129 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
131 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
132 | ERROR | [x] Short array syntax must be used to define arrays
139 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
139 | ERROR | [x] Short array syntax must be used to define arrays
143 | ERROR | [x] Short array syntax must be used to define arrays
146 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 23 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Tests/AddThisFieldTest.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 33 ERRORS AND 4 WARNINGS AFFECTING 31 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
19 | ERROR | [x] Doc comment short description must end with a full stop
19 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
21 | ERROR | [x] Expected 1 blank line before function; 2 found
34 | ERROR | [x] Doc comment short description must end with a full stop
34 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
36 | ERROR | [x] Expected 1 space before opening brace; found 0
40 | ERROR | [x] Concat operator must be surrounded by a single space
43 | ERROR | [x] No space found before comment text; expected "// Fieldname is set to the name, without field_ so we need to add it
| | back." but found "//Fieldname is set to the name, without field_ so we need to add it back."
46 | ERROR | [x] No space found before comment text; expected "// Set the display type to AddThis Toolbox." but found "//Set the display
| | type to AddThis Toolbox."
48 | ERROR | [x] Short array syntax must be used to define arrays
49 | ERROR | [x] Concat operator must be surrounded by a single space
50 | WARNING | [x] A comma should follow the last multiline array item. Found: $field_key
52 | ERROR | [x] Short array syntax must be used to define arrays
52 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
53 | ERROR | [x] Concat operator must be surrounded by a single space
57 | ERROR | [x] Short array syntax must be used to define arrays
73 | ERROR | [x] Doc comment short description must end with a full stop
73 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
75 | ERROR | [x] Expected 1 space before opening brace; found 0
79 | ERROR | [x] Concat operator must be surrounded by a single space
82 | ERROR | [x] No space found before comment text; expected "// Fieldname is set to the name, without field_ so we need to add it
| | back." but found "//Fieldname is set to the name, without field_ so we need to add it back."
85 | ERROR | [x] No space found before comment text; expected "// Set the display type to AddThis Toolbox." but found "//Set the display
| | type to AddThis Toolbox."
87 | ERROR | [x] Short array syntax must be used to define arrays
88 | ERROR | [x] Concat operator must be surrounded by a single space
89 | WARNING | [x] A comma should follow the last multiline array item. Found: $field_key
91 | ERROR | [x] Short array syntax must be used to define arrays
91 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
92 | ERROR | [x] Concat operator must be surrounded by a single space
96 | ERROR | [x] Short array syntax must be used to define arrays
101 | ERROR | [x] Expected 1 blank line after function; 5 found
104 | ERROR | [ ] More than 2 empty lines are not allowed
105 | ERROR | [ ] More than 2 empty lines are not allowed
106 | ERROR | [ ] More than 2 empty lines are not allowed
107 | ERROR | [x] Expected 1 newline at end of file; 0 found
107 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 29 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Tests/AddThisPermissionsTest.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 19 ERRORS AND 7 WARNINGS AFFECTING 19 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
23 | ERROR | [x] Short array syntax must be used to define arrays
28 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
30 | ERROR | [x] Visibility must be declared on method "testAddThisConfigPermissionDenied"
30 | ERROR | [x] Expected 1 space before opening brace; found 0
32 | ERROR | [x] Short array syntax must be used to define arrays
36 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
40 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
48 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
50 | ERROR | [x] Visibility must be declared on method "testAddThisConfigPermissionGranted"
50 | ERROR | [x] Expected 1 space before opening brace; found 0
52 | ERROR | [x] Short array syntax must be used to define arrays
56 | WARNING | [ ] Line exceeds 80 characters; contains 142 characters
56 | WARNING | [x] There must be no blank line following an inline comment
56 | WARNING | [ ] There must be no blank line following an inline comment
56 | ERROR | [x] No space found before comment text; expected "// $this->assertNoText(t('Access denied'), 'A user with administer addthis
| | should be able to access the basic addthis configuration page');" but found "//$this->assertNoText(t('Access denied'), 'A
| | user with administer addthis should be able to access the basic addthis configuration page');"
59 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
67 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
69 | ERROR | [x] Visibility must be declared on method "testAddThisConfigPermissionAdvancedGranted"
69 | ERROR | [x] Expected 1 space before opening brace; found 0
71 | ERROR | [x] Short array syntax must be used to define arrays
75 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
77 | ERROR | [x] Expected 1 blank line after function; 2 found
80 | ERROR | [x] Expected 1 newline at end of file; 0 found
80 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Tests/AddThisBlockTest.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 50 ERRORS AND 16 WARNINGS AFFECTING 60 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
6 | ERROR | [x] There must be one blank line after the namespace declaration
22 | ERROR | [x] Short array syntax must be used to define arrays
25 | ERROR | [x] Doc comment short description must end with a full stop
34 | ERROR | [x] Expected 1 space before opening brace; found 0
40 | ERROR | [x] Expected 1 blank line after function; 0 found
44 | ERROR | [x] Doc comment short description must end with a full stop
44 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
46 | ERROR | [x] Expected 1 space before opening brace; found 0
58 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
63 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
67 | ERROR | [x] Expected 1 space before opening brace; found 0
68 | ERROR | [x] Short array syntax must be used to define arrays
73 | ERROR | [x] Short array syntax must be used to define arrays
80 | ERROR | [x] No space found before comment text; expected "// Create Block with type=addthis_share_toolbox" but found "//Create Block
| | with type=addthis_share_toolbox"
80 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
81 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
82 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
84 | ERROR | [x] No space found before comment text; expected "// Load up new block." but found "//Load up new block."
86 | ERROR | [x] No space found before comment text; expected "// Verify form fields for toolbox are here." but found "//Verify form
| | fields for toolbox are here."
92 | ERROR | [x] No space found before comment text; expected "// Test saving and loading config works." but found "//Test saving and
| | loading config works."
100 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
107 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 3 empty lines
109 | ERROR | [ ] More than 2 empty lines are not allowed
117 | ERROR | [x] Doc comment short description must end with a full stop
117 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
121 | ERROR | [x] Expected 1 space before opening brace; found 0
122 | ERROR | [x] Short array syntax must be used to define arrays
127 | ERROR | [x] Short array syntax must be used to define arrays
136 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
137 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
139 | ERROR | [x] No space found before comment text; expected "// Test - validation should fail." but found "//Test - validation should
| | fail."
144 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
145 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
147 | ERROR | [x] No space found before comment text; expected "// Test - validation should fail." but found "//Test - validation should
| | fail."
152 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
153 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
154 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
156 | ERROR | [x] No space found before comment text; expected "// Test - validation should pass." but found "//Test - validation should
| | pass."
161 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
162 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
163 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
165 | ERROR | [x] Expected 1 blank line after function; 2 found
169 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
174 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
175 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
177 | ERROR | [x] Expected 1 space before opening brace; found 0
178 | ERROR | [x] Short array syntax must be used to define arrays
183 | ERROR | [x] Short array syntax must be used to define arrays
190 | ERROR | [x] No space found before comment text; expected "// Create Block with type=addthis_share_toolbox" but found "//Create Block
| | with type=addthis_share_toolbox"
190 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
191 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
192 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
194 | ERROR | [x] No space found before comment text; expected "// Load up new block." but found "//Load up new block."
196 | ERROR | [x] No space found before comment text; expected "// Verify form fields for toolbox are here." but found "//Verify form
| | fields for toolbox are here."
200 | ERROR | [x] No space found before comment text; expected "// Verify block config saves and loads properly" but found "//Verify block
| | config saves and loads properly"
200 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
201 | ERROR | [x] Short array syntax must be used to define arrays
206 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
207 | ERROR | [x] No space found before comment text; expected "// Load up the new block configs." but found "//Load up the new block
| | configs."
212 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
214 | ERROR | [x] Expected 1 blank line after function; 3 found
217 | ERROR | [ ] More than 2 empty lines are not allowed
218 | ERROR | [x] Expected 1 newline at end of file; 0 found
218 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 44 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/AddThisBasicToolboxFormTrait.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 24 ERRORS AND 7 WARNINGS AFFECTING 25 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
7 | ERROR | [x] Additional blank lines found at end of doc comment
9 | ERROR | [x] There must be one blank line after the namespace declaration
13 | ERROR | [x] Doc comment short description must end with a full stop
14 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
15 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
21 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
21 | ERROR | [ ] Description for the @return value must be on the next line
23 | ERROR | [x] Expected 1 blank line before function; 2 found
23 | ERROR | [x] Expected 1 space before opening brace; found 0
37 | ERROR | [ ] Missing parameter type
37 | ERROR | [x] Parameter comment must be on the next line
38 | ERROR | [ ] Missing parameter type
38 | ERROR | [x] Parameter comment must be on the next line
40 | ERROR | [ ] Description for the @return value must be on the next line
42 | ERROR | [x] Expected 1 space before opening brace; found 0
51 | ERROR | [x] No space found before comment text; expected "// Validate function is defined in addthis.module." but found "//Validate
| | function is defined in addthis.module."
53 | WARNING | [x] A comma should follow the last multiline array item. Found: '::addThisDisplayElementServicesValidate'
56 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
78 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
98 | ERROR | [x] Short array syntax must be used to define arrays
108 | ERROR | [x] Expected 1 blank line after function; 2 found
111 | ERROR | [ ] Missing short description in doc comment
112 | WARNING | [x] '@TODO Find out why this is never being called.' should match the format '@todo Fix problem X here.'
115 | ERROR | [ ] Missing parameter comment
116 | ERROR | [ ] Missing parameter comment
118 | ERROR | [ ] Type hint "array" missing for $element
118 | ERROR | [ ] Type hint "FormStateInterface" missing for $form_state
127 | WARNING | [x] There must be no blank line following an inline comment
127 | WARNING | [ ] There must be no blank line following an inline comment
135 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 19 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Plugin/Block/AddThisBlock.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 34 ERRORS AND 15 WARNINGS AFFECTING 36 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
13 | ERROR | [x] There must be one blank line after the last USE statement; 0 found;
32 | ERROR | [x] Short array syntax must be used to define arrays
42 | ERROR | [x] Visibility must be declared on method "blockForm"
55 | ERROR | [x] No space found before comment text; expected "// get type from config" but found "//get type from config"
55 | ERROR | [x] Inline comments must start with a capital letter
55 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
61 | WARNING | [x] A comma should follow the last multiline array item. Found: 'display_type'
65 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
67 | ERROR | [x] Short array syntax must be used to define arrays
73 | ERROR | [x] Short array syntax must be used to define arrays
75 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
75 | ERROR | [x] Short array syntax must be used to define arrays
78 | WARNING | [ ] #options values usually have to run through t() for translation
79 | WARNING | [ ] #options values usually have to run through t() for translation
82 | ERROR | [x] Short array syntax must be used to define arrays
82 | ERROR | [x] Short array syntax must be used to define arrays
83 | ERROR | [x] Short array syntax must be used to define arrays
84 | ERROR | [x] Short array syntax must be used to define arrays
88 | ERROR | [x] Short array syntax must be used to define arrays
102 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
108 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
109 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
109 | ERROR | [ ] Missing parameter comment
110 | ERROR | [ ] Missing parameter comment
110 | ERROR | [x] Data types in @param tags need to be fully namespaced
111 | ERROR | [x] Separate the @param and @return sections by a blank line.
111 | ERROR | [ ] Description for the @return value is missing
122 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
122 | WARNING | [x] '@TODO Settings for unselected type get wiped because they dont exist in form.' should match the format '@todo Fix
| | problem X here.'
122 | ERROR | [x] No space found before comment text; expected "// @TODO Settings for unselected type get wiped because they dont exist in
| | form." but found "//@TODO Settings for unselected type get wiped because they dont exist in form."
126 | WARNING | [x] A comma should follow the last multiline array item. Found: 'display_type'
129 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
129 | ERROR | [x] No space found before comment text; expected "// Handle saving the partial elements provided by
| | AddThisBasicToolboxFormTrait." but found "//Handle saving the partial elements provided by
| | AddThisBasicToolboxFormTrait."
136 | WARNING | [x] A comma should follow the last multiline array item. Found: $key
140 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
140 | ERROR | [x] No space found before comment text; expected "// Handle saving the partial elements provided by
| | AddThisBasicButtonFormTrait." but found "//Handle saving the partial elements provided by AddThisBasicButtonFormTrait."
147 | WARNING | [x] A comma should follow the last multiline array item. Found: $key
150 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
162 | ERROR | [x] Case breaking statements must be followed by a single blank line
162 | ERROR | [x] Case breaking statement indented incorrectly; expected 8 spaces, found 6
167 | WARNING | [ ] Code after the RETURN statement on line 162 cannot be executed
169 | ERROR | [x] Case breaking statements must be followed by a single blank line
169 | ERROR | [x] Case breaking statement indented incorrectly; expected 8 spaces, found 6
178 | WARNING | [ ] Code after the RETURN statement on line 169 cannot be executed
182 | WARNING | [x] A comma should follow the last multiline array item. Found: ''
184 | ERROR | [x] Expected 1 blank line after function; 0 found
185 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 37 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Plugin/Field/FieldType/AddThisItem.php
-----------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 7 LINES
-----------------------------------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
8 | ERROR | [x] There must be one blank line after the namespace declaration
41 | ERROR | [x] Short array syntax must be used to define arrays
42 | ERROR | [x] Short array syntax must be used to define arrays
43 | ERROR | [x] Short array syntax must be used to define arrays
56 | ERROR | [x] Expected 1 blank line after function; 2 found
66 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4
66 | ERROR | [x] Object operator not indented correctly; expected 6 spaces but found 4
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Plugin/Field/FieldFormatter/AddThisFormatter.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 4 WARNINGS AFFECTING 11 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
11 | WARNING | [x] Unused use statement
28 | ERROR | [x] Expected 1 blank line before function; 0 found
29 | WARNING | [x] '@TODO Implement viewElements()' should match the format '@todo Fix problem X here.'
29 | ERROR | [x] No space found before comment text; expected "// @TODO Implement viewElements()" but found "//@TODO Implement
| | viewElements()"
30 | WARNING | [ ] Unused variable $element.
30 | ERROR | [x] Short array syntax must be used to define arrays
31 | WARNING | [ ] Unused variable $display_type.
32 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
34 | ERROR | [x] Short array syntax must be used to define arrays
35 | ERROR | [x] Short array syntax must be used to define arrays
40 | ERROR | [x] Expected 1 newline at end of file; 0 found
40 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Plugin/Field/FieldFormatter/AddThisBasicButtonFormatter.php
------------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 8 LINES
------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
12 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
32 | ERROR | [x] Expected 1 blank line before function; 0 found
33 | ERROR | [x] Short array syntax must be used to define arrays
47 | ERROR | [x] Expected 1 blank line after function; 2 found
55 | ERROR | [x] Short array syntax must be used to define arrays
61 | ERROR | [x] Expected 1 newline at end of file; 0 found
61 | ERROR | [x] The closing brace for the class must have an empty line before it
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Plugin/Field/FieldFormatter/AddThisBasicToolboxFormatter.php
-------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
31 | ERROR | [x] Expected 1 blank line before function; 0 found
32 | ERROR | [x] Short array syntax must be used to define arrays
50 | ERROR | [x] Expected 1 blank line after function; 2 found
58 | ERROR | [x] Short array syntax must be used to define arrays
68 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/src/Plugin/Field/FieldWidget/AddThisWidget.php
-----------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
32 | ERROR | [x] Short array syntax must be used to define arrays
39 | ERROR | [x] Short array syntax must be used to define arrays
46 | ERROR | [x] Short array syntax must be used to define arrays
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/config/install/addthis_social_share.settings.advanced.yml
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/config/install/addthis_social_share.settings.yml
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
26 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/addthis_social_share/config/schema/addthis_social_share.schema.yml
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
164 | ERROR | [x] Expected 1 newline at end of file; 5 found
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

Time: 324ms; Memory: 12MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig addthis_social_share/

Remaining tasks

Patch review

📌 Task
Status

Needs review

Version

1.2

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    Satish_kumar

    Hii @urvashi_vora I have applied your patch.

    These are the steps I followed:

    1. Took clone from git version 1.2.1 in drupal 10.1.x

    2. Ran this command:

    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/addthis_social_share

    Found errors.

    3. Applied your patch.

    4. Again ran the phpcs command but again some found errors.

  • First commit to issue fork.
  • Merge request !5Issue#3372573: PHPCS issues addressed. → (Open) created by Unnamed author
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India bharath-kondeti Hyderabad
  • Status changed to Needs work 8 months ago
  • Comment 8 months ago →
    a.aaronjake

    Hi @bharath-kondeti,

    Applied MR!5 successfully, some errors were fixed but it still threw many errors.

    addthis_social_share git:(master) curl https://git.drupalcode.org/project/addthis_social_share/-/merge_requests/5.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  117k    0  117k    0     0   231k      0 --:--:-- --:--:-- --:--:--  235k
patching file addthis_social_share.info.yml
patching file addthis_social_share.links.menu.yml
patching file addthis_social_share.links.task.yml
patching file addthis_social_share.module
patching file addthis_social_share.permissions.yml
patching file addthis_social_share.routing.yml
patching file addthis_social_share.services.yml
patching file config/install/addthis_social_share.settings.advanced.yml
patching file config/install/addthis_social_share.settings.yml
patching file config/schema/addthis_social_share.schema.yml
patching file css/addthis.admin.css
patching file css/addthis.css
patching file src/AddThisBasicButtonFormTrait.php
patching file src/AddThisBasicToolboxFormTrait.php
patching file src/AddThisScriptManager.php
patching file src/Element/AddThisBasicButton.php
patching file src/Element/AddThisBasicToolbox.php
patching file src/Form/AddThisSettingsAdvancedForm.php
patching file src/Form/AddThisSettingsForm.php
patching file src/Plugin/Block/AddThisBlock.php
patching file src/Plugin/Field/FieldFormatter/AddThisBasicButtonFormatter.php
patching file src/Plugin/Field/FieldFormatter/AddThisBasicToolboxFormatter.php
patching file src/Plugin/Field/FieldFormatter/AddThisFormatter.php
patching file src/Plugin/Field/FieldType/AddThisItem.php
patching file src/Plugin/Field/FieldWidget/AddThisWidget.php
patching file src/Tests/AddThisBaseTest.php
patching file src/Tests/AddThisBlockTest.php
patching file src/Tests/AddThisFieldTest.php
patching file src/Tests/AddThisFieldWebTestBase.php
patching file src/Tests/AddThisPermissionsTest.php
patching file src/Util/AddThisJson.php
patching file templates/addthis-share-toolbox.html.twig
➜  addthis_social_share git:(master) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig addthis_social_share

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/addthis_social_share/src/Form/AddThisSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Xss.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/addthis_social_share/src/Plugin/Field/FieldFormatter/AddThisBasicToolboxFormatter.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
--------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/addthis_social_share/src/Plugin/Field/FieldFormatter/AddThisFormatter.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/addthis_social_share/src/Plugin/Field/FieldFormatter/AddThisBasicButtonFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
-------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/addthis_social_share/src/AddThisScriptManager.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\addthis_social_share\Util\AddThisJson.
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------

Time: 786ms; Memory: 12MB

    Kindly check.

    Thanks,
    Jake

  • First commit to issue fork.
  • Status changed to Needs review 8 months ago
  • Comment 8 months ago →
    🇮🇳India manish-31

    I have fixed the remaining PHPCS errors. Needs review. Thanks!

  • Comment 8 months ago →
    misterdidi

    misterdidi → changed the visibility of the branch issue/3372573-phpcs to hidden.

  • Comment 8 months ago →
    misterdidi

    misterdidi → changed the visibility of the branch issue/3372573-phpcs to active.

  • Comment 8 months ago →
    misterdidi

    Applied MR!5 and ran command

    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/addthis_social_share

    No more PHPCS errors are shown.

  • Status changed to RTBC 6 months ago
  • Comment 6 months ago →
    Esha_Kundu

    Hello,
    I have applied MR!5 and executed the command
    phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig addthis_social_share/
    Found no more phpcs errors.
    RTBC+

  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    Esha_Kundu

    My bad previously I chekced the patch is being applied or not but found this issues while reviewing the code.
    Due to the change of the language manager service name in services.yml file there is this error on installation, I have attached ss.
    Please have a look.

  • Status changed to Needs review 6 months ago
  • Comment 6 months ago →
    🇮🇳India manish-31

    Installation errors fixed, needs review!

  • Status changed to RTBC 6 months ago
  • Comment 6 months ago →
    a.aaronjake

    Hi @manish-31,

    Applied your fix, confirmed no phpcs issues thrown (see below) and installation error also fixed, kindly see attached screenshot.

    addthis_social_share git:(master) curl https://git.drupalcode.org/project/addthis_social_share/-/merge_requests/5.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  118k    0  118k    0     0   251k      0 --:--:-- --:--:-- --:--:--  257k
patching file addthis_social_share.info.yml
patching file addthis_social_share.links.menu.yml
patching file addthis_social_share.links.task.yml
patching file addthis_social_share.module
patching file addthis_social_share.permissions.yml
patching file addthis_social_share.routing.yml
patching file config/install/addthis_social_share.settings.advanced.yml
patching file config/install/addthis_social_share.settings.yml
patching file config/schema/addthis_social_share.schema.yml
patching file css/addthis.admin.css
patching file css/addthis.css
patching file js/addthis.js
patching file src/AddThisBasicButtonFormTrait.php
patching file src/AddThisBasicToolboxFormTrait.php
patching file src/AddThisScriptManager.php
patching file src/Element/AddThisBasicButton.php
patching file src/Element/AddThisBasicToolbox.php
patching file src/Form/AddThisSettingsAdvancedForm.php
patching file src/Form/AddThisSettingsForm.php
patching file src/Plugin/Block/AddThisBlock.php
patching file src/Plugin/Field/FieldFormatter/AddThisBasicButtonFormatter.php
patching file src/Plugin/Field/FieldFormatter/AddThisBasicToolboxFormatter.php
patching file src/Plugin/Field/FieldFormatter/AddThisFormatter.php
patching file src/Plugin/Field/FieldType/AddThisItem.php
patching file src/Plugin/Field/FieldWidget/AddThisWidget.php
patching file src/Tests/AddThisBaseTest.php
patching file src/Tests/AddThisBlockTest.php
patching file src/Tests/AddThisFieldTest.php
patching file src/Tests/AddThisFieldWebTestBase.php
patching file src/Tests/AddThisPermissionsTest.php
patching file src/Util/AddThisJson.php
patching file templates/addthis-share-toolbox.html.twig
➜  addthis_social_share git:(master) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig addthis_social_share
➜  contrib git:(main) ✗

    Will now move this to RTBC

    Thanks,
    Jake

  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    Esha_Kundu

    Hi,
    There are still two errors on the configuration pages that are popping up after the phpcs errors fixes is applied. Although there are no phpcs errors left to be addressed but this errors must be resolved as it is causing a hindrance in the usage of the module. It seems that the errors are occurring due to the dependency injection which has been implemented while the phpcs errors have been resolved.
    Steps to get the errors:

    1. Apply the patch and visit the configuration page of addThis Social share (/admin/config/user-interface/addthis)
    2. After the first error is resolved visit the advance tab settings (admin/config/user-interface/addthis/advanced)

    The error that is appears on going to the configuration page of the module

    The error is appears on clicking the advance settings tab in the configuration page of the module

    Thanks

  • Status changed to Needs review 6 months ago
  • Comment 6 months ago →
    🇮🇳India manish-31

    Resolved. Needs review.

  • Status changed to RTBC 6 months ago
  • Comment 6 months ago →
    Esha_Kundu

    Hello @manish-31,
    I applied the MR!5 and the errors for the configuration pages that I had mentioned in #16 have been resolved.
    After applying the patch the configuration pages (/admin/config/user-interface/addthis and /admin/config/user-interface/addthis/advanced) are now displaying without any errors as shown below


    Thanks
    Moving it forward to RTBC

  • Comment 4 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    avpaderno → made their first commit to this issue’s fork.

  • Pipeline finished with Success
    4 months ago
    Total: 169s
    #298711
  • Comment 4 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Merge request !7Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix → (Open) created by apaderno
  • Pipeline finished with Success
    4 months ago
    Total: 146s
    #298715
  • Comment 4 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Comment 4 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    avpaderno → changed the visibility of the branch 3372573-gitlab-ci-reports to hidden.

  • Comment 3 months ago →
    🇮🇳India chhavi.sharma

    Working on it

  • Comment 3 months ago →
    🇮🇳India chhavi.sharma

    Solved all phpcs issues
    the phpcs pipeline is now green

  • Pipeline finished with Success
    3 months ago
    Total: 268s
    #315663
  • Comment 3 months ago →
    🇮🇳India sourav_paul Kolkata

    I've checked the MR !5 & the patch was applied cleanly.

    curl https://git.drupalcode.org/project/addthis_social_share/-/merge_requests/5.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  120k    0  120k    0     0   110k      0 --:--:--  0:00:01 --:--:--  110k
Checking patch .gitlab-ci.yml...
Checking patch addthis_social_share.info.yml...
Checking patch addthis_social_share.links.menu.yml...
Checking patch addthis_social_share.links.task.yml...
Checking patch addthis_social_share.module...
Checking patch addthis_social_share.permissions.yml...
Checking patch addthis_social_share.routing.yml...
Checking patch addthis_social_share.services.yml...
Checking patch config/install/addthis_social_share.settings.advanced.yml...
Checking patch config/install/addthis_social_share.settings.yml...
Checking patch config/schema/addthis_social_share.schema.yml...
Checking patch css/addthis.admin.css...
Checking patch css/addthis.css...
Checking patch js/addthis.js...
Checking patch src/AddThisBasicButtonFormTrait.php...
Checking patch src/AddThisBasicToolboxFormTrait.php...
Checking patch src/AddThisScriptManager.php...
Checking patch src/Element/AddThisBasicButton.php...
Checking patch src/Element/AddThisBasicToolbox.php...
Checking patch src/Form/AddThisSettingsAdvancedForm.php...
Checking patch src/Form/AddThisSettingsForm.php...
Checking patch src/Plugin/Block/AddThisBlock.php...
Checking patch src/Plugin/Field/FieldFormatter/AddThisBasicButtonFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/AddThisBasicToolboxFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/AddThisFormatter.php...
Checking patch src/Plugin/Field/FieldType/AddThisItem.php...
Checking patch src/Plugin/Field/FieldWidget/AddThisWidget.php...
Checking patch src/Tests/AddThisBaseTest.php...
Checking patch src/Tests/AddThisBlockTest.php...
Checking patch src/Tests/AddThisFieldTest.php...
Checking patch src/Tests/AddThisFieldWebTestBase.php...
Checking patch src/Tests/AddThisPermissionsTest.php...
Checking patch src/Util/AddThisJson.php...
Checking patch templates/addthis-share-toolbox.html.twig...
Applied patch .gitlab-ci.yml cleanly.
Applied patch addthis_social_share.info.yml cleanly.
Applied patch addthis_social_share.links.menu.yml cleanly.
Applied patch addthis_social_share.links.task.yml cleanly.
Applied patch addthis_social_share.module cleanly.
Applied patch addthis_social_share.permissions.yml cleanly.
Applied patch addthis_social_share.routing.yml cleanly.
Applied patch addthis_social_share.services.yml cleanly.
Applied patch config/install/addthis_social_share.settings.advanced.yml cleanly.
Applied patch config/install/addthis_social_share.settings.yml cleanly.
Applied patch config/schema/addthis_social_share.schema.yml cleanly.
Applied patch css/addthis.admin.css cleanly.
Applied patch css/addthis.css cleanly.
Applied patch js/addthis.js cleanly.
Applied patch src/AddThisBasicButtonFormTrait.php cleanly.
Applied patch src/AddThisBasicToolboxFormTrait.php cleanly.
Applied patch src/AddThisScriptManager.php cleanly.
Applied patch src/Element/AddThisBasicButton.php cleanly.
Applied patch src/Element/AddThisBasicToolbox.php cleanly.
Applied patch src/Form/AddThisSettingsAdvancedForm.php cleanly.
Applied patch src/Form/AddThisSettingsForm.php cleanly.
Applied patch src/Plugin/Block/AddThisBlock.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/AddThisBasicButtonFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/AddThisBasicToolboxFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/AddThisFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldType/AddThisItem.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/AddThisWidget.php cleanly.
Applied patch src/Tests/AddThisBaseTest.php cleanly.
Applied patch src/Tests/AddThisBlockTest.php cleanly.
Applied patch src/Tests/AddThisFieldTest.php cleanly.
Applied patch src/Tests/AddThisFieldWebTestBase.php cleanly.
Applied patch src/Tests/AddThisPermissionsTest.php cleanly.
Applied patch src/Util/AddThisJson.php cleanly.
Applied patch templates/addthis-share-toolbox.html.twig cleanly.

    I've verified that all the phpsc error got fixed using the MR!5.

    Hence moving it to RTBC.

    Thanks...

  • Comment 3 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Comment 3 months ago →
    🇮🇳India chhavi.sharma

    Working on the remaining phpcs errors.

  • Pipeline finished with Success
    3 months ago
    Total: 145s
    #322771
  • Comment 3 months ago →
    🇮🇳India chhavi.sharma

    Hi @avpaderno @sujan-shrestha,
    Resolved all the remaining phpcs errors.

  • Comment 2 months ago →
    a.aaronjake

    Hi @chhavi.sharma,

    I have reviewed your changes on MR!5 and confirmed the suggestion of sir @avpaderno was followed and the phpcs job passed.

    Will now move this to RTBC

    Thanks,
    Jake

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024