Contrib.social

Twitter logo needs to be changed to the X

Open on Drupal.org ā†’
Created on 5 March 2024, 10 months ago

Problem/Motivation

While going through the theme for issues I found out that twitter logo is still the old one.

Steps to reproduce

Install the theme and check for the twitter logo in the footer

Proposed resolution

Icon needs to be updated with new twitter logo X

Remaining tasks

none

User interface changes

yes

API changes

none

Data model changes

none

šŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

šŸ‡®šŸ‡³India hamid.ali

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @hamid.ali
  • First commit to issue fork.
  • Assigned to shivamsen_12579
  • Comment 10 months ago ā†’
    šŸ‡®šŸ‡³India shivamsen_12579 Bhopal
  • Merge request !12Issue #3425635: Twitter logo needs to be changed to the X ā†’ (Open) created by shivamsen_12579
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago ā†’
    šŸ‡®šŸ‡³India shivamsen_12579 Bhopal

    Updated the twiter icon to the X icon using font-awesome library.

  • Comment 7 months ago ā†’
    bindu r

    HI. After applying the MR 12 site showing error. Attaching the screenshots for reference.

  • Comment 7 months ago ā†’
    bindu r
  • Comment 21 days ago ā†’
    šŸ‡®šŸ‡³India Rohit Rana

    Hi @shivamsen_12579 After applying the patch, I got this error. 

    Uncaught PHP Exception Drupal\\Core\\Asset\\Exception\\InvalidLibraryFileException: "Invalid library definition in themes/contrib/yg_restaurant/yg_restaurant.libraries.yml: Duplicate key "js/bootstrap-datetimepicker.min.js" detected at line 25 (near "js/bootstrap-datetimepicker.min.js: {}").

    so I corrected the patch.

  • Comment 21 days ago ā†’
    šŸ‡®šŸ‡³India Rohit Rana
  • Comment 4 days ago ā†’
    a.aaronjake

    Hi @rohit rana,

    I have applied the patch you provided, it was applied (as seen below:) successfully yet, the twitter logo has not changed and the display is still the old logo. And also I noticed an error on the homepage regarding the theme.

     yg_restaurant git:(2.0.x) curl https://www.drupal.org/files/issues/2024-11-30/issue-resolved-3425635-8.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3276  100  3276    0     0   5581      0 --:--:-- --:--:-- --:--:--  5707
patching file templates/html.html.twig
patching file templates/page--403.html.twig
patching file templates/page--404.html.twig
patching file templates/page--front.html.twig
patching file templates/page.html.twig
āžœ  yg_restaurant git:(2.0.x) āœ—

    Please see attached images for reference.

    Thanks,
    Jake

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024