Fix the issues reported by phpcs

Created on 10 March 2023, almost 2 years ago
Updated 20 August 2024, 4 months ago
📌 Task
Status

Needs review

Version

3.0

Component

Code

Created by

🇮🇳India samit.310@gmail.com

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @samit.310@gmail.com
  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • 🇮🇳India samit.310@gmail.com

    Above error/warnings has been fixed.

  • Status changed to RTBC almost 2 years ago
  • 🇮🇳India hardikpandya

    The patch fixes all phpcs issues. Marking RTBC!

  • @hardikpandya opened merge request.
  • Status changed to Needs work almost 2 years ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
     /**
    - * Class ShortcutMenuSetCustomize.
    + * The ShortcutMenuSetCustomize Class.

    What does the phpcs report say about that line?

    +/**
    + * The ShortcutMenuLazyBuilder Class.
    + */
    

    What is wrong with those lines?

    -  protected $entity_type_manager;
    +  protected $entityTypeManager;
    

    That is not a necessary change, except in the case the code is already using $entityTypeManager.

  • First commit to issue fork.
  • Status changed to Needs review almost 2 years ago
  • 🇮🇳India kkalashnikov Ghaziabad, India
  • Status changed to Needs work almost 2 years ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
     /**
    - * Class ShortcutMenuSetCustomize.
    + * The set customization for shortcut menu.
    

    That does not describe what the class does, nor does it make sense.

    +  /**
    +   * Gets the Parent id from UUID.
    +   */

    Parameters and return value need to be documented.

  • Assigned to elber
  • 🇧🇷Brazil elber Brazil

    I will work on it.

  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • 🇧🇷Brazil elber Brazil

    Hi I fixed the errors mentioned previously, please revise.

  • Status changed to Needs work 4 months ago
  • Hi @elber,

    Applied the latest changes made on MR!2, it was applied successfully but one file with 2 errors were still reported. Please see below:

    ➜  shortcut_menu git:(main) ✗ curl https://git.drupalcode.org/project/shortcut_menu/-/merge_requests/2.diff | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  3125    0  3125    0     0   6552      0 --:--:-- --:--:-- --:--:--  6706
    patching file shortcut_menu.install
    patching file src/Form/ShortcutMenuSetCustomize.php
    patching file src/ShortcutMenuLazyBuilder.php
    ➜  shortcut_menu git:(main) ✗ ..
    ➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig shortcut_menu
    
    FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/shortcut_menu/src/Form/ShortcutMenuSetCustomize.php
    ----------------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ----------------------------------------------------------------------------------------------------------------------------
     177 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
     196 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
    ----------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------------------------------------------------------------
    
    Time: 266ms; Memory: 10MB

    Kindly check

    Thanks,
    Jake

  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    avpaderno changed the visibility of the branch 3347117-phpcs-fixes to hidden.

  • Pipeline finished with Failed
    4 months ago
    Total: 127s
    #259560
  • Pipeline finished with Failed
    4 months ago
    Total: 130s
    #259562
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    avpaderno changed the visibility of the branch 3347117-gitlab-ci-reports to hidden.

  • Assigned to apaderno
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Status changed to Needs review 4 months ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Issue was unassigned.
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Pipeline finished with Failed
    4 months ago
    #259575
Production build 0.71.5 2024