- Issue created by @aman1248
- Assigned to Indranil Roy
- Issue was unassigned.
- Status changed to Needs review
7 months ago 9:33am 24 May 2024 - 🇮🇳India Indranil Roy kolkata
Hey @Amandeep123, I have raised the pr please review.
- 🇮🇳India dev16.addweb
Thanks @indranil-roy, I have review but found some errors in phpcs testing
FILE: /home/addweb/Drupal8-vagrant/web/web/contribution/drupal-10-3/web/modules/custom/advanced_maintenance_page/README.md
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------------------------
28 | WARNING | Line exceeds 80 characters; contains 85 characters
29 | WARNING | Line exceeds 80 characters; contains 92 characters
36 | WARNING | Line exceeds 80 characters; contains 95 characters
38 | WARNING | Line exceeds 80 characters; contains 158 characters
47 | WARNING | Line exceeds 80 characters; contains 102 characters
--------------------------------------------------------------------------------------------------------------------------Time: 50ms; Memory: 10MB
- 🇮🇳India dev16.addweb
Modified file and committed changes for #5, Please review.
- Status changed to Needs work
6 months ago 9:58am 4 July 2024 - 🇮🇳India kalash-j jaipur
Hi, I reviewed MR !4. The README.md file follows the standard format except for the "two lines prior to ##/### headings" as mentioned in the README.md document.
- Status changed to Needs review
6 months ago 10:28am 5 July 2024 - 🇮🇳India Indranil Roy kolkata
Hi @kalash-j, addressed your comment#7 and updated the MR. Please check.
- Status changed to Needs work
6 months ago 4:56am 8 July 2024 - 🇵ðŸ‡Philippines kenyoOwen
Hi Indranil Roy
I reviewed MR!4 and it doesn't follow the README.md template format.
Drupal recommends the following README sections: Project name and introduction (required) Table of contents (optional) Requirements (required) Recommended modules (optional) Installation (required, unless a separate INSTALL.md is provided) Configuration (required) Troubleshooting & FAQ (optional) Maintainers (optional)
Thanks
- Status changed to Needs review
5 months ago 8:20am 16 July 2024 - 🇮🇳India dev16.addweb
Hi,
Modified README.md as per #9, Please review it. - Status changed to RTBC
5 months ago 8:43am 16 July 2024 - 🇮🇳India riddhi.addweb
I have tested the ReadMe.md file format and it seems proper to me, moving this to RTBC.
ReadMe.md file:- https://git.drupalcode.org/issue/advanced_maintenance_page-3428000/-/blo...
Reference Doc:- https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →