Fix CI warnings: eslint and stylelint

Created on 22 May 2024, 7 months ago
Updated 6 August 2024, 4 months ago

After adding Gitlab CI โ†’ in โœจ Add Gitlab CI to module Fixed

Fix

  • eslint issues
  • stylelint issues
โœจ Feature request
Status

RTBC

Version

3.0

Component

Code

Created by

๐Ÿ‡ฆ๐Ÿ‡บAustralia VladimirAus Brisbane, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @VladimirAus
  • Merge request !8eslint and style lint fixes โ†’ (Open) created by VladimirAus
  • Status changed to Needs work 7 months ago
  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia VladimirAus Brisbane, Australia
  • First commit to issue fork.
  • Pipeline finished with Success
    7 months ago
    Total: 159s
    #179294
  • Pipeline finished with Success
    7 months ago
    Total: 146s
    #179309
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom aaron.ferris

    aaron.ferris โ†’ made their first commit to this issueโ€™s fork.

  • Pipeline finished with Success
    7 months ago
    Total: 153s
    #180191
  • Pipeline finished with Success
    7 months ago
    #180196
  • Pipeline finished with Success
    7 months ago
    Total: 167s
    #180199
  • Pipeline finished with Success
    7 months ago
    Total: 144s
    #180205
  • Pipeline finished with Success
    7 months ago
    Total: 145s
    #180210
  • Status changed to Needs review 7 months ago
  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia VladimirAus Brisbane, Australia
  • Status changed to Needs work 7 months ago
  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia jannakha Brisbane!

    while you're fixing text - can you please update description (see gitlab MR comments):

    `This module allows users with appropriate permissions to add and configure "Scroll up" button. Button allows users to scroll up to the top of the page.`

  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom aaron.ferris

    Pushed some changes that should get the build passing, eslint (mainly via the CI patches) and Stylelint.

  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom aaron.ferris

    Also addressed those code review comments, thanks @annakha.

  • Status changed to Needs review 7 months ago
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom aaron.ferris
  • Pipeline finished with Success
    7 months ago
    Total: 149s
    #180296
  • Status changed to RTBC 4 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia kalash-j jaipur

    I have reviewed MR!8 and the code is working fine

Production build 0.71.5 2024