Fix CI warnings: eslint and stylelint

Created on 22 May 2024, about 1 month ago
Updated 23 May 2024, about 1 month ago

After adding Gitlab CI β†’ in ✨ Add Gitlab CI to module Fixed

Fix

  • eslint issues
  • stylelint issues
✨ Feature request
Status

Needs review

Version

3.0

Component

Code

Created by

πŸ‡¦πŸ‡ΊAustralia VladimirAus Brisbane, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @VladimirAus
  • Merge request !8eslint and style lint fixes β†’ (Open) created by VladimirAus
  • Status changed to Needs work about 1 month ago
  • πŸ‡¦πŸ‡ΊAustralia VladimirAus Brisbane, Australia
  • First commit to issue fork.
  • Pipeline finished with Success
    about 1 month ago
    Total: 159s
    #179294
  • Pipeline finished with Success
    about 1 month ago
    Total: 146s
    #179309
  • πŸ‡¬πŸ‡§United Kingdom aaron.ferris

    aaron.ferris β†’ made their first commit to this issue’s fork.

  • Pipeline finished with Success
    about 1 month ago
    Total: 153s
    #180191
  • Pipeline finished with Success
    about 1 month ago
    #180196
  • Pipeline finished with Success
    about 1 month ago
    Total: 167s
    #180199
  • Pipeline finished with Success
    about 1 month ago
    Total: 144s
    #180205
  • Pipeline finished with Success
    about 1 month ago
    Total: 145s
    #180210
  • Status changed to Needs review about 1 month ago
  • πŸ‡¦πŸ‡ΊAustralia VladimirAus Brisbane, Australia
  • Status changed to Needs work about 1 month ago
  • πŸ‡¦πŸ‡ΊAustralia jannakha Brisbane!

    while you're fixing text - can you please update description (see gitlab MR comments):

    `This module allows users with appropriate permissions to add and configure "Scroll up" button. Button allows users to scroll up to the top of the page.`

  • πŸ‡¬πŸ‡§United Kingdom aaron.ferris

    Pushed some changes that should get the build passing, eslint (mainly via the CI patches) and Stylelint.

  • πŸ‡¬πŸ‡§United Kingdom aaron.ferris

    Also addressed those code review comments, thanks @annakha.

  • Status changed to Needs review about 1 month ago
  • πŸ‡¬πŸ‡§United Kingdom aaron.ferris
  • Pipeline finished with Success
    about 1 month ago
    Total: 149s
    #180296
Production build 0.69.0 2024