- Issue created by @indrapatil
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 9:30am 6 July 2023 - Status changed to Needs work
almost 2 years ago 9:35am 6 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Since the project has its own phpcs.xml file, that should be used with PHP_CodeSniffer.
Nisha_Poojary → changed the visibility of the branch 3372800-phpcs to hidden.
Nisha_Poojary → changed the visibility of the branch 3372800-phpcs to active.
- 🇮🇳India Yashaswi18
Yashaswi18 → changed the visibility of the branch 3372800-phpcs to hidden.
- 🇮🇳India Yashaswi18
Yashaswi18 → changed the visibility of the branch 3372800-phpcs to hidden.
- 🇮🇳India Yashaswi18
Yashaswi18 → changed the visibility of the branch 3372800-phpcs to active.
- Assigned to PrabuEla
- Issue was unassigned.
- 🇮🇳India Yashaswi18
Ran the command phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml varbase_components/ and found that there are no phpcs issues.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
The MR has conflicts that must be manually resolved.
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 2:59pm 7 February 2024 - 🇮🇳India kalash-j jaipur
The MR has conflict have been solved
Please check!! - Assigned to dev16.addweb
- Issue was unassigned.
- 🇮🇳India bhaveshdas
i have tested MR 14 and i have found some error below:-
use below this command-: vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/custom/varbase_components-3372800/FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/atoms/text/text.twig --------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/atoms/close-button/close-button.twig ------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------- 29 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/atoms/column/column.twig ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 12 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/atoms/progress-bar/progress-bar.twig ------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------- 34 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/molecules/alert/alert.twig --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 33 | ERROR | [x] Expected 1 newline at end of file; 2 found --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/molecules/navbar-brand/navbar-brand.twig ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 45 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/organisms/user/user.twig ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 16 | ERROR | [x] Expected 1 newline at end of file; 2 found ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/organisms/table/table.twig --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 100 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/organisms/page-header/page-header.twig --------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------- 46 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/organisms/block-remote-video/block-remote-video.twig ----------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------- 37 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/organisms/page-footer/page-footer.twig --------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------- 47 | ERROR | [x] Expected 1 newline at end of file; 2 found --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/organisms/block-local-video/block-local-video.twig --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 37 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/organisms/page-better-login/page-better-login.twig --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/organisms/block-cta/block-cta.twig ----------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------- 39 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/organisms/block-rich-text/block-rich-text.twig ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 27 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/organisms/media-hero-slider/media-hero-slider.twig --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 53 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/organisms/carousel/carousel.twig --------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 59 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/components/organisms/social-auth/social-auth.twig --------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------- 16 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- Time: 1.34 secs; Memory: 10MB
- Status changed to Needs work
11 months ago 11:02am 4 July 2024 - Status changed to Needs review
11 months ago 11:36am 4 July 2024 - Status changed to Needs work
11 months ago 11:54am 4 July 2024 - 🇮🇳India chandansha
i have checked MR 14 I found some issue.
please use this command to see error :--
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twigFILE: /var/www/html/test10/web/modules/custom/varbase_components-3372800/webpack.config.build.js ------------------------------------------------------------------------------------------------ FOUND 7 ERRORS AFFECTING 7 LINES ------------------------------------------------------------------------------------------------ 7 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 9 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 14 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 15 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 17 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 22 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" ------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------ FILE: /var/www/html/test10/web/modules/custom/varbase_components-3372800/webpack.config.js ---------------------------------------------------------------------------------------------- FOUND 27 ERRORS AFFECTING 19 LINES ---------------------------------------------------------------------------------------------- 29 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 47 | ERROR | [x] Expected 1 space before "/"; 0 found 47 | ERROR | [x] Expected 1 space after "/"; 0 found 47 | ERROR | [x] Expected 1 space before "/"; 0 found 47 | ERROR | [x] Expected 1 space after "/"; 0 found 50 | ERROR | [x] Expected 1 space before "/"; 0 found 50 | ERROR | [x] Expected 1 space after "/"; 0 found 79 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 82 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 97 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 98 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 99 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 100 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 101 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 132 | ERROR | [x] Expected 1 space before "/"; 0 found 132 | ERROR | [x] Expected 1 space after "/"; 0 found 132 | ERROR | [x] Expected 1 space before "/"; 0 found 132 | ERROR | [x] Expected 1 space after "/"; 0 found 135 | ERROR | [x] Expected 1 space before "/"; 0 found 135 | ERROR | [x] Expected 1 space after "/"; 0 found 164 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 171 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 185 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 188 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 189 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 190 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 196 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" ---------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 27 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------- Time: 214ms; Memory: 12MB
- Status changed to Needs review
11 months ago 12:04pm 4 July 2024 - Status changed to RTBC
11 months ago 5:14am 5 July 2024 - 🇮🇳India chandansha
i have tested MR 14 Fixed all issue.
i move forward it to RTBC. - Assigned to kalash-j
- Status changed to Needs work
11 months ago 7:11am 10 July 2024 - 🇮🇳India kalash-j jaipur
i have rebased the MR!14 with 2.0.x and i have found new phpcs issues
FILE: ...omponents-3372800/components/molecules/pagination/pagination.css ---------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------- 67 | ERROR | [x] Multiple selectors should each be on a single line 74 | ERROR | [x] Multiple selectors should each be on a single line 144 | ERROR | [x] Expected 1 newline at end of file; 2 found 145 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...-3372800/components/molecules/dynamic-responsive-image/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 5 | WARNING | Line exceeds 80 characters; contains 226 characters 17 | WARNING | Line exceeds 80 characters; contains 85 characters 24 | WARNING | Line exceeds 80 characters; contains 81 characters ---------------------------------------------------------------------- FILE: ...base_components-3372800/components/molecules/accordion/README.md ---------------------------------------------------------------------- FOUND 1 ERROR AND 8 WARNINGS AFFECTING 9 LINES ---------------------------------------------------------------------- 17 | WARNING | [ ] Line exceeds 80 characters; contains 87 | | characters 20 | WARNING | [ ] Line exceeds 80 characters; contains 91 | | characters 21 | WARNING | [ ] Line exceeds 80 characters; contains 90 | | characters 22 | WARNING | [ ] Line exceeds 80 characters; contains 84 | | characters 24 | WARNING | [ ] Line exceeds 80 characters; contains 92 | | characters 27 | WARNING | [ ] Line exceeds 80 characters; contains 93 | | characters 28 | WARNING | [ ] Line exceeds 80 characters; contains 84 | | characters 29 | WARNING | [ ] Line exceeds 80 characters; contains 90 | | characters 36 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...nents-3372800/components/molecules/navbar-brand/navbar-brand.css ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 3 | ERROR | [x] Expected 1 newline at end of file; 2 found 4 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...ase_components-3372800/components/molecules/breadcrumb/README.md ---------------------------------------------------------------------- FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------- 3 | WARNING | [ ] Line exceeds 80 characters; contains 140 | | characters 13 | WARNING | [ ] Line exceeds 80 characters; contains 287 | | characters 14 | WARNING | [ ] Line exceeds 80 characters; contains 138 | | characters 43 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...omponents-3372800/components/molecules/breadcrumb/breadcrumb.css ---------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------- 6 | ERROR | [ ] Style definition is empty 6 | ERROR | [x] Expected 0 spaces before semicolon in style | | definition; 2 found 7 | ERROR | [ ] Style definition is empty 7 | ERROR | [x] Expected 0 spaces before semicolon in style | | definition; 2 found 73 | ERROR | [x] Expected 1 newline at end of file; 2 found 74 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...stom/varbase_components-3372800/components/organisms/nav/nav.css ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 3 | ERROR | [x] Expected 1 newline at end of file; 2 found 4 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: .../varbase_components-3372800/components/organisms/media/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 94 characters 9 | WARNING | Line exceeds 80 characters; contains 92 characters ---------------------------------------------------------------------- FILE: ...72800/components/organisms/media-hero-slide/media-hero-slide.css ---------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------- 231 | ERROR | [x] Multiple selectors should each be on a single line 231 | ERROR | [x] Multiple selectors should each be on a single line 504 | ERROR | [x] Expected 1 newline at end of file; 2 found 505 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...mponents-3372800/components/organisms/media-hero-slide/README.md ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 3 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...ase_components-3372800/components/organisms/heroslider/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES ---------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 100 characters 6 | WARNING | Line exceeds 80 characters; contains 89 characters 15 | WARNING | Line exceeds 80 characters; contains 90 characters 16 | WARNING | Line exceeds 80 characters; contains 96 characters 17 | WARNING | Line exceeds 80 characters; contains 91 characters 18 | WARNING | Line exceeds 80 characters; contains 95 characters 19 | WARNING | Line exceeds 80 characters; contains 83 characters 20 | WARNING | Line exceeds 80 characters; contains 97 characters 22 | WARNING | Line exceeds 80 characters; contains 113 characters 23 | WARNING | Line exceeds 80 characters; contains 89 characters 29 | WARNING | Line exceeds 80 characters; contains 81 characters 35 | WARNING | Line exceeds 80 characters; contains 82 characters 44 | WARNING | Line exceeds 80 characters; contains 119 characters 64 | WARNING | Line exceeds 80 characters; contains 119 characters ---------------------------------------------------------------------- FILE: ...omponents-3372800/components/organisms/heroslider/heroslider.css ---------------------------------------------------------------------- FOUND 37 ERRORS AFFECTING 20 LINES ---------------------------------------------------------------------- 13 | ERROR | [x] Multiple selectors should each be on a single line 18 | ERROR | [x] Multiple selectors should each be on a single line 87 | ERROR | [x] Multiple selectors should each be on a single line 87 | ERROR | [x] Multiple selectors should each be on a single line 93 | ERROR | [x] Multiple selectors should each be on a single line 93 | ERROR | [x] Multiple selectors should each be on a single line 99 | ERROR | [x] Multiple selectors should each be on a single line 99 | ERROR | [x] Multiple selectors should each be on a single line 106 | ERROR | [x] Multiple selectors should each be on a single line 106 | ERROR | [x] Multiple selectors should each be on a single line 112 | ERROR | [x] Multiple selectors should each be on a single line 112 | ERROR | [x] Multiple selectors should each be on a single line 117 | ERROR | [x] Multiple selectors should each be on a single line 124 | ERROR | [x] Multiple selectors should each be on a single line 124 | ERROR | [x] Multiple selectors should each be on a single line 124 | ERROR | [x] Multiple selectors should each be on a single line 130 | ERROR | [x] Multiple selectors should each be on a single line 130 | ERROR | [x] Multiple selectors should each be on a single line 130 | ERROR | [x] Multiple selectors should each be on a single line 134 | ERROR | [x] Multiple selectors should each be on a single line 134 | ERROR | [x] Multiple selectors should each be on a single line 134 | ERROR | [x] Multiple selectors should each be on a single line 138 | ERROR | [x] Multiple selectors should each be on a single line 138 | ERROR | [x] Multiple selectors should each be on a single line 138 | ERROR | [x] Multiple selectors should each be on a single line 142 | ERROR | [x] Multiple selectors should each be on a single line 142 | ERROR | [x] Multiple selectors should each be on a single line 142 | ERROR | [x] Multiple selectors should each be on a single line 146 | ERROR | [x] Multiple selectors should each be on a single line 146 | ERROR | [x] Multiple selectors should each be on a single line 146 | ERROR | [x] Multiple selectors should each be on a single line 151 | ERROR | [x] Multiple selectors should each be on a single line 159 | ERROR | [x] Multiple selectors should each be on a single line 167 | ERROR | [x] Multiple selectors should each be on a single line 171 | ERROR | [x] Multiple selectors should each be on a single line 262 | ERROR | [x] Expected 1 newline at end of file; 2 found 263 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 37 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...s-3372800/components/organisms/card-impressed/card-impressed.css ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 125 | ERROR | [x] Expected 1 newline at end of file; 2 found 126 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...nents-3372800/components/organisms/card-overlay/card-overlay.css ---------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------- 24 | ERROR | [x] Multiple selectors should each be on a single line 24 | ERROR | [x] Multiple selectors should each be on a single line 125 | ERROR | [x] Expected 1 newline at end of file; 2 found 126 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ..._components-3372800/components/organisms/card-hero/card-hero.css ---------------------------------------------------------------------- FOUND 38 ERRORS AFFECTING 38 LINES ---------------------------------------------------------------------- 251 | ERROR | [x] Multiple selectors should each be on a single line 257 | ERROR | [x] Multiple selectors should each be on a single line 263 | ERROR | [x] Multiple selectors should each be on a single line 269 | ERROR | [x] Multiple selectors should each be on a single line 275 | ERROR | [x] Multiple selectors should each be on a single line 281 | ERROR | [x] Multiple selectors should each be on a single line 287 | ERROR | [x] Multiple selectors should each be on a single line 294 | ERROR | [x] Multiple selectors should each be on a single line 300 | ERROR | [x] Multiple selectors should each be on a single line 305 | ERROR | [x] Multiple selectors should each be on a single line 313 | ERROR | [x] Multiple selectors should each be on a single line 318 | ERROR | [x] Multiple selectors should each be on a single line 324 | ERROR | [x] Multiple selectors should each be on a single line 329 | ERROR | [x] Multiple selectors should each be on a single line 336 | ERROR | [x] Multiple selectors should each be on a single line 340 | ERROR | [x] Multiple selectors should each be on a single line 345 | ERROR | [x] Multiple selectors should each be on a single line 350 | ERROR | [x] Multiple selectors should each be on a single line 357 | ERROR | [x] Multiple selectors should each be on a single line 361 | ERROR | [x] Multiple selectors should each be on a single line 365 | ERROR | [x] Multiple selectors should each be on a single line 370 | ERROR | [x] Multiple selectors should each be on a single line 374 | ERROR | [x] Multiple selectors should each be on a single line 379 | ERROR | [x] Multiple selectors should each be on a single line 384 | ERROR | [x] Multiple selectors should each be on a single line 390 | ERROR | [x] Multiple selectors should each be on a single line 395 | ERROR | [x] Multiple selectors should each be on a single line 403 | ERROR | [x] Multiple selectors should each be on a single line 408 | ERROR | [x] Multiple selectors should each be on a single line 413 | ERROR | [x] Multiple selectors should each be on a single line 419 | ERROR | [x] Multiple selectors should each be on a single line 427 | ERROR | [x] Multiple selectors should each be on a single line 432 | ERROR | [x] Multiple selectors should each be on a single line 437 | ERROR | [x] Multiple selectors should each be on a single line 445 | ERROR | [x] Multiple selectors should each be on a single line 450 | ERROR | [x] Multiple selectors should each be on a single line 454 | ERROR | [x] Expected 1 newline at end of file; 2 found 455 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 38 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...arbase_components-3372800/components/organisms/navbar/navbar.css ---------------------------------------------------------------------- FOUND 12 ERRORS AFFECTING 6 LINES ---------------------------------------------------------------------- 16 | ERROR | [x] Multiple selectors should each be on a single line 16 | ERROR | [x] Multiple selectors should each be on a single line 20 | ERROR | [x] Multiple selectors should each be on a single line 20 | ERROR | [x] Multiple selectors should each be on a single line 31 | ERROR | [x] Multiple selectors should each be on a single line 31 | ERROR | [x] Multiple selectors should each be on a single line 35 | ERROR | [x] Multiple selectors should each be on a single line 35 | ERROR | [x] Multiple selectors should each be on a single line 58 | ERROR | [x] Multiple selectors should each be on a single line 58 | ERROR | [x] Multiple selectors should each be on a single line 62 | ERROR | [x] Multiple selectors should each be on a single line 62 | ERROR | [x] Multiple selectors should each be on a single line ---------------------------------------------------------------------- PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...nents-3372800/components/organisms/media-header/media-header.css ---------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------- 76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, | | found 5 144 | ERROR | [x] Expected 1 newline at end of file; 2 found 145 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...e_components-3372800/components/organisms/media-header/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------- 8 | WARNING | Line exceeds 80 characters; contains 146 characters ---------------------------------------------------------------------- FILE: ...ponents-3372800/components/organisms/page-footer/page-footer.css ---------------------------------------------------------------------- FOUND 16 ERRORS AFFECTING 8 LINES ---------------------------------------------------------------------- 11 | ERROR | [x] Multiple selectors should each be on a single line 11 | ERROR | [x] Multiple selectors should each be on a single line 20 | ERROR | [x] Multiple selectors should each be on a single line 20 | ERROR | [x] Multiple selectors should each be on a single line 37 | ERROR | [x] Multiple selectors should each be on a single line 37 | ERROR | [x] Multiple selectors should each be on a single line 41 | ERROR | [x] Multiple selectors should each be on a single line 41 | ERROR | [x] Multiple selectors should each be on a single line 52 | ERROR | [x] Multiple selectors should each be on a single line 52 | ERROR | [x] Multiple selectors should each be on a single line 56 | ERROR | [x] Multiple selectors should each be on a single line 56 | ERROR | [x] Multiple selectors should each be on a single line 95 | ERROR | [x] Multiple selectors should each be on a single line 95 | ERROR | [x] Multiple selectors should each be on a single line 100 | ERROR | [x] Multiple selectors should each be on a single line 100 | ERROR | [x] Multiple selectors should each be on a single line ---------------------------------------------------------------------- PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...800/components/organisms/media-hero-slider/media-hero-slider.css ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 36 | ERROR | [x] Expected 1 newline at end of file; 2 found 37 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ..._components-3372800/components/organisms/card-text/card-text.css ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 113 | ERROR | [x] Expected 1 newline at end of file; 2 found 114 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...base_components-3372800/components/organisms/card-text/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------- 11 | WARNING | Line exceeds 80 characters; contains 92 characters 13 | WARNING | Line exceeds 80 characters; contains 110 characters 14 | WARNING | Line exceeds 80 characters; contains 93 characters 25 | WARNING | Line exceeds 80 characters; contains 196 characters ---------------------------------------------------------------------- FILE: ...nts-3372800/components/organisms/card-featured/card-featured.css ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 98 | ERROR | [x] Expected 1 newline at end of file; 2 found 99 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...ustom/varbase_components-3372800/components/atoms/link/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES ---------------------------------------------------------------------- 16 | WARNING | Line exceeds 80 characters; contains 84 characters 19 | WARNING | Line exceeds 80 characters; contains 84 characters 20 | WARNING | Line exceeds 80 characters; contains 84 characters 23 | WARNING | Line exceeds 80 characters; contains 85 characters 25 | WARNING | Line exceeds 80 characters; contains 89 characters 26 | WARNING | Line exceeds 80 characters; contains 87 characters 28 | WARNING | Line exceeds 80 characters; contains 89 characters 29 | WARNING | Line exceeds 80 characters; contains 88 characters ---------------------------------------------------------------------- FILE: ...ustom/varbase_components-3372800/components/atoms/icon/README.md ---------------------------------------------------------------------- FOUND 1 ERROR AND 7 WARNINGS AFFECTING 8 LINES ---------------------------------------------------------------------- 8 | WARNING | [ ] Line exceeds 80 characters; contains 103 | | characters 9 | WARNING | [ ] Line exceeds 80 characters; contains 105 | | characters 10 | WARNING | [ ] Line exceeds 80 characters; contains 129 | | characters 12 | WARNING | [ ] Line exceeds 80 characters; contains 83 | | characters 34 | WARNING | [ ] Line exceeds 80 characters; contains 121 | | characters 38 | WARNING | [ ] Line exceeds 80 characters; contains 96 | | characters 45 | WARNING | [ ] Line exceeds 80 characters; contains 100 | | characters 46 | ERROR | [x] Expected 1 newline at end of file; 2 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...omponents-3372800/components/atoms/progress-bar/progress-bar.css ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 131 | ERROR | [x] Expected 1 newline at end of file; 2 found 132 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...ase_components-3372800/components/atoms/accordion-item/README.md ---------------------------------------------------------------------- FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------- 36 | WARNING | [ ] Line exceeds 80 characters; contains 107 | | characters 56 | WARNING | [ ] Line exceeds 80 characters; contains 139 | | characters 72 | WARNING | [ ] Line exceeds 80 characters; contains 139 | | characters 82 | WARNING | [ ] Line exceeds 80 characters; contains 139 | | characters 103 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...nents-3372800/components/atoms/accordion-item/accordion-item.css ---------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------- 157 | ERROR | [x] Multiple selectors should each be on a single line 192 | ERROR | [x] Multiple selectors should each be on a single line 192 | ERROR | [x] Multiple selectors should each be on a single line 195 | ERROR | [x] Expected 1 newline at end of file; 2 found 196 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- FILE: ...arbase_components-3372800/components/atoms/taxonomy/taxonomy.css ---------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------- 90 | ERROR | [x] Expected 1 newline at end of file; 2 found 91 | ERROR | [x] Additional whitespace found at end of file ---------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------- Time: 318ms; Memory: 14MB
- Status changed to Needs review
11 months ago 10:32am 10 July 2024 - 🇮🇳India kalash-j jaipur
I have solved the phpcs errors, raised when rebasing the branch.
- Status changed to Needs work
11 months ago 5:26pm 16 July 2024 - 🇵🇭Philippines roberttabigue
Hi,
I am moving this to 'Needs work', please check the PHPCS issues below after applying the 'MR !14' to the Varbase Components module against 2.0.x-dev on my D10 local.
Please run this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig varbase_components/
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/varbase_components/components/atoms/accordion-item/accordion-item.twig ------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------- 141 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/varbase_components/components/organisms/heroslider/heroslider.twig --------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------------- 167 | ERROR | [x] Expected 1 newline at end of file; 0 found --------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/varbase_components/components/organisms/media-header/media-header.twig ------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------- 46 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/varbase_components/components/organisms/card-hero/card-hero.twig ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------- 197 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------
Please check.
Thank you! - Status changed to Needs review
11 months ago 10:12am 22 July 2024 - 🇮🇳India chandansha
I HAVE fixed remaining warnings.
Kindly review again.
Thanks!! - 🇮🇳India bhaveshdas
I applied MR!14 and I still encountered some issues after I ran vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig modules/custom/varbase_components-3372800/
FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/dom/manipulator.js --------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line --------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/dom/data.js -------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/dom/event-handler.js ----------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line ----------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/dom/selector-engine.js ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/button.js ------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------ 10 | ERROR | [x] Opening brace must be the last content on the line ------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/modal.js ----------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line ----------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/tooltip.js ------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line ------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/scrollspy.js --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line --------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/carousel.js -------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/toast.js ----------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line ----------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/backdrop.js ------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/component-functions.js ------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------ 10 | ERROR | [x] Opening brace must be the last content on the line ------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/focustrap.js -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/config.js ----------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line ----------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/sanitizer.js -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/scrollbar.js -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/index.js ---------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/swipe.js ---------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/util/template-factory.js --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/alert.js ----------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line ----------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/tab.js --------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line --------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/popover.js ------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line ------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/collapse.js -------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/dropdown.js -------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line 290 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket 293 | ERROR | [x] Multi-line function declaration not indented correctly; expected 6 spaces but found 4 293 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter 293 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line -------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/offcanvas.js --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line --------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/bootstrap/base-component.js -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Opening brace must be the last content on the line -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/drupal-contri-d10/modules/custom/varbase_components-3372800/js/popperjs/popper.js ----------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Opening brace must be the last content on the line ----------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------- Time: 1.06 secs; Memory: 32MB
- 🇮🇳India bhaveshdas
Hey , I have fixed remaining phpcs issues.
Could you please review it.Thankyou !!
- Status changed to RTBC
11 months ago 5:15pm 22 July 2024 - 🇵🇭Philippines roberttabigue
Hi @bhaveshads,
I have applied the latest MR !14 again to the Varbase Components module against 2.0.x-dev on my D10 local, and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig varbase_components/
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
- Issue was unassigned.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → changed the visibility of the branch 3372800-phpcs to hidden.
- Merge request !18Create a new merge request to get the list of the PHP_CodeSniffer errors/warnings to fix → (Open) created by apaderno
- 🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → changed the visibility of the branch 3372800-gitlab-ci-reports to hidden.
- Status changed to Needs work
9 months ago 9:45am 29 August 2024 - 🇮🇳India sourav_paul Kolkata
I've applied the MR !14 & it's applied successfully..
Attaching SS & message:
sourav@sourav-Mi-Notebook-Pro:~/projects/my_site/web/modules/contrib/varbase_components$ curl https://git.drupalcode.org/project/varbase_components/-/merge_requests/14.diff | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 266k 0 266k 0 0 340k 0 --:--:-- --:--:-- --:--:-- 340k <stdin>:521: trailing whitespace. {% include 'varbase_components:icon' with <stdin>:527: trailing whitespace. {% include 'varbase_components:icon' with <stdin>:536: trailing whitespace. {% include 'varbase_components:icon' with <stdin>:2427: trailing whitespace. * `media_position`: Choose the location of the media from <stdin>:2429: trailing whitespace. * `id`: Set a unique id on the heroslider for optional controls, especially Checking patch .gitlab-ci.yml... Checking patch components/atoms/README.md... Checking patch components/atoms/accordion-item/README.md... Checking patch components/atoms/accordion-item/accordion-item.css... Checking patch components/atoms/accordion-item/accordion-item.twig... Checking patch components/atoms/badge/README.md... Checking patch components/atoms/button/README.md... Checking patch components/atoms/close-button/README.md... Checking patch components/atoms/close-button/close-button.twig... Checking patch components/atoms/column/column.twig... Checking patch components/atoms/container/README.md... Checking patch components/atoms/heading/README.md... Checking patch components/atoms/icon/README.md... Checking patch components/atoms/image/README.md... Checking patch components/atoms/input/README.md... Checking patch components/atoms/link/README.md... Checking patch components/atoms/progress-bar/README.md... Checking patch components/atoms/progress-bar/progress-bar.css... Checking patch components/atoms/progress-bar/progress-bar.twig... Checking patch components/atoms/spinner/README.md... Checking patch components/atoms/taxonomy/taxonomy.css... Checking patch components/atoms/text/text.twig... Checking patch components/atoms/textarea/README.md... Checking patch components/molecules/README.md... Checking patch components/molecules/accordion/README.md... Checking patch components/molecules/accordion/accordion.js... Checking patch components/molecules/alert/README.md... Checking patch components/molecules/alert/alert.css... Checking patch components/molecules/breadcrumb/README.md... Checking patch components/molecules/breadcrumb/breadcrumb.css... Checking patch components/molecules/dynamic-responsive-image/README.md... Checking patch components/molecules/field-tags/README.md... Checking patch components/molecules/field-tags/field-tags.css... Checking patch components/molecules/input-checkbox/README.md... Checking patch components/molecules/input-checkbox/input-checkbox.component.yml... Checking patch components/molecules/input-color/README.md... Checking patch components/molecules/navbar-brand/navbar-brand.css... Checking patch components/molecules/navbar-brand/navbar-brand.twig... Checking patch components/molecules/page-title/README.md... Checking patch components/molecules/pagination/README.md... Checking patch components/molecules/pagination/pagination.css... Checking patch components/molecules/tabs/tabs.css... Checking patch components/organisms/README.md... Checking patch components/organisms/block-cta/block-cta.css... Checking patch components/organisms/block-cta/block-cta.twig... Checking patch components/organisms/block-heading/README.md... Checking patch components/organisms/block-local-video/block-local-video.css... Checking patch components/organisms/block-local-video/block-local-video.twig... Checking patch components/organisms/block-remote-video/block-remote-video.css... Checking patch components/organisms/block-remote-video/block-remote-video.twig... Checking patch components/organisms/block-rich-text/block-rich-text.twig... Checking patch components/organisms/card-featured/README.md... Checking patch components/organisms/card-featured/card-featured.css... Checking patch components/organisms/card-hero/README.md... Checking patch components/organisms/card-hero/card-hero.css... Checking patch components/organisms/card-hero/card-hero.twig... Checking patch components/organisms/card-impressed/README.md... Checking patch components/organisms/card-impressed/card-impressed.css... Checking patch components/organisms/card-overlay/README.md... Checking patch components/organisms/card-overlay/card-overlay.css... Checking patch components/organisms/card-text/README.md... Checking patch components/organisms/card-text/card-text.css... Checking patch components/organisms/carousel/README.md... Checking patch components/organisms/form-element-radiocheckbox/README.md... Checking patch components/organisms/form-element/README.md... Checking patch components/organisms/form/README.md... Checking patch components/organisms/heroslider/README.md... Checking patch components/organisms/heroslider/heroslider.css... Checking patch components/organisms/heroslider/heroslider.js... Checking patch components/organisms/heroslider/heroslider.twig... Checking patch components/organisms/heroslider/js/oembed-frame.heroslider.vimeo.js... Checking patch components/organisms/heroslider/js/oembed-frame.heroslider.youtube.js... Checking patch components/organisms/heroslider/js/video.heroslider.local.js... Checking patch components/organisms/heroslider/js/video.heroslider.vimeo.js... Checking patch components/organisms/heroslider/js/video.heroslider.youtube.js... Checking patch components/organisms/links-dropbutton/README.md... Checking patch components/organisms/media-header/README.md... Checking patch components/organisms/media-header/media-header.css... Checking patch components/organisms/media-header/media-header.twig... Checking patch components/organisms/media-hero-slide/README.md... Checking patch components/organisms/media-hero-slide/media-hero-slide.css... Checking patch components/organisms/media-hero-slider/README.md... Checking patch components/organisms/media-hero-slider/media-hero-slider.css... Checking patch components/organisms/media-hero-slider/media-hero-slider.twig... Checking patch components/organisms/media/README.md... Checking patch components/organisms/nav/nav.css... Checking patch components/organisms/navbar/README.md... Checking patch components/organisms/navbar/navbar.css... Checking patch components/organisms/node/README.md... Checking patch components/organisms/page-better-login/page-better-login.css... Checking patch components/organisms/page-better-login/page-better-login.twig... Checking patch components/organisms/page-footer/README.md... Checking patch components/organisms/page-footer/page-footer.css... Checking patch components/organisms/page-footer/page-footer.twig... Checking patch components/organisms/page-header/README.md... Checking patch components/organisms/page-header/page-header.twig... Checking patch components/organisms/region/README.md... Checking patch components/organisms/social-auth/social-auth.css... Checking patch components/organisms/social-auth/social-auth.twig... Checking patch components/organisms/table/README.md... Checking patch components/organisms/table/table.twig... Checking patch components/organisms/user/user.twig... Checking patch components/organisms/views-view-table/README.md... Checking patch components/organisms/views-view-unformatted/README.md... Checking patch components/organisms/views-view/README.md... Checking patch components/pages/page/page.css... Checking patch components/templates/README.md... Checking patch js/bootstrap/alert.js... Checking patch js/bootstrap/base-component.js... Checking patch js/bootstrap/button.js... Checking patch js/bootstrap/carousel.js... Checking patch js/bootstrap/collapse.js... Checking patch js/bootstrap/dom/data.js... Checking patch js/bootstrap/dom/event-handler.js... Checking patch js/bootstrap/dom/manipulator.js... Checking patch js/bootstrap/dom/selector-engine.js... Checking patch js/bootstrap/dropdown.js... Checking patch js/bootstrap/modal.js... Checking patch js/bootstrap/offcanvas.js... Checking patch js/bootstrap/popover.js... Checking patch js/bootstrap/scrollspy.js... Checking patch js/bootstrap/tab.js... Checking patch js/bootstrap/toast.js... Checking patch js/bootstrap/tooltip.js... Checking patch js/bootstrap/util/backdrop.js... Checking patch js/bootstrap/util/component-functions.js... Checking patch js/bootstrap/util/config.js... Checking patch js/bootstrap/util/focustrap.js... Checking patch js/bootstrap/util/index.js... Checking patch js/bootstrap/util/sanitizer.js... Checking patch js/bootstrap/util/scrollbar.js... Checking patch js/bootstrap/util/swipe.js... Checking patch js/bootstrap/util/template-factory.js... Checking patch js/popperjs/popper.js... Checking patch varbase_components.install... Checking patch webpack.config.build.js... Checking patch webpack.config.init.js... Checking patch webpack.config.js... Hunk #1 succeeded at 42 (offset 2 lines). Hunk #2 succeeded at 59 (offset 2 lines). Hunk #3 succeeded at 91 (offset 2 lines). Hunk #4 succeeded at 109 (offset 2 lines). Hunk #5 succeeded at 133 (offset 2 lines). Hunk #6 succeeded at 177 (offset 2 lines). Applied patch .gitlab-ci.yml cleanly. Applied patch components/atoms/README.md cleanly. Applied patch components/atoms/accordion-item/README.md cleanly. Applied patch components/atoms/accordion-item/accordion-item.css cleanly. Applied patch components/atoms/accordion-item/accordion-item.twig cleanly. Applied patch components/atoms/badge/README.md cleanly. Applied patch components/atoms/button/README.md cleanly. Applied patch components/atoms/close-button/README.md cleanly. Applied patch components/atoms/close-button/close-button.twig cleanly. Applied patch components/atoms/column/column.twig cleanly. Applied patch components/atoms/container/README.md cleanly. Applied patch components/atoms/heading/README.md cleanly. Applied patch components/atoms/icon/README.md cleanly. Applied patch components/atoms/image/README.md cleanly. Applied patch components/atoms/input/README.md cleanly. Applied patch components/atoms/link/README.md cleanly. Applied patch components/atoms/progress-bar/README.md cleanly. Applied patch components/atoms/progress-bar/progress-bar.css cleanly. Applied patch components/atoms/progress-bar/progress-bar.twig cleanly. Applied patch components/atoms/spinner/README.md cleanly. Applied patch components/atoms/taxonomy/taxonomy.css cleanly. Applied patch components/atoms/text/text.twig cleanly. Applied patch components/atoms/textarea/README.md cleanly. Applied patch components/molecules/README.md cleanly. Applied patch components/molecules/accordion/README.md cleanly. Applied patch components/molecules/accordion/accordion.js cleanly. Applied patch components/molecules/alert/README.md cleanly. Applied patch components/molecules/alert/alert.css cleanly. Applied patch components/molecules/breadcrumb/README.md cleanly. Applied patch components/molecules/breadcrumb/breadcrumb.css cleanly. Applied patch components/molecules/dynamic-responsive-image/README.md cleanly. Applied patch components/molecules/field-tags/README.md cleanly. Applied patch components/molecules/field-tags/field-tags.css cleanly. Applied patch components/molecules/input-checkbox/README.md cleanly. Applied patch components/molecules/input-checkbox/input-checkbox.component.yml cleanly. Applied patch components/molecules/input-color/README.md cleanly. Applied patch components/molecules/navbar-brand/navbar-brand.css cleanly. Applied patch components/molecules/navbar-brand/navbar-brand.twig cleanly. Applied patch components/molecules/page-title/README.md cleanly. Applied patch components/molecules/pagination/README.md cleanly. Applied patch components/molecules/pagination/pagination.css cleanly. Applied patch components/molecules/tabs/tabs.css cleanly. Applied patch components/organisms/README.md cleanly. Applied patch components/organisms/block-cta/block-cta.css cleanly. Applied patch components/organisms/block-cta/block-cta.twig cleanly. Applied patch components/organisms/block-heading/README.md cleanly. Applied patch components/organisms/block-local-video/block-local-video.css cleanly. Applied patch components/organisms/block-local-video/block-local-video.twig cleanly. Applied patch components/organisms/block-remote-video/block-remote-video.css cleanly. Applied patch components/organisms/block-remote-video/block-remote-video.twig cleanly. Applied patch components/organisms/block-rich-text/block-rich-text.twig cleanly. Applied patch components/organisms/card-featured/README.md cleanly. Applied patch components/organisms/card-featured/card-featured.css cleanly. Applied patch components/organisms/card-hero/README.md cleanly. Applied patch components/organisms/card-hero/card-hero.css cleanly. Applied patch components/organisms/card-hero/card-hero.twig cleanly. Applied patch components/organisms/card-impressed/README.md cleanly. Applied patch components/organisms/card-impressed/card-impressed.css cleanly. Applied patch components/organisms/card-overlay/README.md cleanly. Applied patch components/organisms/card-overlay/card-overlay.css cleanly. Applied patch components/organisms/card-text/README.md cleanly. Applied patch components/organisms/card-text/card-text.css cleanly. Applied patch components/organisms/carousel/README.md cleanly. Applied patch components/organisms/form-element-radiocheckbox/README.md cleanly. Applied patch components/organisms/form-element/README.md cleanly. Applied patch components/organisms/form/README.md cleanly. Applied patch components/organisms/heroslider/README.md cleanly. Applied patch components/organisms/heroslider/heroslider.css cleanly. Applied patch components/organisms/heroslider/heroslider.js cleanly. Applied patch components/organisms/heroslider/heroslider.twig cleanly. Applied patch components/organisms/heroslider/js/oembed-frame.heroslider.vimeo.js cleanly. Applied patch components/organisms/heroslider/js/oembed-frame.heroslider.youtube.js cleanly. Applied patch components/organisms/heroslider/js/video.heroslider.local.js cleanly. Applied patch components/organisms/heroslider/js/video.heroslider.vimeo.js cleanly. Applied patch components/organisms/heroslider/js/video.heroslider.youtube.js cleanly. Applied patch components/organisms/links-dropbutton/README.md cleanly. Applied patch components/organisms/media-header/README.md cleanly. Applied patch components/organisms/media-header/media-header.css cleanly. Applied patch components/organisms/media-header/media-header.twig cleanly. Applied patch components/organisms/media-hero-slide/README.md cleanly. Applied patch components/organisms/media-hero-slide/media-hero-slide.css cleanly. Applied patch components/organisms/media-hero-slider/README.md cleanly. Applied patch components/organisms/media-hero-slider/media-hero-slider.css cleanly. Applied patch components/organisms/media-hero-slider/media-hero-slider.twig cleanly. Applied patch components/organisms/media/README.md cleanly. Applied patch components/organisms/nav/nav.css cleanly. Applied patch components/organisms/navbar/README.md cleanly. Applied patch components/organisms/navbar/navbar.css cleanly. Applied patch components/organisms/node/README.md cleanly. Applied patch components/organisms/page-better-login/page-better-login.css cleanly. Applied patch components/organisms/page-better-login/page-better-login.twig cleanly. Applied patch components/organisms/page-footer/README.md cleanly. Applied patch components/organisms/page-footer/page-footer.css cleanly. Applied patch components/organisms/page-footer/page-footer.twig cleanly. Applied patch components/organisms/page-header/README.md cleanly. Applied patch components/organisms/page-header/page-header.twig cleanly. Applied patch components/organisms/region/README.md cleanly. Applied patch components/organisms/social-auth/social-auth.css cleanly. Applied patch components/organisms/social-auth/social-auth.twig cleanly. Applied patch components/organisms/table/README.md cleanly. Applied patch components/organisms/table/table.twig cleanly. Applied patch components/organisms/user/user.twig cleanly. Applied patch components/organisms/views-view-table/README.md cleanly. Applied patch components/organisms/views-view-unformatted/README.md cleanly. Applied patch components/organisms/views-view/README.md cleanly. Applied patch components/pages/page/page.css cleanly. Applied patch components/templates/README.md cleanly. Applied patch js/bootstrap/alert.js cleanly. Applied patch js/bootstrap/base-component.js cleanly. Applied patch js/bootstrap/button.js cleanly. Applied patch js/bootstrap/carousel.js cleanly. Applied patch js/bootstrap/collapse.js cleanly. Applied patch js/bootstrap/dom/data.js cleanly. Applied patch js/bootstrap/dom/event-handler.js cleanly. Applied patch js/bootstrap/dom/manipulator.js cleanly. Applied patch js/bootstrap/dom/selector-engine.js cleanly. Applied patch js/bootstrap/dropdown.js cleanly. Applied patch js/bootstrap/modal.js cleanly. Applied patch js/bootstrap/offcanvas.js cleanly. Applied patch js/bootstrap/popover.js cleanly. Applied patch js/bootstrap/scrollspy.js cleanly. Applied patch js/bootstrap/tab.js cleanly. Applied patch js/bootstrap/toast.js cleanly. Applied patch js/bootstrap/tooltip.js cleanly. Applied patch js/bootstrap/util/backdrop.js cleanly. Applied patch js/bootstrap/util/component-functions.js cleanly. Applied patch js/bootstrap/util/config.js cleanly. Applied patch js/bootstrap/util/focustrap.js cleanly. Applied patch js/bootstrap/util/index.js cleanly. Applied patch js/bootstrap/util/sanitizer.js cleanly. Applied patch js/bootstrap/util/scrollbar.js cleanly. Applied patch js/bootstrap/util/swipe.js cleanly. Applied patch js/bootstrap/util/template-factory.js cleanly. Applied patch js/popperjs/popper.js cleanly. Applied patch varbase_components.install cleanly. Applied patch webpack.config.build.js cleanly. Applied patch webpack.config.init.js cleanly. Applied patch webpack.config.js cleanly. warning: squelched 2 whitespace errors warning: 7 lines add whitespace errors.
Even after applying MR there are some warnings reported by PHPCS
sourav@sourav-Mi-Notebook-Pro:~/projects/my_site/web/modules/contrib$ ../../../vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig varbase_components/ FILE: /home/sourav/projects/my_site/web/modules/contrib/varbase_components/components/base/root/README.md --------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES --------------------------------------------------------------------------------------------------------- 6 | WARNING | Line exceeds 80 characters; contains 208 characters 15 | WARNING | Line exceeds 80 characters; contains 293 characters 18 | WARNING | Line exceeds 80 characters; contains 151 characters 20 | WARNING | Line exceeds 80 characters; contains 109 characters --------------------------------------------------------------------------------------------------------- FILE: /home/sourav/projects/my_site/web/modules/contrib/varbase_components/components/base/root/root.css -------------------------------------------------------------------------------------------------------- FOUND 12 ERRORS AFFECTING 12 LINES -------------------------------------------------------------------------------------------------------- 17 | ERROR | [ ] Style definitions must end with a semicolon 18 | ERROR | [ ] Style definitions must end with a semicolon 19 | ERROR | [ ] Style definitions must end with a semicolon 20 | ERROR | [ ] Style definitions must end with a semicolon 21 | ERROR | [ ] Style definitions must end with a semicolon 22 | ERROR | [ ] Style definitions must end with a semicolon 23 | ERROR | [ ] Style definitions must end with a semicolon 24 | ERROR | [ ] Style definitions must end with a semicolon 25 | ERROR | [ ] Style definitions must end with a semicolon 108 | ERROR | [ ] Style definitions must end with a semicolon 177 | ERROR | [x] Expected 1 newline at end of file; 2 found 178 | ERROR | [x] Additional whitespace found at end of file -------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------- FILE: /home/sourav/projects/my_site/web/modules/contrib/varbase_components/components/molecules/callout/README.md ----------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES ----------------------------------------------------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 100 characters 9 | WARNING | Line exceeds 80 characters; contains 130 characters 10 | WARNING | Line exceeds 80 characters; contains 138 characters 24 | WARNING | Line exceeds 80 characters; contains 81 characters 32 | WARNING | Line exceeds 80 characters; contains 89 characters 40 | WARNING | Line exceeds 80 characters; contains 91 characters 48 | WARNING | Line exceeds 80 characters; contains 90 characters ----------------------------------------------------------------------------------------------------------------- FILE: /home/sourav/projects/my_site/web/modules/contrib/varbase_components/components/molecules/callout/callout.css ------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------- 71 | ERROR | [x] Expected 1 newline at end of file; 2 found 72 | ERROR | [x] Additional whitespace found at end of file ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /home/sourav/projects/my_site/web/modules/contrib/varbase_components/varbase_components.module ---------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------- 71 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found 72 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found 79 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found 80 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found 82 | WARNING | [ ] Unused variable $menu_index. ---------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------- Time: 267ms; Memory: 16MB
Hence moving it to "Needs work" state
Please fix the remaining issues.