- Issue created by @dieterholvoet
- Assigned to sourabhsisodia_
@DieterHolvoet I think the above error is due to this - https://www.drupal.org/project/drupal/issues/3396099 🐛 The core/drupal.message library requires a status_messages render element Active , after the mentioned core issue get resolved , we can make a js function that show status messages as a toast
- Status changed to Needs review
5 months ago 12:38pm 2 July 2024 - 🇱🇹Lithuania arpas
The patch overwrites
Drupal.theme.message
and lets to toastify messages added using ajax MessageCommand.Mentioned Drupal core patch https://www.drupal.org/project/drupal/issues/3396099 🐛 The core/drupal.message library requires a status_messages render element Active must be applied.
Other changes in patch:
- configurable options to exclude toastify messages for admin pages and for path list.
- possibility to set unlimited duration (-1)
- configurable message text color
- 🇧🇪Belgium dieterholvoet Brussels
Thanks for your contribution! For future reference and easier reviews, I think it would be better to separate the admin exclusion and text color features into separate issues though. ✨ Add the option to disable for admin routes Needs work has been open for a while, so that one doesn't have to be created.
- Status changed to Needs work
5 months ago 2:36pm 2 July 2024 - 🇧🇪Belgium dieterholvoet Brussels
Let's also work in MR's instead of patches. Would be great if you could find the time to split up the issue and move to MR's, if not I'll try to get to it soon.
- Merge request !15Issue #3445290: Created a function that override message theme function and... → (Merged) created by sourabhsisodia_
- Issue was unassigned.
- Status changed to Needs review
5 months ago 5:18pm 7 July 2024 - Status changed to RTBC
5 months ago 6:44am 10 July 2024 - 🇮🇳India kalash-j jaipur
i have reviewed the MR!15 on D 10.3.1 after applying this 🐛 The core/drupal.message library requires a status_messages render element Active patch
and it is working fine
RTBC +1 -
dieterholvoet →
committed a7aa1a3a on 8.x-1.x
Merge branch '3445290-module-breaks-status' into '8.x-1.x' Issue #...
-
dieterholvoet →
committed a7aa1a3a on 8.x-1.x
-
dieterholvoet →
committed 1b69e1f4 on 8.x-1.x authored by
sourabhsisodia_ →
Issue #3445290 by sourabhsisodia_, arpas, kalash-j, dieterholvoet:...
-
dieterholvoet →
committed 1b69e1f4 on 8.x-1.x authored by
sourabhsisodia_ →
- Status changed to Fixed
3 months ago 4:12pm 3 September 2024 Hi @dieterholvoet
Thanks for merging the MR.I noticed that I wasn't credited for resolving this issue. I'm not sure why that happened. Is there something I'm missing?
- 🇧🇪Belgium dieterholvoet Brussels
You did get credited, you can see your username in the commit message.
Automatically closed - issue fixed for 2 weeks with no activity.