- Issue created by @john pitcairn
- Status changed to Needs review
over 1 year ago 7:36am 18 September 2023 - Status changed to Needs work
over 1 year ago 9:04am 19 September 2023 - 🇧🇪Belgium dieterholvoet Brussels
I think it would be better/more flexible to create a setting named 'Enable for' with two checkboxes, 'Admin theme' and 'Frontend theme'. This way the module can also be used only in the admin theme. The two checkboxes should be enabled by default for both new and existing installations, to preserve backwards compatibility.
- 🇳🇿New Zealand john pitcairn
Or even add a checkbox to each individual theme's settings. Maybe that's a followup ;-)
- First commit to issue fork.
- Assigned to sourabhsisodia_
- Merge request !17Issue #3387703: Add the option to enable/disable toastify for admin and frontend theme. → (Merged) created by sourabhsisodia_
- 🇮🇳India Tirupati_Singh
Hi, I've applied the provided MR as a patch and it applied cleanly without any errors. After applying the patch, a new configuration field 'Enable for' has been provided to Enable/Disable the module functionality for the Admin Theme or Frontend Theme. When the Admin Theme option is unchecked then the messaging shown is unaltered. The provided new field functionality is working fine. I'm attaching the screenshots of the before and after fixes for reference and moving the issue to RTBC.
Thanks!
-
dieterholvoet →
committed c379fd50 on 8.x-1.x
Merge branch '3387703-add-the-option' into '8.x-1.x' Issue #3387703:...
-
dieterholvoet →
committed c379fd50 on 8.x-1.x
-
dieterholvoet →
committed 9e7aecae on 8.x-1.x authored by
sourabhsisodia_ →
Issue #3387703 by sourabhsisodia_, dieterholvoet, keshavv,...
-
dieterholvoet →
committed 9e7aecae on 8.x-1.x authored by
sourabhsisodia_ →
Automatically closed - issue fixed for 2 weeks with no activity.