Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\admin_feedback\Controller\AdminFeedbackController->exportDbFeedback()

winstonjf → changed the visibility of the branch 3437584-deprecated-function-pregreplace to hidden.

The above MR is to ensure that null is not passed to the third argument of the preg_replace function.

winstonjf → changed the visibility of the branch 3437584-deprecated-function-pregreplace to active.

@immaculatexavier Thanks for the MR.

I have udated the MR and verified that the warning is no longer triggered. Needs review.

MR Updates: Replaced null with NULL, replaced if/else statement with ternary operator.

Thanks @Vivek Panicker

Updated the MR. Needs review.

I have tested this on my local and after applying the MR , it doesnt show any error msg.

Thanks for the work and the test.

Merged

Automatically closed - issue fixed for 2 weeks with no activity.