Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\admin_feedback\Controller\AdminFeedbackController->exportDbFeedback()

Issue created by @winstonjf
Merge request !6Fix: Avoid passing `null` to `preg_replace()` in the Feedback Controller → (Open) created by winstonjf
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
last update 7 months ago
1 pass
Comment 7 months ago →
winstonjf
winstonjf → changed the visibility of the branch 3437584-deprecated-function-pregreplace to hidden.
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
last update 7 months ago
1 pass
Status changed to Needs work 7 months ago12:56pm 2 April 2024
Comment 7 months ago →
🇮🇳India immaculatexavier
The above MR is to ensure that null is not passed to the third argument of the preg_replace function.
Comment 7 months ago →
winstonjf
winstonjf → changed the visibility of the branch 3437584-deprecated-function-pregreplace to active.
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
last update 7 months ago
1 pass
Comment 7 months ago →
🇮🇳India manish-31
@immaculatexavier Thanks for the MR.

I have udated the MR and verified that the warning is no longer triggered. Needs review.

MR Updates: Replaced null with NULL, replaced if/else statement with ternary operator.
Status changed to Needs review 7 months ago11:27am 3 April 2024
Comment 7 months ago →
🇮🇳India manish-31
Status changed to Needs work 7 months ago8:29am 4 April 2024
Comment 7 months ago →
🇮🇳India Vivek Panicker Kolkata
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
last update 7 months ago
1 pass
Status changed to Needs review 7 months ago10:20am 4 April 2024
Comment 7 months ago →
🇮🇳India manish-31
Thanks @Vivek Panicker

Updated the MR. Needs review.
Status changed to RTBC 4 months ago12:01pm 4 July 2024
Comment 4 months ago →
🇮🇳India kalash-j jaipur
I have tested this on my local and after applying the MR , it doesnt show any error msg.

Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\admin_feedback\Controller\AdminFeedbackController->exportDbFeedback()

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Merge Requests

!6Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\admin_feedback\Controller\AdminFeedbackController->exportDbFeedback()
Open

Comments & Activities

Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\admin_feedback\Controller\AdminFeedbackController->exportDbFeedback()

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Merge Requests

!6Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\admin_feedback\Controller\AdminFeedbackController->exportDbFeedback()Open

Comments & Activities

!6Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\admin_feedback\Controller\AdminFeedbackController->exportDbFeedback()
Open