- Issue created by @radheymkumar
- 🇮🇳India radheymkumar Jaipur, Rajasthan, India
I have attached patch file. review and apply patch file
Add README.md file is missing
- 🇮🇹Italy apaderno Brescia, 🇮🇹
- /** - * The renderer. - * - * @var \Drupal\Core\Render\Renderer - */
That is not commented out code. It is a documentation comment which should be kept.
The patch makes changes that are outside the scope defined from this issue, which is to removed commented out code, not to add type hinting to functions/methods.
Furthermore, since patches are no longer tested, a merge request should be provided.
- Issue was unassigned.
- Status changed to Needs work
3 months ago 11:57am 17 January 2025 - First commit to issue fork.
- 🇮🇳India somesh1999
I've removed the commented code and preserved the documented code.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Since patches are no longer tested, a merge request must be provided.
- Merge request !2removed commented code preserving the documentation comments → (Open) created by Unnamed author
- 🇮🇳India somesh1999
I've created the MR. Moreover, Since Drupal.org migrated to Gitlab, which renders the Markdown file as HTML, the README.txt file should be replaced by a README.md file
- 🇮🇳India koustav_mondal Kolkata
Changes are looks good to me.Hence moving to RTBC.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → changed the visibility of the branch 3483574-remove-commented-out to hidden.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
This issue is for removing commented out code. For adding a README.md file with all the required information, it is necessary to open a different issue.
- 🇮🇳India koustav_mondal Kolkata
Hello @avpaderno, yes it'll be better to create a separate issue for adding a README.md file. Now this MR looks good.