- Issue created by @Paulmicha
- 🇫🇷France Paulmicha Porto Alegre, RS, Brasil
Current workaround : cf. patch attached.
- Status changed to Postponed: needs info
over 1 year ago 11:59am 21 November 2023 - 🇬🇧United Kingdom adamps
I can't reproduce this. When sending as anonymous then there is a box to put your email address in. Perhaps you have disabled the field on your site?
- 🇫🇷France Paulmicha Porto Alegre, RS, Brasil
Indeed, could it be that the switch from Swiftmailer to Symfony Mailer has introduced these fields ?
In our case, it seems preferable not to add those fields to the existing forms. - Status changed to Active
over 1 year ago 12:36pm 28 November 2023 - 🇬🇧United Kingdom adamps
Indeed, could it be that the switch from Swiftmailer to Symfony Mailer has introduced these fields ?
No, the field I refer to is part of Core.
In our case, it seems preferable not to add those fields to the existing forms.
Interesting I'm surprised that it worked without using this module. I had imagined that this field is mandatory.
I believe that the right fix is in ContactEmailBuilderBase
- if ($email->getSubType() == 'mail') { + if ($sender && $email->getSubType() == 'mail') {
- Status changed to Needs work
2 months ago 7:26am 25 January 2025 - 🇮🇳India koustav_mondal Kolkata
@adamps I made the changes according to #5 . Please have a look.
- 🇬🇧United Kingdom adamps
Thanks. There is a merge conflict unfortunately.
- First commit to issue fork.
- Merge request !142Issue #3401849: Fix null sender error for Symfony Mailer → (Closed) created by brandonlira
- 🇧🇷Brazil brandonlira
Hi everyone,
I have updated the fix to target the correct version (1.4.0) by creating a new branch based on 1.x. The previous merge request was for 2.x, but after reviewing the issue and its comments, I realized that the correct fix should be applied to 1.4.0.
I have now submitted a new Merge Request (!143) for this version. Please review the changes and let me know if anything needs to be adjusted.
Additionally, I noticed that some PHPStan checks have failed. From my understanding, these errors seem to be pre-existing and unrelated to this MR. Could someone confirm if I should address them, or if they can be handled separately?
Thanks!
- 🇬🇧United Kingdom adamps
All fixes now go in 2.x please. The file is now ContactMailer.php and the code to change is line 100
if ($email->getTag(2) == 'mail') {
- Merge request !144Issue #3401849: Fix null sender error for Symfony Mailer → (Open) created by brandonlira
- 🇧🇷Brazil brandonlira
Hi @adamps,
I have moved the fix to ContactMailer.php (line 100) for 2.x MR (!144) and added a check to ensure $sender is not NULL before calling setReplyTo().
Please review and let me know if any adjustments are needed.
Thanks!
- 🇬🇧United Kingdom adamps
Thanks it looks good.
This needs someone to do a manual test. I added "steps to reproduce" in the issue summary. First run them without this patch and check you see the error. Then apply the patch and confirm the problem is fixed.
- Status changed to Needs review
1 day ago 11:36am 2 April 2025