Make tests pass on PHP 8.4

There's a lot of errors like this:

Deprecated: Drupal\webform\Plugin\Field\FieldType\WebformEntityReferenceItem::getSettableOptions(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/webform/src/Plugin/Field/FieldType/WebformEntityReferenceItem.php on line 114

Working on it.

@solideogloria at least some of messages in #2 have been fixed in 6.3.x. There are still messages like that in tests which come from other modules.

@liam morland I have made the changes. Please Review it.

Thanks for the patch.

The change to src/WebformRequest.php is not correct. A param with a default value cannot be before a param without a default.

It seems like it was a misunderstanding of what needs to change. While EntityInterface $source_entity = NULL is deprecated due to not having the nullable type, there is nothing wrong with ?EntityInterface $source_entity without a default value, so it should be left as-is.

@liam morland I have made the change according to comment #7 .

In #7, I was referring to this change:

-  public function getRouteName(EntityInterface $webform_entity, ?EntityInterface $source_entity, $route_name) {
+  public function getRouteName(EntityInterface $webform_entity, ?EntityInterface $source_entity = NULL, $route_name) {

A default value has been added to $source_entity. This cannot be correct because the param after it does not have default value. This change should not be made.

Commit 41308f5 is also incorrect for the same reason.

If you look at these changes in the merge request, there is a yellow triangle. Click on that to see an error message about that line of code.

@liam morland Now the Yellow triangle is not coming, please have look if any other changes is required.

Thanks for the patch.

I see a yellow triangle here, lines 244 and 253:

https://git.drupalcode.org/project/webform/-/merge_requests/585/diffs#49...

There cannot be a default value for any param that is followed by a param that does not have a default. Example:

public function getUrl(EntityInterface $webform_entity, ?EntityInterface $source_entity = NULL, $route_name, array $route_options = []) {

$source_entity has a default, but $route_name does not. To fix, remove the default from $source_entity.

Please rebase onto the latest 6.3.x; that will fix some errors. The comments added in src/WebformRequest.php should not have an empty line between the @param statements. Unless this method doesn't match what is in WebformRequestInterface, it can use {@inheritdoc}.

I note that the tests still don't pass on PHP 8.4. This may have to wait on other modules updating.

All that was needed to rebase is to type /rebase in a comment on this page

https://git.drupalcode.org/project/webform/-/merge_requests/585

A feel it is little unclear, should the MR be moved back to "needs review"?

It will be ready for review once tests are passing.

There are failures that come from other modules. It may be that the only remaining changes needed are fixes in other modules.