Views bulk operation not working on nodes

Working on it.

Made the changes. Please review.

Installed the specific version and tested the module before and after the changes. Looks good to me. Moving it to RTBC. Here I'm attaching two videos for the reference.

After upgrading the module from v2.1 to v2.2, we encountered issues where the bulk editing pages became non-functional.

Error: Call to undefined method Drupal\views_bulk_operations\Form\ConfigureAction::getEntity() in simplify_hide_widget() (line 588 of /var/www/html/docroot/modules/contrib/simplify/simplify.module).

#0 /var/www/html/docroot/modules/contrib/simplify/simplify.module(335): simplify_hide_widget('comment', Array, Object(Drupal\Core\Form\FormState))
#1 /var/www/html/docroot/core/lib/Drupal/Core/Extension/ModuleHandler.php(552): simplify_field_widget_complete_comment_default_form_alter(Array, Object(Drupal\Core\Form\FormState), Array)
#2 /var/www/html/docroot/core/lib/Drupal/Core/Field/WidgetBase.php(156): Drupal\Core\Extension\ModuleHandler->alter('field_widget_co...', Array, Object(Drupal\Core\Form\FormState), Array)
#3 /var/www/html/docroot/core/lib/Drupal/Core/Entity/Entity/EntityFormDisplay.php(190): Drupal\Core\Field\WidgetBase->form(Object(Drupal\comment\CommentFieldItemList), Array, Object(Drupal\Core\Form\FormState))
#4 /var/www/html/docroot/modules/contrib/views_bulk_edit/src/Form/BulkEditFormTrait.php(144): Drupal\Core\Entity\Entity\EntityFormDisplay->buildForm(Object(Drupal\node\Entity\Node), Array, Object(Drupal\Core\Form\FormState))
#5 /var/www/html/docroot/modules/contrib/views_bulk_edit/src/Form/BulkEditFormTrait.php(93): Drupal\views_bulk_edit\Plugin\Action\ModifyEntityValues->getBundleForm('node', 'blog', 'Blog entry', Array, Object(Drupal\Core\Form\FormState), 1)
#6 /var/www/html/docroot/modules/contrib/views_bulk_edit/src/Plugin/Action/ModifyEntityValues.php(156): Drupal\views_bulk_edit\Plugin\Action\ModifyEntityValues->buildBundleForms(Array, Object(Drupal\Core\Form\FormState), Array)
#7 /var/www/html/docroot/modules/contrib/views_bulk_operations/src/Form/ConfigureAction.php(92): Drupal\views_bulk_edit\Plugin\Action\ModifyEntityValues->buildConfigurationForm(Array, Object(Drupal\Core\Form\FormState))

....

Rolling back to v2.1 resolved the problem, restoring functionality as expected.

Upon comparing the code between v2.1 and v2.2, I identified several issues in the original implementation of the simplify_hide_widget() function in v2.2. These issues made the function error-prone, particularly in scenarios involving bulk operations or interactions with the comment widget.

To address these problems, I modified the `simplify_hide_widget()` function to resolve specific issues I identified. If the main maintainer believes any of these changes are unnecessary or can be improved, please feel free to adjust the code as needed.

1. Missing Validation: Assumed `$form_state` always had a valid form object and entity, causing errors in unsupported contexts.
- Fix: Added checks to ensure validity before proceeding.

2. Bundle Type Handling Relied on `$entity->type` without ensuring its presence.
- Fix: Used `hasField` and null-safe checks to handle entities without a `type` field.

3. Form Structure Assumptions: Assumed `$form['widget'][0]['#attributes']` always existed.
- Fix: Added checks and created structure if missing.

4. Undefined Config Values: `_simplify_get_config_value` calls lacked default values.
- Fix: Added default values (`[]`) to prevent undefined errors.

5. Loose Type Checks: `in_array` checks were not type-safe.
- Fix: Enabled strict type checking.

Pinged the maintainer to choose the right approach. Could we have both patches as MR maybe to speed things up?

1. +++ b/simplify.module
   @@ -579,25 +581,58 @@ function simplify_hide_field(string $field, array &$form) {
   +
   

   Let me argue that this does not bring much value as a comment...

   If leaving, there is this extra empty here.

2. +++ b/simplify.module
   @@ -579,25 +581,58 @@ function simplify_hide_field(string $field, array &$form) {
   +    \Drupal::logger('simplify')->error('FormState does not have a valid form object or entity.');
   

   Not sure it is worth polluting logs here.

3. +++ b/simplify.module
   @@ -579,25 +581,58 @@ function simplify_hide_field(string $field, array &$form) {
   +  if (!$entity instanceof ContentEntityInterface) {
   

   This case was already handled below, allowing the hide for none ContentEntityBase too, for instance metatags.

4. +++ b/simplify.module
   @@ -579,25 +581,58 @@ function simplify_hide_field(string $field, array &$form) {
   +    \Drupal::logger('simplify')->warning('Entity is not a content entity.');
   

   Not sure it is worth polluting logs here.

5. +++ b/simplify.module
   @@ -579,25 +581,58 @@ function simplify_hide_field(string $field, array &$form) {
   +  $global_fields = _simplify_get_config_value("simplify_{$entity_type}s_global", []);
   

   _simplify_get_config_value already returns empty array by default.

6. +++ b/simplify.module
   @@ -579,25 +581,58 @@ function simplify_hide_field(string $field, array &$form) {
   +      $form['widget'][0]['#attributes']['class'] = ['visually-hidden'];
   

   Why hiding if the field we are looking for is not present ?

dom. → closed merge request !9

@anybody: thank for ping

@foodslover and @sayan_k_dutta thanks a lot for working on it.

I like the @sayan_k_dutta approach best, which is only checking for the presence of an entity to the form.
As I was only able to reproduce the issue on D11 using https://www.drupal.org/project/views_bulk_edit → I find out however that the place in code you added your code @sayan_k_dutta does not affect the bug, hence I suggest applying to `simplify_hide_widget` as per @foodslover.

I was unaware of a module editing an entity without having it in the form state. That would probably not exists very often since this is a quite specific scenario. That being said, I suppose it could not be a bad thing to double check that entity everywhere we actually need it, just in case there are other scenarios where that might exist.

I suppose I would go with this correction attached, if someone could double check it fixes your issue.

@dom.
I applied your patch and used the views bulk edit module with simplify. Seems to resolve the errors previously occuring. Thanks for the help.
Attaching the screencasts.

sayan_k_dutta → reopened merge request !9

Made the code changes according to it, following @dom 's suggestions and reopened the MR !9.
I have reviewd from my end and it is working fine. Need others to confirm the review.

#11 worked on D10.3.x using v2.1. This was a huge fix, thank you!
Ref: Call to undefined method Drupal\views_bulk_operations\Form\ConfigureAction::getEntity() in simplify_hide_widget()

I checked MR 9 changes on drupal 11.1.1 and PHP 8.3.14
Before applying MR it was giving me error at the time of bulk node editing.
After I applied MR as a patch from composer and it is working fine. I am not getting any error or warning also on log detail page. So moving it to RTBC.
Adding 2 videos also for reference.

@dom. sorry for pinging again. Issue is RTBC'd and the MR looks fine to me and is not risky. So perhaps merge and release this fix? vbo is widely used.

@anybody, please do ! I am awefully sorry I can't keep with everything so please do ping me to increase it on my priority list !
Here we go, that's now commited.

@sayan_k_dutta: people reviewed patch #11 so that's what I am going to commit since I miss time for a complete review of your mr. But, I will make you first commiter in the commit message: thanks a lot for all you dedication here.

Thanks all for help, review and work.

(will be in 2.2.1)

Thank you, dom!!

Automatically closed - issue fixed for 2 weeks with no activity.