- Issue created by @BramDriesen
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Typo and added original participants.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Hi @deepali sardana
A few remarks:
- Patch workflows are deprecated, you should learn how to use the issue forks workflow. Especially with the GitLab issue migration around the corner. This will probably get you started: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... → also interesting is the DrupalPod workflow.
- Only make edits in scope of the issue. E.g. the changes to the node module or other tests do not belong here in this issue. I would limit the changes of this issue only to the phpdoc inStreamWrapperManagerInterface
. Changing to inheritdoc is already done in the other issue.
- I think you omitted some useful information from the code block. - Merge request !10857Issue #3495784: Update documentation for normalizeUri(). → (Open) created by Unnamed author
- 🇮🇳India koustav_mondal Kolkata
@bramdriesen I have raised MR. Please review it.
- 🇺🇸United States smustgrave
Left some comments but don't see explanation for a number of the changes.
@koustav_mondal just an FYI turning an existing patch into MR doesn't warrant saving credit but working on the issue will.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.