- Issue created by @BramDriesen
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Typo and added original participants.
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Hi @deepali sardana
A few remarks:
- Patch workflows are deprecated, you should learn how to use the issue forks workflow. Especially with the GitLab issue migration around the corner. This will probably get you started: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... โ also interesting is the DrupalPod workflow.
- Only make edits in scope of the issue. E.g. the changes to the node module or other tests do not belong here in this issue. I would limit the changes of this issue only to the phpdoc inStreamWrapperManagerInterface
. Changing to inheritdoc is already done in the other issue.
- I think you omitted some useful information from the code block. - Merge request !10857Issue #3495784: Update documentation for normalizeUri(). โ (Open) created by Unnamed author
- ๐ฎ๐ณIndia koustav_mondal Kolkata
@bramdriesen I have raised MR. Please review it.
- ๐บ๐ธUnited States smustgrave
Left some comments but don't see explanation for a number of the changes.
@koustav_mondal just an FYI turning an existing patch into MR doesn't warrant saving credit but working on the issue will.
The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
about 2 months ago 10:41pm 14 March 2025 - ๐ง๐ทBrazil charlliequadros
Can someone help me understand what I need to check here?
- ๐บ๐ธUnited States smustgrave
Believe the bot is saying the MR needs to be rebased, 300+ commits back so could be failing a new phpcs rule
- ๐ง๐ทBrazil charlliequadros
Hi @smustgrave
I've done the rebase. Let me know if you need anything else.
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
I think this looks okay now. Not a native English speaker so might have some grammar issues.
The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ง๐ทBrazil charlliequadros
The file StreamWrapperManagerInterface.php had execution permission, as shown in the image.
I have removed this permission. Could someone review it?
- ๐จ๐ฆCanada danrod Ottawa
What needs to be reviewed here? I see that the execution permission was removed from the file and documentation was added in the interface file:
Execution permission was removed:
Can be moved to RTBC.
- First commit to issue fork.
- ๐ณ๐ฟNew Zealand quietone
What needs to be reviewed is to review the issue that made the code changes and confirm that the documentation changes are correct and are correct English. The originating issue is a security one, and is private. That leaves reading the commit, which is 706b0006. After reading that I am not sure the changes here are accurate. The changes here use 'file path' where the originating issue uses 'file URIs', which are different things. I am setting 'needs work' for those working here to discuss that.
As a reminder, screenshots should only be added to issues that are changing the user interface. See the last paragraph at https://www.drupal.org/about/core/policies/maintainers/how-is-credit-gra... โ
- ๐บ๐ธUnited States mradcliffe USA
I am removing the Novice tag from this issue because I think it is a bit confusing for a first-time issue.
Iโm using this documentation as a source: https://www.drupal.org/community/contributor-guide/task/triage-novice-is... โ
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
kim.pepper โ made their first commit to this issueโs fork.
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
There was no public issue that made the change as it was a security issue. Here's the commit https://git.drupalcode.org/project/drupal/-/commit/cf82188fcf317e185716f...
I have checked the MR and confirmed it mentions uris and paths and the english is correct.
Current test fails are unrelated as this are docs only changes. RTBC for when it comes back green.