- Issue created by @mikelutz
- Merge request !11186Issue #3462866: Replace http://example.com with https://example.com in core. ā (Open) created by Unnamed author
- š®š³India koustav_mondal Kolkata
Replaced http://example.com. Please have a look.
- šŗšøUnited States smustgrave
Appears to have pipeline issues
Also
Exclude changing the URL in migration tests fixtures.
don't think this was taken into account
Also don't think we should change anything in the vendor directory.
- š³šæNew Zealand quietone
@koustav_mondal, Welcome to Drupal! Thanks for working on this issue.
When working on an issue like this it helps to share how you found the instances to fix. For example. did you use grep, the search function of an IDE, or write your own script? If you used a script, it should be uploaded.
We also need to make sure that these changes are not changing tests where the use if 'http' is correct. With the large number of changes here that will be difficult. I think this needs to be split into separate issues, not sure how many.
A start is to make a separate issue for the non-test changes in core/lib/Drupal. I think we need to make sure that production code is not changed.
@koustav_mondal, do you wish to make the separate issue and move those changes?
- š®š³India koustav_mondal Kolkata
@quietone I didn't write any script, used the search function of an IDE. Do I revert back the changes in test? Or you can create an issue for not non-test changes.
- š³šæNew Zealand quietone
@koustav_mondal, I think for now this needs to focus on splitting this issue into several smaller more manageable issues. To start can you move the changes in 'core/lib' to š Replace http://example.com with https://example.com in core/ib Active . It is not the most exciting work but it does happen that we need to split an issue into smaller, more manageable pieces.
Given that this is changing nearly 200 files, it will likely need to be split further. I can check in on this in a few days.
- š®š³India koustav_mondal Kolkata
Thank you @quietone, I'll move the changes in the new issue.
- šŗšøUnited States mradcliffe USA
I am removing the Novice tag from this issue because I think it is not as clear how to split the based on the various meta issues.
Iām using this documentation as a source: https://www.drupal.org/community/contributor-guide/task/triage-novice-is... ā