Changing page title doesn't update in the review changes panel

In AutoSaveManager.php there is a @todo Update label from incoming entity data once it exists for label.
https://git.drupalcode.org/project/experience_builder/-/blob/0.x/src/Aut...

Is it the right change?

I believe this is indeed the correct place/approach, but it should not hardcode title[0][value].

See the MR for ✨ The status badge should indicate if there are changes to the page Active at https://git.drupalcode.org/project/experience_builder/-/merge_requests/6... for the correct generalized approach, which looks like this:

      $label_field_input_name = sprintf("%s[0][value]", $content_entity_type->getKey('label'));
      $is_new = $this->contentEntityIsConsideredNew($entity_form_fields[$label_field_input_name], $content_entity_type);

Thanks @wim,

Please look into it.

What do you mean? 🤔

Sorry, I mean I'll look into it.

I've implemented the changes as mentioned in #5. Keeping this in "Needs Review" since tests are still required, allowing someone else to pick it up and continue

akhil babu → made their first commit to this issue’s fork.

This warning was appearing in logs while running the tests. So I have updated the AutoSaveManager::save() method to check if $data["entity_form_fields"] exists or not.

/var/www/html/web/modules/contrib/experience_builder/src/AutoSave/AutoSaveManager.php:34
Undefined array key "entity_form_fields"

Please review

Looks like there's test coverage already. The MR needs a rebase still though.

If tests pass, I think this is good

Automatically closed - issue fixed for 2 weeks with no activity.