- Issue created by @lauriii
- First commit to issue fork.
- Merge request !727#3508975: Component preview not loading for JS component" โ (Merged) created by omkar-pd
- ๐ฎ๐ณIndia omkar-pd
The component preview is now loading, but it appears empty. Debugging the issue.
- ๐ฎ๐ณIndia omkar-pd
I think the work on default_markup for code components is still pending.
default_markup: "@todo Make something ๐ in https://www.drupal.org/project/experience_builder/issues/3498889"
- Which appears to be fixed issue. - ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Updating title for consistent terminology.
Tagging per https://www.drupal.org/project/experience_builder/issues/3455753#release... ๐ฑ Milestone 0.2.0: Experience Builder-rendered nodes Active .
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
#6: Good observation, but that's not responsible for the preview ๐
/xb/api/config/component
does render preview markup for code components:"js.optional": { "source": "Code component", "metadata": { "slots": [ ] }, "field_data": { "maybe": { "required": false, "jsonSchema": { "type": "string" }, "sourceType": "static:field_item:string", "value": null, "expression": "โน๏ธstringโvalue" } }, "dynamic_prop_source_candidates": [ ], "transforms": { "maybe": { "mainProperty": [ ] } }, "id": "js.optional", "name": "optional", "library": "primary_components", "category": "@todo", "default_markup": "<!-- xb-start-5b3715c6-9e10-4fa9-9692-732bfe366912 --><astro-island uid=\"5b3715c6-9e10-4fa9-9692-732bfe366912\"\n component-url=\"/sites/default/files/astro-island/pKL_OwLDMlNxnBnBYIsn9BSu349KEpkBmq26qw_z8EQ.js\"\n component-export=\"default\"\n renderer-url=\"/modules/contrib/experience_builder/ui/lib/astro-hydration/dist/client.js\"\n props=\"{}\"\n ssr=\"\" client=\"only\"\n opts=\"{"name":"optional","value":"preact"}\"><script type=\"module\" src=\"/modules/contrib/experience_builder/ui/lib/astro-hydration/dist/client.js\" blocking=\"render\"></script><script type=\"module\" src=\"/sites/default/files/astro-island/pKL_OwLDMlNxnBnBYIsn9BSu349KEpkBmq26qw_z8EQ.js\" blocking=\"render\"></script></astro-island><!-- xb-end-5b3715c6-9e10-4fa9-9692-732bfe366912 -->", "css": "<link rel=\"stylesheet\" media=\"all\" href=\"/sites/default/files/css/css_2L-jRULv7_xXe52gIO_bjqU3o7kiFhu1A3RE26luuI8.css?delta=0&language=en&theme=olivero&include=eJxLrShILcpMzUtOjU8qzcxJSS3STywuKcqPzyzOScxL0csvKMnMz0vMAQBNxxA1\" />\n", "js_header": "", "js_footer": "<script src=\"/sites/default/files/js/js_62jyEDukuEKD8nfERQhtlwDsBadoEVzY0V2toERniis.js?scope=footer&delta=0&language=en&theme=olivero&include=eJxLrShILcpMzUtOjU8qzcxJSS3STywuKcrXy6hMKUosyczPAwDxxA3H\"></script>\n" },
Investigatingโฆ
- ๐ณ๐ฑNetherlands balintbrews Amsterdam, NL
wim leers โ credited balintbrews โ .
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Bingo:
What was needed, is making
#attached[import_maps]
be respected not just when rendering a full HTML response, but also when rendering each individual component preview. - ๐บ๐ธUnited States hooroomoo
wim leers โ credited hooroomoo โ .
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Per @hooroomoo's review โ they manually tested it; it didnโt interfere with any click events for opening the menus which was their concern ๐ฅณ
-
wim leers โ
committed b2c8b76d on 0.x authored by
omkar-pd โ
Issue #3508975 by wim leers, omkar-pd, hooroomoo, balintbrews: Preview-...
-
wim leers โ
committed b2c8b76d on 0.x authored by
omkar-pd โ
Automatically closed - issue fixed for 2 weeks with no activity.