- Issue created by @larowlan
- First commit to issue fork.
- Merge request !684#3507330: Change ExperienceBuilderController::getHtmlAndBodyAttributes to ::buildHtml → (Merged) created by omkar-pd
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
+1 to the idea/proposal. But
PHPStan
is failing. Once that's fixed, this is good to go! - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
There was 1 failure: 1) Drupal\Tests\experience_builder\Kernel\Plugin\ExperienceBuilder\ComponentSource\SingleDirectoryComponentTest::testRewriteExampleUrl Failed asserting that '/modules/custom/experience_builder-3507330/components/image/600x400.png' ends with "/experience_builder/components/image/600x400.png". /builds/issue/experience_builder-3507330/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122 /builds/issue/experience_builder-3507330/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:56 /builds/issue/experience_builder-3507330/tests/src/Kernel/Plugin/ExperienceBuilder/ComponentSource/SingleDirectoryComponentTest.php:38 /builds/issue/experience_builder-3507330/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
This is due to 📌 Harden SingleDirectoryComponentTest against unexpected module paths Active .
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 Harden SingleDirectoryComponentTest against unexpected module paths Active is in 👍
- 🇬🇧United Kingdom longwave UK
LGTM but also I wonder if we could/should ship a minimal html.html.twig in xb_stark and negotiate the theme for the XB route, maybe not worth it though.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
The
xb_stark
theme already serves a different purpose. So I'd rather not do that and keep this as simple as possible. -
wim leers →
committed 89b77d68 on 0.x authored by
omkar-pd →
Issue #3507330 by omkar-pd, wim leers, larowlan, longwave: Change...
-
wim leers →
committed 89b77d68 on 0.x authored by
omkar-pd →
Automatically closed - issue fixed for 2 weeks with no activity.