Three dancing dots - remove

Created on 5 February 2025, 2 months ago

Problem/Motivation

When installing modules through the Project Browser (this may only happen with max_selections > 1, not sure) - during the install, three dots animate and move next to the install button in the bar at the bottom.

Steps to reproduce

Pick some projects to install, then hit the install button.

Proposed resolution

Just remove the animated three dots - we have the spinner. (In a future issue we'll move the spinner down into the bar)

🐛 Bug report
Status

Active

Version

2.0

Component

User experience

Created by

🇺🇸United States chrisfromredfin Portland, Maine

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @chrisfromredfin
  • First commit to issue fork.
  • Merge request !707#3504656: Remove Dancing dots. → (Merged) created by omkar-pd
  • Pipeline finished with Success
    2 months ago
    Total: 792s
    #416449
  • 🇮🇳India sandip

    Hi @omkar-pd,

    Thank you for your work on this. However, there’s still one more thing left to address. While you have removed the .pb-elipsis class from the CSS, we also need to remove it where it was attached to the install button. i am working on this.

  • Pipeline finished with Success
    2 months ago
    Total: 476s
    #416534
  • 🇮🇳India sandip

    Please review the changes.

  • 🇮🇳India sandip

    Attaching before and after SS for better understanding.

  • 🇮🇳India utkarsh_33

    Can you also update the SS when max_selections > 1?

  • 🇮🇳India utkarsh_33

    Manually tested this and the code changes looks good to me.The three dots don't appear in both cases.

  • 🇮🇳India sandip

    Hi @utkarsh_33, I am not getting any option in Project Browser UI to select multiple module to be installed (e.g. max_selections > 1). Can you guide me so i can take the SS and upload here too.

  • First commit to issue fork.
  • Pipeline finished with Canceled
    2 months ago
    Total: 348s
    #418233
  • 🇺🇸United States chrisfromredfin Portland, Maine

    Moving back to NW.

    You can set max_selections to one with drush or some other way to edit your config:
    drush cset -y project_browser.admin_settings max_selections 1

    This completely removes the dancing dots, even when we need them, which is when max_selections is 1.

    Alternatively, the spinner we use could be put up when max_selections = 1, and that would also be an OK alternative (perhaps even better, meaning consistent UI both ways).

  • Pipeline finished with Failed
    2 months ago
    Total: 357s
    #418239
  • Pipeline finished with Canceled
    2 months ago
    Total: 95s
    #419614
  • 🇮🇳India utkarsh_33

    Only showing the dancing dots when max_selections is 1.

  • Pipeline finished with Success
    2 months ago
    Total: 421s
    #419615
  • 🇮🇳India sandip

    Hi @utkarsh_33, I noticed that when MAX_SELECTIONS > 1, an unnecessary empty class attribute is being added to the . To address this, I propose using the following approach: <span class:pb-ellipsis={MAX_SELECTIONS === 1}>{message}</span>. This ensures that the class attribute is only included when MAX_SELECTIONS === 1, resulting in cleaner HTML output. Could you please share your thoughts on this solution?

  • 🇮🇳India utkarsh_33

    I completely agree with #13.I overlooked that.I have added what you suggested.

  • Pipeline finished with Success
    2 months ago
    Total: 455s
    #419659
  • 🇮🇳India sandip

    LGTM :)
    Moving to RTBC++

  • Pipeline finished with Success
    2 months ago
    Total: 590s
    #420605
  • Pipeline finished with Skipped
    2 months ago
    #421052
  • 🇺🇸United States chrisfromredfin Portland, Maine

    Thanks for the look, Sandip! Happy to have you here (especially if you have some Svelte chops!) :)

  • 🇮🇳India sandip

    Thank you @chrisfromredfin! Your appreciation means a lot to me. I’m still new to Svelte—I picked it up while working on this issue—but I’m excited to explore it further and apply it to future issues in Project Browser.
    Thanks again 😄

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    about 2 months ago
    Total: 1273s
    #434048
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1279s
    #434057
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1500s
    #434070
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1320s
    #434100
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1384s
    #434113
  • Pipeline finished with Success
    about 2 months ago
    Total: 1472s
    #434131
  • Pipeline finished with Skipped
    about 2 months ago
    #434143
Production build 0.71.5 2024