- Issue created by @chrisfromredfin
- First commit to issue fork.
- 🇮🇳India sandip
Hi @omkar-pd,
Thank you for your work on this. However, there’s still one more thing left to address. While you have removed the .pb-elipsis class from the CSS, we also need to remove it where it was attached to the install button. i am working on this.
- 🇮🇳India utkarsh_33
Manually tested this and the code changes looks good to me.The three dots don't appear in both cases.
- 🇮🇳India sandip
Hi @utkarsh_33, I am not getting any option in Project Browser UI to select multiple module to be installed (e.g. max_selections > 1). Can you guide me so i can take the SS and upload here too.
- First commit to issue fork.
- 🇺🇸United States chrisfromredfin Portland, Maine
Moving back to NW.
You can set max_selections to one with drush or some other way to edit your config:
drush cset -y project_browser.admin_settings max_selections 1
This completely removes the dancing dots, even when we need them, which is when max_selections is 1.
Alternatively, the spinner we use could be put up when max_selections = 1, and that would also be an OK alternative (perhaps even better, meaning consistent UI both ways).
- 🇮🇳India sandip
Hi @utkarsh_33, I noticed that when MAX_SELECTIONS > 1, an unnecessary empty class attribute is being added to the . To address this, I propose using the following approach:
<span class:pb-ellipsis={MAX_SELECTIONS === 1}>{message}</span>
. This ensures that the class attribute is only included when MAX_SELECTIONS === 1, resulting in cleaner HTML output. Could you please share your thoughts on this solution? - 🇮🇳India utkarsh_33
I completely agree with #13.I overlooked that.I have added what you suggested.
-
chrisfromredfin →
committed 38abd1ab on 2.0.x authored by
omkar-pd →
Issue #3504656 by utkarsh_33, sandip poddar, phenaproxima,...
-
chrisfromredfin →
committed 38abd1ab on 2.0.x authored by
omkar-pd →
- 🇺🇸United States chrisfromredfin Portland, Maine
Thanks for the look, Sandip! Happy to have you here (especially if you have some Svelte chops!) :)
- 🇮🇳India sandip
Thank you @chrisfromredfin! Your appreciation means a lot to me. I’m still new to Svelte—I picked it up while working on this issue—but I’m excited to explore it further and apply it to future issues in Project Browser.
Thanks again 😄 Automatically closed - issue fixed for 2 weeks with no activity.