- Issue created by @penyaskito
- First commit to issue fork.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
See the patch I provided at #3508694-19: Permissions for XB config entity types → as a starting point.
- 🇮🇳India meghasharma
Could you please add some more details to the issue description? It would be helpful to have more clarity on the expected behavior and a proposed solution.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
- Merge request !833Issue #3516609: Move components listing to Appearance. → (Merged) created by meghasharma
- 🇮🇳India meghasharma
Changes Done:
Updated Permission: experience_builder.component.status now uses the administer themes permission.
Updated Links: Changed /admin/structure/component to /admin/appearance/component in component entity definition links.
Removed "Page Builder Components" from Structure.
Please reviewNow:
You can see the list of enabled and disabled components at /admin/appearance/component.Remaining Task:
Add a "Components" tab under the Appearance section. - 🇮🇳India meghasharma
Added a "Components" tab under the Appearance section and updated the "Enabled Components" and "Disabled Components" tabs under the "Components" section by adding the parent_id., Moved "Page builder components" listing in Structure to "Components" in Appearance.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Thanks! I overlooked a couple of issues in my previous review.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Found a couple of other routing changes required.
Also fixed docs referencing these.This should be good, @megasharma thanks for the quick turn-around!
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
phpstan errors are unrelated and fixed in 📌 Update PHPCS config to match Drupal 11 + phpstan issues Needs review .
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Thanks to the screenshots, I was confident to approve this without testing locally. :) Thanks!
Re-running pipeline now that 📌 Update PHPCS config to match Drupal 11 + phpstan issues Needs review landed :)
-
wim leers →
committed 6bf4f851 on 0.x authored by
meghasharma →
Issue #3516609 by meghasharma, penyaskito, wim leers: Move components...
-
wim leers →
committed 6bf4f851 on 0.x authored by
meghasharma →
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
bot crossposted?