Consider enabling claro as the admin theme in XbTestSetup

wim leers → made their first commit to this issue’s fork.

Thoughts, @bnjmnm? 😊

This seems fine - AFAIK the only motivations behind not doing this initially is no longer relevant at this stage in the project. After merging 0.x with this I did encounter some problems that I addressed largely in XBTemplateRenderer, and also extended one of the e2e timeouts so it spanned the wait of the autosave interval + a little additional time.

Needs ui codeowner approval.

This also needed a manual run of the tests currently skipped for headless: prop-types.cy.js and autocomplete-props.cy.js:

@larowlan recently touched some of the changes @bnjmnm just made here in 📌 Media Library dialogs triggered from page data do not have buttons yet Active , so I'd like to have him explicitly review this too. 🙏

Needs reroll and I think there are some changes we've already made.
I was also expecting that there'd be a few e2e tests we no longer need to manually enable claro for - which should speed things up.
Sorry I didn't realise this was assigned to me.

#12 sounds like something someone unfamiliar with the XB codebase can pull off :)

meghasharma → changed the visibility of the branch 3514551-consider-enabling-claro to hidden.

meghasharma → changed the visibility of the branch 0.x to hidden.

omkar-pd → changed the visibility of the branch 3514551-consider-enabling-claro to active.

meghasharma → changed the visibility of the branch 3514551-consider-enabling-claro to hidden.

meghasharma → changed the visibility of the branch 3514551-consider-enabling-claro to active.

Reverted all the previous commit changes from here:- https://git.drupalcode.org/project/experience_builder/-/commit/3adb350b7...

The current MR is more unnecessary changes than necessary ones. It might be easier to start a new one.

Also, any e2e tests enabling Claro as the admin theme should have that line removed since it is now doing that by default.

Rebased the branch and setting the admin theme to Claro came as incoming changes.
please check

The new MR makes no changes at all, other than whitespace? 😅 I bet you pushed the wrong commit 😁

Rebased the branch, yes there are changes already merged in 0.x
only needed to do e2e tests we no longer need to manually enable claro, have done in MR
Please review

#22 Yes, because Install and set Claro as the admin theme in XbTestSetup changes already merged in 0.x main branch. may it's done in other issue.

Ah, yes, 📌 Multiple fields widget should fully work in the contexual form Active apparently did that!

This MR is still worth landing though: it's a nice bit of clean-up.

Thank you! 😊

Automatically closed - issue fixed for 2 weeks with no activity.