- last update
8 months ago Patch Failed to Apply - @el7cosmos opened merge request.
- 🇮🇩Indonesia el7cosmos 🇮🇩 GMT+7
Add an MR that removes `context` in `once` call and changes target branch to 11.x
- Status changed to Needs review
8 months ago 11:05am 31 October 2023 - Status changed to RTBC
8 months ago 12:32pm 31 October 2023 - 🇮🇳India Shyam_Bhatt Gujarat
@el7cosmos As per the steps to reproduce, I have followed the same for Drupal Version: 11.x-dev
Steps to reproduce
- Create a new standard Drupal site with "11.x-dev"
- Enable the Media and Media Library modules
- Visit /admin/content/media
- Create pieces of media until a paginator appears in the Grid tab (currently, you must create at least 25 pieces of media)
- Navigate to the Grid tab
- Notice the Select all media checkbox, Navigate to the second page of results, Notice that the Select all media checkbox does not appear
- Navigate back to the first page of results, Notice that the Select all media checkbox does not appear
Before patch #20 🐛 "Select all media" checkbox disappears after using paginator in Media Library Grid view RTBC :
After patch #20 🐛 "Select all media" checkbox disappears after using paginator in Media Library Grid view RTBC :
After checking with Drupal Version 11.x-dev
+ Moving to RTBC - last update
8 months ago 30,317 pass, 12 fail The last submitted patch, 14: 3226628-14.patch, failed testing. View results →
- last update
8 months ago Composer error. Unable to continue. - Status changed to Needs work
8 months ago 9:39am 1 November 2023 - 🇫🇮Finland lauriii Finland
This is something that should be relatively straight forward to test automatically.
- last update
8 months ago Composer error. Unable to continue. - Status changed to Needs review
8 months ago 12:58pm 8 November 2023 - Status changed to RTBC
8 months ago 1:17pm 8 November 2023 - 🇮🇳India Shyam_Bhatt Gujarat
@el7cosmos I have checked with Drupal version "10.1.6" same issue on that version as well please merge the working MR to Drupal version "10.1.6" as well.
"MR !5199" looks good the automated testing file was added and working fine.
+ Moving to RTBC
- last update
8 months ago 30,316 pass, 14 fail - last update
8 months ago 30,317 pass, 12 fail - last update
7 months ago 30,317 pass, 12 fail - last update
7 months ago 30,317 pass, 12 fail - 🇺🇸United States xjm
Excellent steps to reproduce; thanks @john.karahalis. Saving credit for that. Also crediting @mohit_aghera and @el7cosmos for the work on the patch and the later fixes to the MR, @grace_karuna and @Shyam_Bhatt for manual testing, and @Manoj Raj.R for code review.
I did not credit @Anchal_gupta because there was no clear indication as to what was being fixed and the patch appeared broken. In the future, when using a patch workflow, provide interdiffs → for your patches. That allows reviewers to evaluate your changes. (Or, preferably, use merge requests, since patches are being deprecated for core issues.)
- Status changed to Needs work
7 months ago 11:02pm 15 November 2023 - 🇺🇸United States xjm
Also, please don't upload patches when an issue has a merge request that is canonical. It makes it difficult to tell which version is intended for commit, and adds noise. Please hide any non-canonical patch files from the IS so it is clear what committers should review.
It does have test coverage, so removing that tag.