- Issue created by @hudri
- 🇷🇺Russia Chi
Many other Twig Tweak filters are also not filters. And Drupal core has such examples as well. Furthermore Twig itself has filters that don't filter anything. That's a historical naming convention that we can't change.
- 🇦🇹Austria hudri Austria
The "filter" phrase was meant in regard to the current description (the opposite of core's
without
), which actually does filter a render array. I can't see any the reason whywith
(setter) should be the opposite ofwithout
(filter) - 🇷🇺Russia Chi
I can't see the reason why with (setter) should be the opposite of without (filter)
without
removes properties
with
adds properties
Isn't this what "opposite" term means? - 🇦🇹Austria hudri Austria
OK, now I got the naming.
In my mental model,
without
is a filter by disallow list, so reading the description I thoughtwith
is a filter by safe list, and used it likecontent|with(computedArrayOfAllowedFieldnames)
. This did not work and let to the creation of this issue. - last update
about 1 year ago 11 pass - @hudri opened merge request.
- Status changed to Needs review
about 1 year ago 9:30am 7 November 2023 - Status changed to RTBC
about 1 year ago 6:54am 10 November 2023 - 🇮🇳India shyam_bhatt Gujarat
@hudri I have checked the "MR !39", documentation updated on the "cheat-sheet.md" file.
Before:
After:
+ Moving to RTBC
- Status changed to Fixed
about 1 year ago 7:23am 10 November 2023 - 🇷🇺Russia Chi
@Shyam_Bhatt no need to make screenshots for code. It only proves that you are correctly deployed the Git branch to your localhost.
The change is visible here.
https://git.drupalcode.org/issue/twig_tweak-3399652/-/blob/3399652-with-... Automatically closed - issue fixed for 2 weeks with no activity.