We just ran into an issue that seems to be related to this one after upgrading to the latest Drupal release (10.2.3).
All our "ExistingSiteSelenium2DriverTestBase" tests are throwing the error "Unable to complete Ajax request" when calling the "assertWaitOnAjaxRequest" method.
The solution we've found so far is to set the setting `extension_discovery_scan_tests` to `true` and enable the `js_testing_ajax_request_test` module manually in the test via the "module_installer" service.
Please let us know if there is any better approach to enable the testing module.
Recreated rerolling patch for 10.2.x since the "$title" property in the "CacheableTitle" class could be array type as well and throwing the error after adding the type hint.
Rerolling again for latest 10.2.x
@smustgrave
It's because the resize event not being triggered correctly, I had an explanation and example in
comment #5
🐛
CKEditor 5 toolbar items of multi-value field (typically Paragraphs) overflowing on narrow viewports and overlapping with node form's sidebar on wide viewports
Active
I just closed the MR #3 for less confusion as the MR #4 should have all the changes from MR #3.
I believe people should be using/making new commits to MR #4.
@RedNeko
This might be a different issue, not related to Paragraphs module, see
https://www.drupal.org/project/drupal/issues/3332416 🐛 CKEditor 5 toolbar items of multi-value field (typically Paragraphs) overflowing on narrow viewports and overlapping with node form's sidebar on wide viewports Active
This issue from 5 years ago might be related.
I created a patch that stores the SAML session in the private temp storage service regardless of whether the user has an active Drupal account. This allows the session to be stored and to be used later for the logout request even for users wit no active Drupal account.
I also made some updates to the logic in the `drupalLogoutHelper` method. Instead of checking if the user is currently logged in, the logic now check if the current request carries a valid session and determine if the SAML session should be returned from the method.
@Mingsong
I believe not because this query is triggered during a "post_udpate" hook.
I added the `accessCheck` method because it's required in Drupal 10.
Although I'm unsure of the reason behind adding the strict comparison initially, personally, I believe that doing strict comparison is a beneficial practice in general.
changing status to "Needs Review"
Here's a patch that force casts the status code into string
I created a new branch named "3322523-ckeditor5-fixes-adjustment" which includes the following changes:
1. Added dynamic support for adding the entity embed buttons of paragraphs to the toolbar items, which addresses the issue mentioned in
#18
📌
Migrate to CKEditor 5 for Drupal 9.4+ / Drupal 10
Fixed
.
2. Added support for opening the paragraph entity embed dialog when selecting an embedded paragraph, matching the editing behavior of CKEditor 4.
3. Created an upgrade path so that the toolbar item does not need to be re-added after switching to Ckeditor5 in the editor settings.
4. Minified the build file.
I'm not seeing the paragraph embed button being added to the toolbar on the front-end and I'm getting this error in the browser console.
toolbarview-item-unavailable {item: 'ParagraphsEmbed'}
Am I missing something? I'm on the latest commit of the feature branch.
Also, I think we should minify the build file.
Not sure if it's worth but hopefully this patch could address most of the tests.
There are two functional javascript tests that might fail due to upstream issue from Panels module
See https://www.drupal.org/project/panels/issues/3352958#comment-15002421 🐛 Functional Javascript Test Failures Active
here's a patch that replaces the jQuery once with the new once library from core.
In my opinion, the code located at line 81 of docroot/modules/contrib/webform/src/Plugin/Field/FieldFormatter/WebformEntityReferenceFormatterBase.php is likely causing custom modules to encounter issues when attempting to save the webform entity.
if (isset($item->open) || isset($item->close) || isset($item->status)) {
$entity->setOverride();
}
To elaborate, this code ensures that the render cache of the referenced entity can be cached by providing constant values for certain fields from the entity reference item. Additionally, setting the override to TRUE prevents the status of the main webform from being affected by the value of the entity reference item.
Therefore, for custom modules, resetting setOverride() to FALSE should be safe during a "hook_entity_node_presave" or "hook_entity_save" hook, provided they can handle the reversion of the status value appropriately.
the patch no longer applys on latest of 10.0.x, rerolling.
Revert the change of extending Entityform seems to be fix the test failures.
I don't think we should be changing the extending class just because the parent class is marked as `@internal`.
See discussion in
https://github.com/mglaman/phpstan-drupal/issues/284
https://www.drupal.org/project/drupal/issues/2491057#comment-14356806 📌 Streamline the entity deletion form class hierarchy Needs review
Perhaps we should add @phpstan-ignore-next-line as well?
Getting the same error after switching from chrome-mink-driver to Selenium2Driver
I created a PR here in minkphp/MinkSelenium2Driver to use "innerText" to retrieve the page title.
The patch needs a reroll for 10.x as there is no longer an ajax.es6.js file
here's a patch that adds accessCheck(FALSE) to the node delete hook.
here's a patch that adds the class back to the buttons.
Hi, @Wim Leers
I believe that this issue could happen whenever the ckeditor is embedded inside a table element, for example, a text field that supports multiple values.
See the reproducible steps that I have on the main post.
1. Do a Drupal clean install. (I use https://simplytest.me/)
2. Navigate to a content type and create a text field that uses ckeditor 5 and allow unlimited value.
3. Move the field to the top on the form display of the content type.
4. Add more items to the ckeditor.
5. Go to the create page of the content type and resize the browser down to around 1000px (depends on the number of the toolbar items)
6. See the overlapping issue.
Also, I noticed that
@GaëlG
We also miss an upgrade path. For now, if I switch an existing CKE to CKE5 in Drupal UI, I get:
I totally forgot about that, I'll take a look when I have a chance.
Also, I get both the "edit link" and the "edit file" buttons on both usual links and file links.
This is the same behavior when you right click on a link on the ckeditor 4 version. I tried to create an unique popup view for uploaded file links but I had to pulled in a lot of duplicated code from the LinkUi plugin, so I decided to just revert the changes and reuse the popup from LinkUI.
See this https://git.drupalcode.org/project/editor_file/-/merge_requests/3/diffs?commit_id=b6f34abe012a79cfab5694104ad2b2ac32797ca7 if you believe it would better to use a dedicated popup for file links.
@Wim Leers
There is a similar issue on ckeditor5's repo but haven't been responded by anyone for about a year.
After looking into the code of ckeditor, I don't think it could be easily fixed from upstream as they might need to change the way of how to calculate if the toolbar items are overflowing or not.
Currently, Ckeditor 5 relies on the `resize` event to determine if the toolbar items should be wrapped inside a popup. However, the event doesn't seem to be triggered for the toolbar element when it's embedded in a table or fieldset as the flex styling isn't being resized correctly when a flex element is wrapped inside in the two said elements above and this seems to be the default behavior of current browsers (tested on Chrome/Safari).
See this codepen link for example.
I tried to see if we could replace the table used in the multivalue field to use div instead but looks like Drupal core is using tabledrag to handle the ordering and I assume we don't (can't) switch it to use div?