- Issue created by @sker101
- Status changed to Needs review
almost 2 years ago 6:59pm 27 January 2023 The last submitted patch, 5: 3336477-4.patch, failed testing. View results β
- Status changed to RTBC
almost 2 years ago 7:55pm 1 February 2023 - πΊπΈUnited States jrockowitz Brooklyn, NY
Marking this as RTBC since it must go out in the next beta release.
- Status changed to Needs work
almost 2 years ago 5:34pm 2 February 2023 - πΊπΈUnited States hershy.k
@jrockowitz - I tested the patch on a personal project and I'm not seeing the issue resolved on my end with the patch applied.
Here's a simplytest.me spun up with Core: 9.5.3 and Webform: 2.x-dev with the patch applied and the Plain Text format is still appearing. Am I missing some step?
- πΊπΈUnited States jrockowitz Brooklyn, NY
Okay, I can see it on simplytest.me. I also uninstalled webform and the webform's text format did not get uninstalled.
- Status changed to Needs review
almost 2 years ago 6:24pm 2 February 2023 - πΊπΈUnited States hershy.k
I modified the patch logic to use `array_key_exists` in-place of `isset()` for checking whether the array index exists. Because it was returning FALSE due to the key being set to `null`. See below.
With this change the patch functions as expected. MR has the modified code.
- @hershyk opened merge request.
- πΊπΈUnited States hershy.k
Here's simplytest site with updated patch applied and functioning.
- πΊπΈUnited States jrockowitz Brooklyn, NY
Thank you for reviewing the patch. Here is a lighter-weight approach to blocking the default webform text format from being exposed on other forms.
The last submitted patch, 14: 3336477-11.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to RTBC
almost 2 years ago 6:44pm 7 February 2023 - πΊπΈUnited States hershy.k
I tested patch in #14 and it functions as expected both on a personal project and on simplytest.me.
-
jrockowitz β
authored c802c238 on 6.2.x
Issue #3336477 by jrockowitz, hershy.k: Text format "plain text" is...
-
jrockowitz β
authored c802c238 on 6.2.x
- Status changed to Fixed
almost 2 years ago 6:13pm 14 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.