The code changes from MR #2 appeared to be missing something. The interface used in the code was non existent in the codebase.
As noted in #5 🐛 Inline images in the answer field are removed during file garbage collection Active ideally the custom answer text field data structure would need to be refactored to support this capability even with core's commit in https://www.drupal.org/project/drupal/issues/2857444 → .
The approach taken in MR #6 attempts to make a minor code change that would allow for support for inline-image file status to be controlled by core's editor module without refactoring the answer field's data structure.
I also updated the category to a "Feature request" as it's not technically a bug but a feature that has never been supported AFAIK.
To test functionally:
- Enable faqfield module and add a faqfield type to a content type
- Use WYSIWYG formatter to upload inline-image file to answer textfield
- Save entity and verify the status of the file uploaded to system accurately reflects a permanent status in the admin file list view
hershey.k → made their first commit to this issue’s fork.
@generalredneck - I applied the patch on our site and am seeing the update db fail with the following output. See attached.
Tech specs:
Drupal: v10.1.3
VNS: v2.0.0-alpha7
PHP: v8.1
Thanks @jastraat for reporting. The merged in issue was a duplicate of this one, glad it was fixed though.
@jrockowitz - perhaps this should be documented somewhere in webform's cookbook for developers?
For those wondering now this has been fixed on 3.1.x as well. Since 3.1.5 release.
See https://git.drupalcode.org/project/acquia_search/-/commit/2ec94249a21302...
hershey.k → created an issue.
hershy.k → created an issue.
Thanks @maxstarkenburg! Confirming patch addresses the php warning in the logs.
Can we get this merged in?
I've encountered the same issue as the OP here as described in issue comment 3113799 → .
I can confirm that by exporting the empty conditions object in the config file (when the condition plugins are not being used here and only appearing from other modules condition plugin) and applying one of the core patch 2815829 🐛 Adding or editing a block through the UI saves the entity twice Fixed or the patch from #13 this config-mismatch no longer occurs.
I tested patch in #14 and it functions as expected both on a personal project and on simplytest.me.
Here's simplytest site with updated patch applied and functioning.
I modified the patch logic to use `array_key_exists` in-place of `isset()` for checking whether the array index exists. Because it was returning FALSE due to the key being set to `null`. See below.
With this change the patch functions as expected. MR has the modified code.
@jrockowitz - I tested the patch on a personal project and I'm not seeing the issue resolved on my end with the patch applied.
Here's a simplytest.me spun up with Core: 9.5.3 and Webform: 2.x-dev with the patch applied and the Plain Text format is still appearing. Am I missing some step?
I've merged in the latest code changes from 8.x-2.x branch and committed my draft work. I have the plugin toolbar item appearing and the general file structure for the ckeditor5 plugin equivalent.
I haven't made much progress with the functionality of loading the paragraph embed form within the dialog was running into a 403 access denied with the custom route. I suspect this possibly might be related to CSRF token although haven't had much time to look further into it. I'm un-assigning as I won't be able to continue much more work on this project at this time. Hopefully someone else will be able to continue from where I've left off.