Hi, we noticed that our site's tests are failing when testing the FileBrowser module after updating Drupal core to 10.4, showing the following error.
User warning: Trying to overwrite a cache redirect for "entity_view:block:claro_breadcrumbs:[languages:language_interface]=en:[theme]=claro:[user.permissions]=7dec4984dea6a38d91c9ad5b988772c9abaf60141a98612265531f170db12d98" with one that has nothing in common, old one at address "languages:language_interface, theme, user.permissions" was pointing to "url.path.parent, url.path.is_front, route", new one points to "url, url.query_args". in Drupal\Core\Cache\VariationCache->set() (line 138 of /home/travis/build/docroot/core/lib/Drupal/Core/Cache/VariationCache.php) #0 /home/travis/build/docroot/core/includes/bootstrap.inc(166): _drupal_error_handler_real(512, 'Trying to overw...', '/home/travis/bu...', 138)
After some research, we found that recent changes in Drupal core 10.4 seems to require other modules to use the correct cache contexts. See the Drupal.org issue below for details:
https://www.drupal.org/project/drupal/issues/3495165 🐛 cache problem after updated to 10.4.0 Active
Active
3.1
Directory Listing Pages
I created a patch that follows a similar approach to other modules—see the examples below.
https://git.drupalcode.org/project/varbase_media_header/-/merge_requests...
https://git.drupalcode.org/project/menu_breadcrumb/-/merge_requests/27/d...
I'm not entirely sure if the cache contexts added in the patch are sufficient, but we no longer see the error in our tests.