Breadcrumb render cache not invalidated when entity label changes

MR has many test failures.

Also I tried to reproduce following the IS on Drupal 10 and was not able to replicate. Title updates just fine for me, but maybe it's just me. Will rely on the tests to prove me wrong.

Created a test fail patch based on # 138 🐛 Breadcrumb render cache not invalidated when entity label changes Needs work to prove issue exists.

Added some feedback.

Rule of thumb I've been trying to use for new functions on interfaces or classes we should try to typehint.

Tests look good!

Fixed phpstan-baseline error in the fail test patch in #164.

The last submitted patch, 166: 2607920-166-breadcrumb-render-cache-10.x-fail.patch, failed testing. View results →

@gustavowal mentioned in # 155 🐛 Breadcrumb render cache not invalidated when entity label changes Needs work

The issue is very straightforward to replicate, on an admin logged session editing the title that also changes the breadcrumb and going to a non-logged session, the title will reflect the change and also the URL, but the breadcrumb will stay the same. Viewing the page on the logged-in session shows up the updated breadcrumb right away, due to logged-in not being cacheable.

I think we need to update fail test patch to consider logged in user as well. Which is currently not included.

Re-roll for 10.2.x

Rerolling again for latest 10.2.x

Bhanu951 → changed the visibility of the branch 2607920-breadcrumb-render-cache to hidden.

Recreated rerolling patch for 10.2.x since the "$title" property in the "CacheableTitle" class could be array type as well and throwing the error after adding the type hint.

I tested patch #176 for version 10.2.5 and it worked correctly.