Drupal 10 compatibility fixes follow up

here's a patch that replaces the jQuery once with the new once library from core.

Not sure if it's worth but hopefully this patch could address most of the tests.

There are two functional javascript tests that might fail due to upstream issue from Panels module

See https://www.drupal.org/project/panels/issues/3352958#comment-15002421 🐛 Functional Javascript Test Failures Active

Thanks @Shen for the patch.

May I ask a question about the access check in following codes?

 
   /** @var \Drupal\panelizer\Plugin\PanelizerEntityManager $panelizer_manager */
   $panelizer_manager = \Drupal::service('plugin.manager.panelizer_entity');
@@ -31,6 +31,7 @@ function panelizer_post_update_rename_layout_machine_names(&$sandbox) {
       $storage = \Drupal::entityTypeManager()->getStorage($entity_type);
       $ids = $storage->getQuery()
         ->condition('panelizer', serialize([]), '<>')
+        ->accessCheck(FALSE)
         ->execute();

Do we need to check the access in this case?

@Mingsong
I believe not because this query is triggered during a "post_udpate" hook.
I added the `accessCheck` method because it's required in Drupal 10.

Thanks @Shen.

all of this looks good and is needed

Thank you very much! I can confirm this patch also.

Notice for people who want to add this patch: Remove #3325442 before because it is included in this patch already.

This looks good, thank you.

Committed. Thank you.

Note for others, patch does not apply and current 4.x version still produces various once errors in the console `$(...).once is not a function`.

@zanematthew, I'd say try the latest tagged release, no need for a patch now that it's released and included in the build, please rebuild your cache after upgrading to the latest release

composer require 'drupal/panelizer:^4.5'
This will get you 4.5 or newer, 4.5 being just released today.

@joseph.olstad I revisited this and it was another module causing the .once error. This update works as expected, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.