- Issue created by @sker101
- πΊπΈUnited States sker101 NYC
Here's a patch that force casts the status code into string
- Status changed to Needs review
over 1 year ago 4:13pm 14 April 2023 - π¦π·Argentina hanoii π¦π·UTC-3
If we are going to cast, isn't it better to remove the strict comparison instead?
- πΊπΈUnited States sker101 NYC
Although I'm unsure of the reason behind adding the strict comparison initially, personally, I believe that doing strict comparison is a beneficial practice in general.
- π¦π·Argentina hanoii π¦π·UTC-3
But if you are casting you are removing any potential benefit of the strict comparison
- First commit to issue fork.
- last update
over 1 year ago 54 pass - @amangrover90 opened merge request.
- Status changed to RTBC
over 1 year ago 2:22pm 24 April 2023 - πΊπΈUnited States mglaman WI, USA
I believe that doing strict comparison is a beneficial practice in general.
I agree, unless it's Drupal and dealing with integers.
MR fixes 200 response code checks as well.
- last update
over 1 year ago 54 pass -
mglaman β
committed d63fb1a1 on 2.0.x authored by
amangrover90 β
Issue #3353846 by amangrover90, sker101: Response code condition setting...
-
mglaman β
committed d63fb1a1 on 2.0.x authored by
amangrover90 β
- Status changed to Fixed
over 1 year ago 2:23pm 24 April 2023 - πΊπΈUnited States mglaman WI, USA
Merged! We're working on a few other follow ups before making a new release.
Automatically closed - issue fixed for 2 weeks with no activity.