Budapest, Hungary
Account created on 20 September 2011, over 12 years ago
#

Merge Requests

Recent comments

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Thank you! Fixed in 3.x branch. Please upgrade to 3.0.0, this project switched to SemVer.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Thank you. Committed to 3.x branch.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

This patch works fine. Tested with Drupal v10.1.6.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

On the last weekend I did some improvements, which can be used for this purpose. I'll do a few more tests on touch screen devices, then I'll commit.

There will be a separate section for Custom behavior settings on the block settings form:

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

#22 patch works for me. Drupal 9.5.11 with Search API Solr 4.3.0.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

The default branch is 4.x now.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Please also set value for the "cookieDomain"!

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Yes, block plugins could be managed in a separate group in the select list. If the function is returned to the module, there is no need to change the update message. Thank you!

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

I don't think it's a fix if we throw out an existing function. The update note doesn't mention that block plugin support has been dropped from the module.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Due to the changes made in this issue, Block plugins do not appear in version 4.0.0-rc1. All block plugins created under "[MODULE]/src/Plugin/Block" disappeared from the list. Please do not remove an existing function from the module. It can be added, but don't remove.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Patch #107 works fine with Drupal 9.5.7.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

The default branch is already 3.0.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Okay, do it! :)

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

jQuery .on() was introduced in jQuery 1.6 or 1.7? If I remember well, Drupal 7 uses jQuery v1.4 by default.
In my opinion, the simplest solution would be if we remove the jQuery usage (inside the jQuery Once callback).
Essentially, only the D10 code needs to be backported.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

I fixed this in the last commit.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Thank you for your help! I added you to the project as co-maintener.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Hi! the module is now compatible with Drupal 10. I removed the old jQuery Once library usages and I removed the full jQuery-dependency. The new minimum core version is 9.2 because of the new core Once library. I will make a new release soon.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Looks good to me! Thank you!

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

@noorulshameera and @grevil

The new Once library β†’ was introduced in Drupal v9.2, this means that the module will no longer be compatible with Drupal 8, so please set the minimum version to 9.2:

core_version_requirement: ^9.2 || ^10

Thank you!

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

I made a Merge request with the Drupal 10 compatibility fixes.

The main change is the new once library β†’ was introduced in Drupal 9.2.
In Drupal 10, the old jQuery Once Library is no longer available.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

lonalore β†’ made their first commit to this issue’s fork.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Thank you!

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Patch works fine for me. Thank you!

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

This patch works good for me.

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Please, use the latest release! Thank you!

πŸ‡­πŸ‡ΊHungary lonalore Budapest, Hungary

Please, use the latest release! Thank you!

Production build 0.69.0 2024